Re: [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive

All of lore.kernel.org
 help / color / mirror / Atom feed

* Re: [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive
       [not found] <20220620210856.771825-1-fontaine.fabrice__3982.8961993166$1655759559$gmane$org@gmail.com>
@ 2022-06-21 16:45 ` Bernd Kuhls
  0 siblings, 0 replies; 6+ messages in thread
From: Bernd Kuhls @ 2022-06-21 16:45 UTC (permalink / raw)
  To: buildroot

Am Mon, 20 Jun 2022 23:08:55 +0200 schrieb Fabrice Fontaine:

> Fix the following xephyr build failure with kdrive raised since commit
> eedbd6f97d51a0049ec512de26541465403ab06f:
> 
> checking for XEPHYR... no configure: error: Package requirements (xau
> xdmcp xcb xcb-shape xcb-render xcb-renderutil xcb-aux xcb-image
> xcb-icccm xcb-shm >= 1.9.3 xcb-keysyms xcb-randr xcb-xkb xcb-xv) were
> not met:
> 
> Package 'xcb-renderutil', required by 'virtual:world', not found Package
> 'xcb-aux', required by 'virtual:world', not found Package 'xcb-image',
> required by 'virtual:world', not found Package 'xcb-icccm', required by
> 'virtual:world', not found Package 'xcb-keysyms', required by
> 'virtual:world', not found
> 
> Fixes:
>  -
>  http://autobuild.buildroot.org/results/
baba218c879b67bfbadc9c25d34313abc76397bc
>  -
>  http://autobuild.buildroot.org/results/
9471b77db9aefa2fd0e5be61ea84709183511623
> 
> Signed-off-by: Fabrice Fontaine
> <fontaine.fabrice@gmail.com>

Reviewed-by: Bernd Kuhls <bernd.kuhls@t-online.de>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive
@ 2022-06-20 21:08 Fabrice Fontaine
  2022-06-20 21:22 ` Fabrice Fontaine
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-06-20 21:08 UTC (permalink / raw)
  To: buildroot; +Cc: Bernd Kuhls, Fabrice Fontaine

Fix the following xephyr build failure with kdrive raised since commit
eedbd6f97d51a0049ec512de26541465403ab06f:

checking for XEPHYR... no
configure: error: Package requirements (xau xdmcp xcb xcb-shape xcb-render xcb-renderutil xcb-aux xcb-image xcb-icccm xcb-shm >= 1.9.3 xcb-keysyms xcb-randr xcb-xkb xcb-xv) were not met:

Package 'xcb-renderutil', required by 'virtual:world', not found
Package 'xcb-aux', required by 'virtual:world', not found
Package 'xcb-image', required by 'virtual:world', not found
Package 'xcb-icccm', required by 'virtual:world', not found
Package 'xcb-keysyms', required by 'virtual:world', not found

Fixes:
 - http://autobuild.buildroot.org/results/baba218c879b67bfbadc9c25d34313abc76397bc
 - http://autobuild.buildroot.org/results/9471b77db9aefa2fd0e5be61ea84709183511623

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/x11r7/xserver_xorg-server/Config.in              | 4 ++++
 package/x11r7/xserver_xorg-server/xserver_xorg-server.mk | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
index 4fb03051dd..daf4d81702 100644
--- a/package/x11r7/xserver_xorg-server/Config.in
+++ b/package/x11r7/xserver_xorg-server/Config.in
@@ -85,6 +85,10 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER_XVFB
 
 config BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR
 	bool "Xephyr server"
+	select BR2_PACKAGE_XCB_UTIL_IMAGE if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
+	select BR2_PACKAGE_XCB_UTIL_KEYSYMS if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
+	select BR2_PACKAGE_XCB_UTIL_RENDERUTIL if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
+	select BR2_PACKAGE_XCB_UTIL_WM if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
 	help
 	  Xephyr nested X server; successor to Xnest.
 
diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
index 0f1779dcab..fa5d2a802d 100644
--- a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
+++ b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
@@ -84,6 +84,13 @@ XSERVER_XORG_SERVER_CONF_OPTS += \
 	--disable-glx \
 	--disable-dri
 
+ifeq ($(BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR),y)
+XSERVER_XORG_SERVER_DEPENDENCIES += \
+	xcb-util-image \
+	xcb-util-keysyms \
+	xcb-util-renderutil \
+	xcb-util-wm
+endif
 else # modular
 XSERVER_XORG_SERVER_CONF_OPTS += --disable-kdrive
 endif
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive
  2022-06-20 21:08 Fabrice Fontaine
@ 2022-06-20 21:22 ` Fabrice Fontaine
       [not found] ` <CAPi7W81oR4RwqWmFLq2M_EG-11N+B1sCOxhu_NT8xcTQnJ-ZCw__39402.966496867$1655760346$gmane$org@mail.gmail.com>
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-06-20 21:22 UTC (permalink / raw)
  To: Buildroot Mailing List; +Cc: Bernd Kuhls

Bernd already sent the same patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20220620184925.538342-1-bernd.kuhls@t-online.de/

I can set this one as superseded however I would advise to only add
those dependencies if BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR and
BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE are set.
Here is an extract of configure.ac:

if test "$KDRIVE" = yes; then
    XEPHYR_REQUIRED_LIBS="xau xdmcp xcb xcb-shape xcb-render
xcb-renderutil xcb-aux xcb-image xcb-icccm xcb-shm >= 1.9.3
xcb-keysyms xcb-randr xcb-xkb"

Le lun. 20 juin 2022 à 23:12, Fabrice Fontaine
<fontaine.fabrice@gmail.com> a écrit :
>
> Fix the following xephyr build failure with kdrive raised since commit
> eedbd6f97d51a0049ec512de26541465403ab06f:
>
> checking for XEPHYR... no
> configure: error: Package requirements (xau xdmcp xcb xcb-shape xcb-render xcb-renderutil xcb-aux xcb-image xcb-icccm xcb-shm >= 1.9.3 xcb-keysyms xcb-randr xcb-xkb xcb-xv) were not met:
>
> Package 'xcb-renderutil', required by 'virtual:world', not found
> Package 'xcb-aux', required by 'virtual:world', not found
> Package 'xcb-image', required by 'virtual:world', not found
> Package 'xcb-icccm', required by 'virtual:world', not found
> Package 'xcb-keysyms', required by 'virtual:world', not found
>
> Fixes:
>  - http://autobuild.buildroot.org/results/baba218c879b67bfbadc9c25d34313abc76397bc
>  - http://autobuild.buildroot.org/results/9471b77db9aefa2fd0e5be61ea84709183511623
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/x11r7/xserver_xorg-server/Config.in              | 4 ++++
>  package/x11r7/xserver_xorg-server/xserver_xorg-server.mk | 7 +++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
> index 4fb03051dd..daf4d81702 100644
> --- a/package/x11r7/xserver_xorg-server/Config.in
> +++ b/package/x11r7/xserver_xorg-server/Config.in
> @@ -85,6 +85,10 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER_XVFB
>
>  config BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR
>         bool "Xephyr server"
> +       select BR2_PACKAGE_XCB_UTIL_IMAGE if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
> +       select BR2_PACKAGE_XCB_UTIL_KEYSYMS if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
> +       select BR2_PACKAGE_XCB_UTIL_RENDERUTIL if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
> +       select BR2_PACKAGE_XCB_UTIL_WM if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
>         help
>           Xephyr nested X server; successor to Xnest.
>
> diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> index 0f1779dcab..fa5d2a802d 100644
> --- a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> +++ b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> @@ -84,6 +84,13 @@ XSERVER_XORG_SERVER_CONF_OPTS += \
>         --disable-glx \
>         --disable-dri
>
> +ifeq ($(BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR),y)
> +XSERVER_XORG_SERVER_DEPENDENCIES += \
> +       xcb-util-image \
> +       xcb-util-keysyms \
> +       xcb-util-renderutil \
> +       xcb-util-wm
> +endif
>  else # modular
>  XSERVER_XORG_SERVER_CONF_OPTS += --disable-kdrive
>  endif
> --
> 2.35.1
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <CAPi7W81oR4RwqWmFLq2M_EG-11N+B1sCOxhu_NT8xcTQnJ-ZCw__39402.966496867$1655760346$gmane$org@mail.gmail.com>]

* Re: [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive
       [not found] ` <CAPi7W81oR4RwqWmFLq2M_EG-11N+B1sCOxhu_NT8xcTQnJ-ZCw__39402.966496867$1655760346$gmane$org@mail.gmail.com>
@ 2022-06-21 16:44   ` Bernd Kuhls
  0 siblings, 0 replies; 6+ messages in thread
From: Bernd Kuhls @ 2022-06-21 16:44 UTC (permalink / raw)
  To: buildroot

Am Mon, 20 Jun 2022 23:22:26 +0200 schrieb Fabrice Fontaine:

> Bernd already sent the same patch:
> https://patchwork.ozlabs.org/project/buildroot/patch/
20220620184925.538342-1-bernd.kuhls@t-online.de/
> 
> I can set this one as superseded however I would advise to only add
> those dependencies if BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR and
> BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE are set.

Hi Fabrice,

you are right, the new dependencies should depend on 
BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR. I missed this additional 
dependency, therefore I marked my patch as superseded.

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive
  2022-06-20 21:08 Fabrice Fontaine
  2022-06-20 21:22 ` Fabrice Fontaine
       [not found] ` <CAPi7W81oR4RwqWmFLq2M_EG-11N+B1sCOxhu_NT8xcTQnJ-ZCw__39402.966496867$1655760346$gmane$org@mail.gmail.com>
@ 2022-07-23 19:21 ` Arnout Vandecappelle
  2022-08-16  9:37 ` Peter Korsgaard
  3 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-07-23 19:21 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Bernd Kuhls



On 20/06/2022 23:08, Fabrice Fontaine wrote:
> Fix the following xephyr build failure with kdrive raised since commit
> eedbd6f97d51a0049ec512de26541465403ab06f:
> 
> checking for XEPHYR... no
> configure: error: Package requirements (xau xdmcp xcb xcb-shape xcb-render xcb-renderutil xcb-aux xcb-image xcb-icccm xcb-shm >= 1.9.3 xcb-keysyms xcb-randr xcb-xkb xcb-xv) were not met:
> 
> Package 'xcb-renderutil', required by 'virtual:world', not found
> Package 'xcb-aux', required by 'virtual:world', not found
> Package 'xcb-image', required by 'virtual:world', not found
> Package 'xcb-icccm', required by 'virtual:world', not found
> Package 'xcb-keysyms', required by 'virtual:world', not found
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/baba218c879b67bfbadc9c25d34313abc76397bc
>   - http://autobuild.buildroot.org/results/9471b77db9aefa2fd0e5be61ea84709183511623
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/x11r7/xserver_xorg-server/Config.in              | 4 ++++
>   package/x11r7/xserver_xorg-server/xserver_xorg-server.mk | 7 +++++++
>   2 files changed, 11 insertions(+)
> 
> diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
> index 4fb03051dd..daf4d81702 100644
> --- a/package/x11r7/xserver_xorg-server/Config.in
> +++ b/package/x11r7/xserver_xorg-server/Config.in
> @@ -85,6 +85,10 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER_XVFB
>   
>   config BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR
>   	bool "Xephyr server"
> +	select BR2_PACKAGE_XCB_UTIL_IMAGE if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
> +	select BR2_PACKAGE_XCB_UTIL_KEYSYMS if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
> +	select BR2_PACKAGE_XCB_UTIL_RENDERUTIL if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
> +	select BR2_PACKAGE_XCB_UTIL_WM if BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
>   	help
>   	  Xephyr nested X server; successor to Xnest.
>   
> diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> index 0f1779dcab..fa5d2a802d 100644
> --- a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> +++ b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> @@ -84,6 +84,13 @@ XSERVER_XORG_SERVER_CONF_OPTS += \
>   	--disable-glx \
>   	--disable-dri
>   
> +ifeq ($(BR2_PACKAGE_XSERVER_XORG_SERVER_XEPHYR),y)
> +XSERVER_XORG_SERVER_DEPENDENCIES += \
> +	xcb-util-image \
> +	xcb-util-keysyms \
> +	xcb-util-renderutil \
> +	xcb-util-wm
> +endif
>   else # modular
>   XSERVER_XORG_SERVER_CONF_OPTS += --disable-kdrive
>   endif
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive
  2022-06-20 21:08 Fabrice Fontaine
                   ` (2 preceding siblings ...)
  2022-07-23 19:21 ` Arnout Vandecappelle
@ 2022-08-16  9:37 ` Peter Korsgaard
  3 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-08-16  9:37 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Bernd Kuhls, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following xephyr build failure with kdrive raised since commit
 > eedbd6f97d51a0049ec512de26541465403ab06f:

 > checking for XEPHYR... no
 > configure: error: Package requirements (xau xdmcp xcb xcb-shape
 > xcb-render xcb-renderutil xcb-aux xcb-image xcb-icccm xcb-shm >= 1.9.3
 > xcb-keysyms xcb-randr xcb-xkb xcb-xv) were not met:

 > Package 'xcb-renderutil', required by 'virtual:world', not found
 > Package 'xcb-aux', required by 'virtual:world', not found
 > Package 'xcb-image', required by 'virtual:world', not found
 > Package 'xcb-icccm', required by 'virtual:world', not found
 > Package 'xcb-keysyms', required by 'virtual:world', not found

 > Fixes:
 >  - http://autobuild.buildroot.org/results/baba218c879b67bfbadc9c25d34313abc76397bc
 >  - http://autobuild.buildroot.org/results/9471b77db9aefa2fd0e5be61ea84709183511623

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-08-16  9:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220620210856.771825-1-fontaine.fabrice__3982.8961993166$1655759559$gmane$org@gmail.com>
2022-06-21 16:45 ` [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: fix xephyr build with kdrive Bernd Kuhls
2022-06-20 21:08 Fabrice Fontaine
2022-06-20 21:22 ` Fabrice Fontaine
     [not found] ` <CAPi7W81oR4RwqWmFLq2M_EG-11N+B1sCOxhu_NT8xcTQnJ-ZCw__39402.966496867$1655760346$gmane$org@mail.gmail.com>
2022-06-21 16:44   ` Bernd Kuhls
2022-07-23 19:21 ` Arnout Vandecappelle
2022-08-16  9:37 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.