All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][meta-gnome] add metacity back
@ 2018-04-12  9:45 Hongxu Jia
  2018-04-12 10:37 ` Andreas Müller
  0 siblings, 1 reply; 8+ messages in thread
From: Hongxu Jia @ 2018-04-12  9:45 UTC (permalink / raw)
  To: schnitzeltony, akuster808; +Cc: openembedded-devel

It is required by meta-anaconda which is a graphic target
installer program anaconda that based on gnome.

http://git.yoctoproject.org/cgit/cgit.cgi/meta-anaconda

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 .../metacity/0001-ui-Define-_GNU_SOURCE.patch      | 27 +++++++++++++++++
 .../metacity/remove-yelp-help-rules-var.patch      | 28 +++++++++++++++++
 .../recipes-gnome/metacity/metacity_2.34.13.bb     | 35 ++++++++++++++++++++++
 3 files changed, 90 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
 create mode 100644 meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
 create mode 100644 meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb

diff --git a/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch b/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
new file mode 100644
index 0000000..539d756
--- /dev/null
+++ b/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
@@ -0,0 +1,27 @@
+From e7fd072f0df968f342878b77098e97ff07ed28d7 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Fri, 14 Jul 2017 10:26:31 -0700
+Subject: [PATCH] ui: Define _GNU_SOURCE
+
+it becomes portable across musl and glibc
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ src/ui/theme.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/ui/theme.c b/src/ui/theme.c
+index 84b57a0..c7eafc8 100644
+--- a/src/ui/theme.c
++++ b/src/ui/theme.c
+@@ -60,6 +60,7 @@
+ #include <gtk/gtk.h>
+ #include <string.h>
+ #include <stdlib.h>
++#define _GNU_SOURCE
+ #define __USE_XOPEN
+ #include <math.h>
+ 
+-- 
+2.13.3
+
diff --git a/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch b/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
new file mode 100644
index 0000000..1970e9a
--- /dev/null
+++ b/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
@@ -0,0 +1,28 @@
+Remove unused variable (YELP_HELP_RULES)
+
+Upstream-Status: Pending
+Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
+
+Index: metacity-2.34.13/doc/creating_themes/Makefile.am
+===================================================================
+--- metacity-2.34.13.orig/doc/creating_themes/Makefile.am
++++ metacity-2.34.13/doc/creating_themes/Makefile.am
+@@ -1,6 +1,5 @@
+ ### This part of Makefile.am can be customized by you.
+ 
+-@YELP_HELP_RULES@
+ 
+ # The name of the directory in /usr/share/gnome/help/, 
+ # and the name of the main .xml file:
+Index: metacity-2.34.13/doc/creating_themes/Makefile.in
+===================================================================
+--- metacity-2.34.13.orig/doc/creating_themes/Makefile.in
++++ metacity-2.34.13/doc/creating_themes/Makefile.in
+@@ -455,7 +455,6 @@ uninstall-am:
+ 	mostlyclean-libtool pdf pdf-am ps ps-am uninstall uninstall-am
+ 
+ 
+-@YELP_HELP_RULES@
+ 
+ # Tell versions [3.59,3.63) of GNU make to not export all variables.
+ # Otherwise a system limit (for SysV at least) may be exceeded.
diff --git a/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
new file mode 100644
index 0000000..370de70
--- /dev/null
+++ b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
@@ -0,0 +1,35 @@
+SECTION = "x11/wm"
+SUMMARY = "Metacity is the boring window manager for the adult in you"
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
+                    file://src/include/main.h;endline=24;md5=c2242df552c880280315989bab626b90"
+
+DEPENDS = "gsettings-desktop-schemas startup-notification gtk+ gconf gdk-pixbuf-native libcanberra gnome-doc-utils libgtop intltool-native"
+PR = "r1"
+
+inherit gnomebase update-alternatives distro_features_check
+# depends on startup-notification which depends on virtual/libx11
+REQUIRED_DISTRO_FEATURES = "x11"
+
+GNOME_COMPRESS_TYPE = "xz"
+
+SRC_URI = "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive \
+           file://remove-yelp-help-rules-var.patch \
+           file://0001-ui-Define-_GNU_SOURCE.patch \
+           "
+SRC_URI[archive.md5sum] = "6d89b71672d4fa49fc87f83d610d0ef6"
+SRC_URI[archive.sha256sum] = "8cf4dbf0da0a6f36357ce7db7f829ec685908a7792453c662fb8184572b91075"
+
+ALTERNATIVE_${PN} = "x-window-manager"
+ALTERNATIVE_TARGET[x-window-manager] = "${bindir}/metacity"
+ALTERNATIVE_PRIORITY = "10"
+
+EXTRA_OECONF += "--disable-xinerama"
+
+do_configure_prepend() {
+    sed -i -e 's:$ZENITY:$NOZENITY:g' -e 's:-Werror::g' ${S}/configure.in
+}
+
+FILES_${PN} += "${datadir}/themes ${datadir}/gnome-control-center ${datadir}/gnome"
+RDEPENDS_${PN} += "gsettings-desktop-schemas"
+
-- 
2.8.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH][meta-gnome] add metacity back
  2018-04-12  9:45 [PATCH][meta-gnome] add metacity back Hongxu Jia
@ 2018-04-12 10:37 ` Andreas Müller
  2018-04-13  2:57   ` [PATCH V2][meta-gnome] metacity: add back and change upstream Hongxu Jia
  2018-04-13  3:09   ` [PATCH][meta-gnome] add metacity back Hongxu Jia
  0 siblings, 2 replies; 8+ messages in thread
From: Andreas Müller @ 2018-04-12 10:37 UTC (permalink / raw)
  To: Hongxu Jia; +Cc: openembeded-devel

On Thu, Apr 12, 2018 at 11:45 AM, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> It is required by meta-anaconda which is a graphic target
> installer program anaconda that based on gnome.
>
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-anaconda
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  .../metacity/0001-ui-Define-_GNU_SOURCE.patch      | 27 +++++++++++++++++
>  .../metacity/remove-yelp-help-rules-var.patch      | 28 +++++++++++++++++
>  .../recipes-gnome/metacity/metacity_2.34.13.bb     | 35 ++++++++++++++++++++++
>  3 files changed, 90 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
>  create mode 100644 meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
>  create mode 100644 meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
>
> diff --git a/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch b/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
> new file mode 100644
> index 0000000..539d756
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
> @@ -0,0 +1,27 @@
> +From e7fd072f0df968f342878b77098e97ff07ed28d7 Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Fri, 14 Jul 2017 10:26:31 -0700
> +Subject: [PATCH] ui: Define _GNU_SOURCE
> +
> +it becomes portable across musl and glibc
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +---
> + src/ui/theme.c | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/ui/theme.c b/src/ui/theme.c
> +index 84b57a0..c7eafc8 100644
> +--- a/src/ui/theme.c
> ++++ b/src/ui/theme.c
> +@@ -60,6 +60,7 @@
> + #include <gtk/gtk.h>
> + #include <string.h>
> + #include <stdlib.h>
> ++#define _GNU_SOURCE
> + #define __USE_XOPEN
> + #include <math.h>
> +
> +--
> +2.13.3
> +
> diff --git a/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch b/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
> new file mode 100644
> index 0000000..1970e9a
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
> @@ -0,0 +1,28 @@
> +Remove unused variable (YELP_HELP_RULES)
> +
> +Upstream-Status: Pending
> +Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
> +
> +Index: metacity-2.34.13/doc/creating_themes/Makefile.am
> +===================================================================
> +--- metacity-2.34.13.orig/doc/creating_themes/Makefile.am
> ++++ metacity-2.34.13/doc/creating_themes/Makefile.am
> +@@ -1,6 +1,5 @@
> + ### This part of Makefile.am can be customized by you.
> +
> +-@YELP_HELP_RULES@
> +
> + # The name of the directory in /usr/share/gnome/help/,
> + # and the name of the main .xml file:
> +Index: metacity-2.34.13/doc/creating_themes/Makefile.in
> +===================================================================
> +--- metacity-2.34.13.orig/doc/creating_themes/Makefile.in
> ++++ metacity-2.34.13/doc/creating_themes/Makefile.in
> +@@ -455,7 +455,6 @@ uninstall-am:
> +       mostlyclean-libtool pdf pdf-am ps ps-am uninstall uninstall-am
> +
> +
> +-@YELP_HELP_RULES@
> +
> + # Tell versions [3.59,3.63) of GNU make to not export all variables.
> + # Otherwise a system limit (for SysV at least) may be exceeded.
> diff --git a/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
> new file mode 100644
> index 0000000..370de70
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
> @@ -0,0 +1,35 @@
> +SECTION = "x11/wm"
> +SUMMARY = "Metacity is the boring window manager for the adult in you"
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
> +                    file://src/include/main.h;endline=24;md5=c2242df552c880280315989bab626b90"
> +
> +DEPENDS = "gsettings-desktop-schemas startup-notification gtk+ gconf gdk-pixbuf-native libcanberra gnome-doc-utils libgtop intltool-native"
> +PR = "r1"
> +
> +inherit gnomebase update-alternatives distro_features_check
> +# depends on startup-notification which depends on virtual/libx11
> +REQUIRED_DISTRO_FEATURES = "x11"
> +
> +GNOME_COMPRESS_TYPE = "xz"
> +
> +SRC_URI = "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive \
> +           file://remove-yelp-help-rules-var.patch \
> +           file://0001-ui-Define-_GNU_SOURCE.patch \
> +           "
> +SRC_URI[archive.md5sum] = "6d89b71672d4fa49fc87f83d610d0ef6"
> +SRC_URI[archive.sha256sum] = "8cf4dbf0da0a6f36357ce7db7f829ec685908a7792453c662fb8184572b91075"
> +
> +ALTERNATIVE_${PN} = "x-window-manager"
> +ALTERNATIVE_TARGET[x-window-manager] = "${bindir}/metacity"
> +ALTERNATIVE_PRIORITY = "10"
> +
> +EXTRA_OECONF += "--disable-xinerama"
> +
> +do_configure_prepend() {
> +    sed -i -e 's:$ZENITY:$NOZENITY:g' -e 's:-Werror::g' ${S}/configure.in
> +}
> +
> +FILES_${PN} += "${datadir}/themes ${datadir}/gnome-control-center ${datadir}/gnome"
> +RDEPENDS_${PN} += "gsettings-desktop-schemas"
> +
> --
> 2.8.1
>
Why not add there?


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH V2][meta-gnome] metacity: add back and change upstream
  2018-04-12 10:37 ` Andreas Müller
@ 2018-04-13  2:57   ` Hongxu Jia
  2018-04-13  8:22     ` Koen Kooi
  2018-04-13  3:09   ` [PATCH][meta-gnome] add metacity back Hongxu Jia
  1 sibling, 1 reply; 8+ messages in thread
From: Hongxu Jia @ 2018-04-13  2:57 UTC (permalink / raw)
  To: schnitzeltony, akuster808; +Cc: openembedded-devel

The metacity is still maintained on github, so change
the upstream.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 .../metacity/0001-ui-Define-_GNU_SOURCE.patch      | 32 ++++++++++++++++++++
 .../metacity/remove-yelp-help-rules-var.patch      | 28 ++++++++++++++++++
 .../recipes-gnome/metacity/metacity_2.34.13.bb     | 34 ++++++++++++++++++++++
 3 files changed, 94 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
 create mode 100644 meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
 create mode 100644 meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb

diff --git a/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch b/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
new file mode 100644
index 0000000..5ad38cb
--- /dev/null
+++ b/meta-gnome/recipes-gnome/metacity/metacity/0001-ui-Define-_GNU_SOURCE.patch
@@ -0,0 +1,32 @@
+From 17a9f3c4b98511a8c524af327cbb4b4b850962c6 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Fri, 14 Jul 2017 10:26:31 -0700
+Subject: [PATCH 2/2] ui: Define _GNU_SOURCE
+
+it becomes portable across musl and glibc
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Upstream-Status: Pending
+
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+
+---
+ src/ui/theme.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/ui/theme.c b/src/ui/theme.c
+index 84b57a0..c7eafc8 100644
+--- a/src/ui/theme.c
++++ b/src/ui/theme.c
+@@ -60,6 +60,7 @@
+ #include <gtk/gtk.h>
+ #include <string.h>
+ #include <stdlib.h>
++#define _GNU_SOURCE
+ #define __USE_XOPEN
+ #include <math.h>
+ 
+-- 
+1.8.3.1
+
diff --git a/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch b/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
new file mode 100644
index 0000000..d3f28c0
--- /dev/null
+++ b/meta-gnome/recipes-gnome/metacity/metacity/remove-yelp-help-rules-var.patch
@@ -0,0 +1,28 @@
+From 880374176c2741f7d0180b61fca35113b523afc1 Mon Sep 17 00:00:00 2001
+From: Constantin Musca <constantinx.musca@intel.com>
+Date: Fri, 13 Apr 2018 10:36:22 +0800
+Subject: [PATCH 1/2] Remove unused variable (YELP_HELP_RULES)
+
+Upstream-Status: Pending
+Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
+
+Rebase from gnome tarball to github
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+---
+ doc/creating_themes/Makefile.am | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/doc/creating_themes/Makefile.am b/doc/creating_themes/Makefile.am
+index 65d8fad..4935d87 100644
+--- a/doc/creating_themes/Makefile.am
++++ b/doc/creating_themes/Makefile.am
+@@ -1,6 +1,5 @@
+ ### This part of Makefile.am can be customized by you.
+ 
+-@YELP_HELP_RULES@
+ 
+ # The name of the directory in /usr/share/gnome/help/, 
+ # and the name of the main .xml file:
+-- 
+1.8.3.1
+
diff --git a/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
new file mode 100644
index 0000000..e7c84e0
--- /dev/null
+++ b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
@@ -0,0 +1,34 @@
+SECTION = "x11/wm"
+SUMMARY = "Metacity is the boring window manager for the adult in you"
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
+                    file://src/include/main.h;endline=24;md5=c2242df552c880280315989bab626b90"
+
+DEPENDS = "gsettings-desktop-schemas startup-notification gtk+ gconf gdk-pixbuf-native libcanberra gnome-doc-utils libgtop intltool-native"
+PR = "r1"
+
+inherit gnomebase update-alternatives distro_features_check
+# depends on startup-notification which depends on virtual/libx11
+REQUIRED_DISTRO_FEATURES = "x11"
+
+SRC_URI = "git://github.com/GNOME/metacity.git;branch=master \
+           file://remove-yelp-help-rules-var.patch \
+           file://0001-ui-Define-_GNU_SOURCE.patch \
+"
+
+S = "${WORKDIR}/git"
+SRCREV = "a9e0144d21f954aff95772b889a79e72a81861be"
+
+ALTERNATIVE_${PN} = "x-window-manager"
+ALTERNATIVE_TARGET[x-window-manager] = "${bindir}/metacity"
+ALTERNATIVE_PRIORITY = "10"
+
+EXTRA_OECONF += "--disable-xinerama"
+
+do_configure_prepend() {
+    sed -i -e 's:$ZENITY:$NOZENITY:g' -e 's:-Werror::g' ${S}/configure.in
+}
+
+FILES_${PN} += "${datadir}/themes ${datadir}/gnome-control-center ${datadir}/gnome"
+RDEPENDS_${PN} += "gsettings-desktop-schemas"
+
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH][meta-gnome] add metacity back
  2018-04-12 10:37 ` Andreas Müller
  2018-04-13  2:57   ` [PATCH V2][meta-gnome] metacity: add back and change upstream Hongxu Jia
@ 2018-04-13  3:09   ` Hongxu Jia
  1 sibling, 0 replies; 8+ messages in thread
From: Hongxu Jia @ 2018-04-13  3:09 UTC (permalink / raw)
  To: Andreas Müller; +Cc: openembeded-devel


> Why not add there?

It is a very basic app which fedora/redhat integrate it into

its installation.


If some one else ask for it, we have to move it again.

//Hongxu


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2][meta-gnome] metacity: add back and change upstream
  2018-04-13  2:57   ` [PATCH V2][meta-gnome] metacity: add back and change upstream Hongxu Jia
@ 2018-04-13  8:22     ` Koen Kooi
  2018-04-13  9:08       ` Hongxu Jia
  0 siblings, 1 reply; 8+ messages in thread
From: Koen Kooi @ 2018-04-13  8:22 UTC (permalink / raw)
  To: openembedded-devel

Op 13-04-18 om 04:57 schreef Hongxu Jia:

> +
> diff --git a/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb

> +PR = "r1"
Please drop the PR=r1 line, since the recipe gets readded there shouldn't be an issue for package feeds.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2][meta-gnome] metacity: add back and change upstream
  2018-04-13  8:22     ` Koen Kooi
@ 2018-04-13  9:08       ` Hongxu Jia
  2018-04-13 11:11         ` Koen Kooi
  0 siblings, 1 reply; 8+ messages in thread
From: Hongxu Jia @ 2018-04-13  9:08 UTC (permalink / raw)
  To: Koen Kooi, openembedded-devel

On 2018年04月13日 16:22, Koen Kooi wrote:
> Op 13-04-18 om 04:57 schreef Hongxu Jia:
>
>> +
>> diff --git a/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
>> +PR = "r1"
> Please drop the PR=r1 line, since the recipe gets readded there shouldn't be an issue for package feeds.
>

I do not drop it on purpose, if the oe developer do not

update the repo frequently, the missing RP caused confusing?


//Hongxu






^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2][meta-gnome] metacity: add back and change upstream
  2018-04-13  9:08       ` Hongxu Jia
@ 2018-04-13 11:11         ` Koen Kooi
  2018-04-13 11:29           ` Andreas Müller
  0 siblings, 1 reply; 8+ messages in thread
From: Koen Kooi @ 2018-04-13 11:11 UTC (permalink / raw)
  To: openembedded-devel

Op 13-04-18 om 11:08 schreef Hongxu Jia:
> On 2018年04月13日 16:22, Koen Kooi wrote:
>> Op 13-04-18 om 04:57 schreef Hongxu Jia:
>>
>>> +
>>> diff --git a/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
>>> +PR = "r1"
>> Please drop the PR=r1 line, since the recipe gets readded there shouldn't be an issue for package feeds.
>>
> 
> I do not drop it on purpose, if the oe developer do not
> 
> update the repo frequently, the missing RP caused confusing?

I don't think it is too confusing, if someone really needs it a bbappend is easy enough to write and drop into their DISTRO layer.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2][meta-gnome] metacity: add back and change upstream
  2018-04-13 11:11         ` Koen Kooi
@ 2018-04-13 11:29           ` Andreas Müller
  0 siblings, 0 replies; 8+ messages in thread
From: Andreas Müller @ 2018-04-13 11:29 UTC (permalink / raw)
  To: Koen Kooi; +Cc: openembeded-devel

On Fri, Apr 13, 2018 at 1:11 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Op 13-04-18 om 11:08 schreef Hongxu Jia:
>> On 2018年04月13日 16:22, Koen Kooi wrote:
>>> Op 13-04-18 om 04:57 schreef Hongxu Jia:
>>>
>>>> +
>>>> diff --git a/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb b/meta-gnome/recipes-gnome/metacity/metacity_2.34.13.bb
>>>> +PR = "r1"
>>> Please drop the PR=r1 line, since the recipe gets readded there shouldn't be an issue for package feeds.
>>>
>>
>> I do not drop it on purpose, if the oe developer do not
>>
>> update the repo frequently, the missing RP caused confusing?
>
> I don't think it is too confusing, if someone really needs it a bbappend is easy enough to write and drop into their DISTRO layer.
>
Best solution would be to re-add to a recent 3.xx and remove PR then...

Andreas


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-04-13 11:29 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12  9:45 [PATCH][meta-gnome] add metacity back Hongxu Jia
2018-04-12 10:37 ` Andreas Müller
2018-04-13  2:57   ` [PATCH V2][meta-gnome] metacity: add back and change upstream Hongxu Jia
2018-04-13  8:22     ` Koen Kooi
2018-04-13  9:08       ` Hongxu Jia
2018-04-13 11:11         ` Koen Kooi
2018-04-13 11:29           ` Andreas Müller
2018-04-13  3:09   ` [PATCH][meta-gnome] add metacity back Hongxu Jia

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.