* [PATCH] config.h: remove unused git_configset_add_parameters()
@ 2023-02-07 16:15 Ævar Arnfjörð Bjarmason
2023-02-07 17:55 ` Glen Choo
0 siblings, 1 reply; 2+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2023-02-07 16:15 UTC (permalink / raw)
To: git; +Cc: Glen Choo, Junio C Hamano, Ævar Arnfjörð Bjarmason
This function was removed in ecec57b3c97 (config: respect includes in
protected config, 2022-10-13), but its prototype was left here.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
A trivial cleanup for a change new in v2.39.0.
config.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/config.h b/config.h
index ef9eade6414..7606246531a 100644
--- a/config.h
+++ b/config.h
@@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs);
*/
int git_configset_add_file(struct config_set *cs, const char *filename);
-/**
- * Parses command line options and environment variables, and adds the
- * variable-value pairs to the `config_set`. Returns 0 on success, or -1
- * if there is an error in parsing. The caller decides whether to free
- * the incomplete configset or continue using it when the function
- * returns -1.
- */
-int git_configset_add_parameters(struct config_set *cs);
-
/**
* Finds and returns the value list, sorted in order of increasing priority
* for the configuration variable `key` and config set `cs`. When the
--
2.39.1.1430.gb2471c0aaf4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] config.h: remove unused git_configset_add_parameters()
2023-02-07 16:15 [PATCH] config.h: remove unused git_configset_add_parameters() Ævar Arnfjörð Bjarmason
@ 2023-02-07 17:55 ` Glen Choo
0 siblings, 0 replies; 2+ messages in thread
From: Glen Choo @ 2023-02-07 17:55 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason, git
Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> This function was removed in ecec57b3c97 (config: respect includes in
> protected config, 2022-10-13), but its prototype was left here.
Ugh, that's my mistake. Thanks for the catch.
> diff --git a/config.h b/config.h
> index ef9eade6414..7606246531a 100644
> --- a/config.h
> +++ b/config.h
> @@ -447,15 +447,6 @@ void git_configset_init(struct config_set *cs);
> */
> int git_configset_add_file(struct config_set *cs, const char *filename);
>
> -/**
> - * Parses command line options and environment variables, and adds the
> - * variable-value pairs to the `config_set`. Returns 0 on success, or -1
> - * if there is an error in parsing. The caller decides whether to free
> - * the incomplete configset or continue using it when the function
> - * returns -1.
> - */
> -int git_configset_add_parameters(struct config_set *cs);
> -
> /**
> * Finds and returns the value list, sorted in order of increasing priority
> * for the configuration variable `key` and config set `cs`. When the
> --
> 2.39.1.1430.gb2471c0aaf4
Reviewed-by: Glen Choo <chooglen@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-07 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 16:15 [PATCH] config.h: remove unused git_configset_add_parameters() Ævar Arnfjörð Bjarmason
2023-02-07 17:55 ` Glen Choo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.