All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shay Agroskin <shayagr@amazon.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: Shay Agroskin <shayagr@amazon.com>, <dwmw@amazon.com>,
	<zorik@amazon.com>, <matua@amazon.com>, <saeedb@amazon.com>,
	<msw@amazon.com>, <aliguori@amazon.com>, <nafea@amazon.com>,
	<gtzalik@amazon.com>, <netanel@amazon.com>, <alisaidi@amazon.com>,
	<benh@amazon.com>, <akiyano@amazon.com>, <sameehj@amazon.com>,
	<ndagan@amazon.com>
Subject: Re: [PATCH V1 net-next 5/8] net: ena: Remove redundant print of placement policy
Date: Sun, 13 Sep 2020 14:03:24 +0300	[thread overview]
Message-ID: <pj41zlsgbmdjlv.fsf@u68c7b5b1d2d758.ant.amazon.com> (raw)
In-Reply-To: <20200913082056.3610-6-shayagr@amazon.com>


Shay Agroskin <shayagr@amazon.com> writes:

> The placement policy is printed in the process of queue creation 
> in
> ena_up(). No need to print it in ena_probe().
>
> Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
> Signed-off-by: Shay Agroskin <shayagr@amazon.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index cab83a9de651..97e701222226 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -4156,7 +4156,6 @@ static int ena_probe(struct pci_dev *pdev, 
> const struct pci_device_id *ent)
>  	struct net_device *netdev;
>  	static int adapters_found;
>  	u32 max_num_io_queues;
> -	char *queue_type_str;
>  	bool wd_state;
>  	int bars, rc;
>  
> @@ -4334,15 +4333,10 @@ static int ena_probe(struct pci_dev 
> *pdev, const struct pci_device_id *ent)
>  	timer_setup(&adapter->timer_service, ena_timer_service, 
>  0);
>  	mod_timer(&adapter->timer_service, round_jiffies(jiffies + 
>  HZ));
>  
> -	if (ena_dev->tx_mem_queue_type == 
> ENA_ADMIN_PLACEMENT_POLICY_HOST)
> -		queue_type_str = "Regular";
> -	else
> -		queue_type_str = "Low Latency";
> -
>  	dev_info(&pdev->dev,
> -		 "%s found at mem %lx, mac addr %pM, Placement 
> policy: %s\n",
> +		 "%s found at mem %lx, mac addr %pM\n",
>  		 DEVICE_NAME, (long)pci_resource_start(pdev, 0),
> -		 netdev->dev_addr, queue_type_str);
> +		 netdev->dev_addr);
>  
>  	set_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);

Hi, I got this patchset messed up a little. These patches are part 
of the 'Update license and polish ENA driver code' patchset 
(Message-id: <20200913081640.19560-1-shayagr@amazon.com>)
Sorry for the clutter. Please let me know it you prefer that I 
re-send this patchset as a single thread

      parent reply	other threads:[~2020-09-13 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13  8:20 [PATCH V1 net-next 5/8] net: ena: Remove redundant print of placement policy Shay Agroskin
2020-09-13  8:20 ` [PATCH V1 net-next 6/8] net: ena: Change RSS related macros and variables names Shay Agroskin
2020-09-13  8:20 ` [PATCH V1 net-next 7/8] net: ena: Fix all static chekers' warnings Shay Agroskin
2020-09-13  8:20 ` [PATCH V1 net-next 8/8] net: ena: update ena documentation Shay Agroskin
2020-09-13 11:03 ` Shay Agroskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pj41zlsgbmdjlv.fsf@u68c7b5b1d2d758.ant.amazon.com \
    --to=shayagr@amazon.com \
    --cc=akiyano@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=alisaidi@amazon.com \
    --cc=benh@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=matua@amazon.com \
    --cc=msw@amazon.com \
    --cc=nafea@amazon.com \
    --cc=ndagan@amazon.com \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedb@amazon.com \
    --cc=sameehj@amazon.com \
    --cc=zorik@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.