From: Su Yue <l@damenly.su>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH RFC 2/3] btrfs: consolidate device_list_mutex in prepare_sprout to its parent
Date: Sat, 21 Aug 2021 23:00:20 +0800 [thread overview]
Message-ID: <pmu6eta9.fsf@damenly.su> (raw)
In-Reply-To: <sfz2etf4.fsf@damenly.su>
On Sat 21 Aug 2021 at 22:57, Su Yue <l@damenly.su> wrote:
> On Fri 20 Aug 2021 at 16:53, Anand Jain <anand.jain@oracle.com>
> wrote:
>
>>>> @@ -2366,6 +2366,8 @@ static int btrfs_prepare_sprout(struct
>>>> btrfs_fs_info *fs_info)
>>>> u64 super_flags;
>>>>
>>>> lockdep_assert_held(&uuid_mutex);
>>>> + lockdep_assert_held(&fs_devices->device_list_mutex);
>>>> +
>>>>
>>> Just a reminder: clone_fs_devices() still takes the mutex in
>>> misc-next.
>> As I am checking clone_fs_devices() does not take any lock.
>> Could you pls recheck?
>>
>
> Hmmmm... misc-next:
>
> https://github.com/kdave/btrfs-devel/blob/e05983195f31374ad51a0f3712efec381397f3cb/fs/btrfs/volumes.c#L381
Sorry, it should be
https://github.com/kdave/btrfs-devel/blob/misc-next/fs/btrfs/volumes.c#L995
--
Su
next prev parent reply other threads:[~2021-08-21 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 18:18 [PATCH 0/3] btrf_show_devname related fixes Anand Jain
2021-08-19 18:18 ` [PATCH 1/3] btrfs: fix comment about the btrfs_show_devname Anand Jain
2021-08-19 18:18 ` [PATCH RFC 2/3] btrfs: consolidate device_list_mutex in prepare_sprout to its parent Anand Jain
2021-08-20 7:51 ` Su Yue
2021-08-20 8:53 ` Anand Jain
2021-08-21 14:57 ` Su Yue
2021-08-21 15:00 ` Su Yue [this message]
2021-08-23 10:34 ` Anand Jain
2021-08-23 10:54 ` Anand Jain
2021-08-23 12:20 ` David Sterba
2021-08-19 18:18 ` [PATCH RFC 3/3] btrfs: use latest_bdev in btrfs_show_devname Anand Jain
2021-08-20 7:31 ` Su Yue
2021-08-20 9:13 ` Anand Jain
2021-08-20 10:57 ` David Sterba
2021-08-20 11:03 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pmu6eta9.fsf@damenly.su \
--to=l@damenly.su \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.