* [PATCH] IDE: pass IRQ flags to the IDE core
@ 2010-04-08 14:26 Yegor Yefremov
2010-04-15 9:16 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Yegor Yefremov @ 2010-04-08 14:26 UTC (permalink / raw)
To: linux-ide; +Cc: davem
IDE: pass IRQ flags to the IDE core
This enables shared IRQs and other features to be used with platform devices
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Index: b/drivers/ide/ide_platform.c
===================================================================
--- a/drivers/ide/ide_platform.c 2010-04-02 01:02:33.000000000 +0200
+++ b/drivers/ide/ide_platform.c 2010-04-08 16:04:21.000000000 +0200
@@ -95,6 +95,7 @@
plat_ide_setup_ports(&hw, base, alt_base, pdata, res_irq->start);
hw.dev = &pdev->dev;
+ d.irq_flags = res_irq->flags;
if (mmio)
d.host_flags |= IDE_HFLAG_MMIO;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IDE: pass IRQ flags to the IDE core
2010-04-08 14:26 [PATCH] IDE: pass IRQ flags to the IDE core Yegor Yefremov
@ 2010-04-15 9:16 ` David Miller
2010-04-15 11:07 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2010-04-15 9:16 UTC (permalink / raw)
To: yegorslists; +Cc: linux-ide
From: Yegor Yefremov <yegorslists@googlemail.com>
Date: Thu, 8 Apr 2010 16:26:29 +0200
> IDE: pass IRQ flags to the IDE core
>
> This enables shared IRQs and other features to be used with platform devices
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
If you need this for a new device, please use the ATA layer
instead of adding support for new features in IDE which is
in deep maintainence mode only.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IDE: pass IRQ flags to the IDE core
2010-04-15 9:16 ` David Miller
@ 2010-04-15 11:07 ` Alan Cox
2010-04-15 21:17 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2010-04-15 11:07 UTC (permalink / raw)
To: David Miller; +Cc: yegorslists, linux-ide
On Thu, 15 Apr 2010 02:16:12 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> Date: Thu, 8 Apr 2010 16:26:29 +0200
>
> > IDE: pass IRQ flags to the IDE core
> >
> > This enables shared IRQs and other features to be used with platform devices
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> If you need this for a new device, please use the ATA layer
> instead of adding support for new features in IDE which is
> in deep maintainence mode only.
Actually Dave I think that one should go in. pata_platform (libata) and
ide_platform both match the same platform objects so you can flip between
them easily (eg for testing work). The fact the IRQ flags are only
honoured in libata but not in the matching IDE driver is probably a good
thing to fix.
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IDE: pass IRQ flags to the IDE core
2010-04-15 11:07 ` Alan Cox
@ 2010-04-15 21:17 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-04-15 21:17 UTC (permalink / raw)
To: alan; +Cc: yegorslists, linux-ide
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 15 Apr 2010 12:07:48 +0100
> On Thu, 15 Apr 2010 02:16:12 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>> Date: Thu, 8 Apr 2010 16:26:29 +0200
>>
>> > IDE: pass IRQ flags to the IDE core
>> >
>> > This enables shared IRQs and other features to be used with platform devices
>> >
>> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> If you need this for a new device, please use the ATA layer
>> instead of adding support for new features in IDE which is
>> in deep maintainence mode only.
>
> Actually Dave I think that one should go in. pata_platform (libata) and
> ide_platform both match the same platform objects so you can flip between
> them easily (eg for testing work). The fact the IRQ flags are only
> honoured in libata but not in the matching IDE driver is probably a good
> thing to fix.
Ok, will apply this then.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-15 21:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-08 14:26 [PATCH] IDE: pass IRQ flags to the IDE core Yegor Yefremov
2010-04-15 9:16 ` David Miller
2010-04-15 11:07 ` Alan Cox
2010-04-15 21:17 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.