All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Arnd Bergmann <arnd@arndb.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: core: avoid -Wempty-body warnings
Date: Mon, 22 Mar 2021 12:26:45 +0100	[thread overview]
Message-ID: <s5h1rc7e8ei.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210322103128.547199-1-arnd@kernel.org>

On Mon, 22 Mar 2021 11:31:10 +0100,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Building with 'make W=1' shows some warnings about empty function-style
> macros:
> 
> sound/core/pcm_memory.c: In function 'preallocate_pages':
> sound/core/pcm_memory.c:236:49: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>   236 |                 preallocate_info_init(substream);
> 
> sound/core/seq_device.c: In function 'snd_seq_device_dev_register':
> sound/core/seq_device.c:163:41: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>   163 |                 queue_autoload_drivers();
> 
> Change them to empty inline functions, which are more robust here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ALSA: core: avoid -Wempty-body warnings
Date: Mon, 22 Mar 2021 12:26:45 +0100	[thread overview]
Message-ID: <s5h1rc7e8ei.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210322103128.547199-1-arnd@kernel.org>

On Mon, 22 Mar 2021 11:31:10 +0100,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Building with 'make W=1' shows some warnings about empty function-style
> macros:
> 
> sound/core/pcm_memory.c: In function 'preallocate_pages':
> sound/core/pcm_memory.c:236:49: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>   236 |                 preallocate_info_init(substream);
> 
> sound/core/seq_device.c: In function 'snd_seq_device_dev_register':
> sound/core/seq_device.c:163:41: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>   163 |                 queue_autoload_drivers();
> 
> Change them to empty inline functions, which are more robust here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.


Takashi

  reply	other threads:[~2021-03-22 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 10:31 [PATCH] ALSA: core: avoid -Wempty-body warnings Arnd Bergmann
2021-03-22 10:31 ` Arnd Bergmann
2021-03-22 11:26 ` Takashi Iwai [this message]
2021-03-22 11:26   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1rc7e8ei.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.