* Intel HDA / ca0132: quirk for Alienware 17 2015
@ 2015-12-08 16:53 Gabriele Martino
2015-12-09 6:00 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Gabriele Martino @ 2015-12-08 16:53 UTC (permalink / raw)
To: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
The Alienware 17 (2015) has the same card and pin configuration of the
Alienware 15, so the same quirks must be applied.
Signed-off-by: Gabriele Martino <g.martino@gmx.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ca0132-quirk-alienware17.patch --]
[-- Type: text/x-patch; name="ca0132-quirk-alienware17.patch", Size: 1237 bytes --]
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index f8a12ca..41e8848 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -760,7 +760,8 @@ struct ca0132_spec {
*/
enum {
QUIRK_NONE,
- QUIRK_ALIENWARE,
+ QUIRK_ALIENWARE_15,
+ QUIRK_ALIENWARE_17,
};
static const struct hda_pintbl alienware_pincfgs[] = {
@@ -778,7 +779,8 @@ static const struct hda_pintbl alienware_pincfgs[] = {
};
static const struct snd_pci_quirk ca0132_quirks[] = {
- SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15", QUIRK_ALIENWARE),
+ SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE_15),
+ SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE_17),
{}
};
@@ -4631,8 +4633,8 @@ static void ca0132_config(struct hda_codec *codec)
spec->multiout.num_dacs = 3;
spec->multiout.max_channels = 2;
- if (spec->quirk == QUIRK_ALIENWARE) {
- codec_dbg(codec, "ca0132_config: QUIRK_ALIENWARE applied.\n");
+ if (spec->quirk == QUIRK_ALIENWARE_15 || spec->quirk == QUIRK_ALIENWARE_17) {
+ codec_dbg(codec, "ca0132_config: QUIRK_ALIENWARE_* applied.\n");
snd_hda_apply_pincfgs(codec, alienware_pincfgs);
spec->num_outputs = 2;
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: Intel HDA / ca0132: quirk for Alienware 17 2015
2015-12-08 16:53 Intel HDA / ca0132: quirk for Alienware 17 2015 Gabriele Martino
@ 2015-12-09 6:00 ` Takashi Iwai
2015-12-09 16:05 ` Gabriele Martino
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2015-12-09 6:00 UTC (permalink / raw)
To: Gabriele Martino; +Cc: alsa-devel
On Tue, 08 Dec 2015 17:53:04 +0100,
Gabriele Martino wrote:
>
> The Alienware 17 (2015) has the same card and pin configuration of the
> Alienware 15, so the same quirks must be applied.
>
> Signed-off-by: Gabriele Martino <g.martino@gmx.com>
>
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index f8a12ca..41e8848 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -760,7 +760,8 @@ struct ca0132_spec {
> */
> enum {
> QUIRK_NONE,
> - QUIRK_ALIENWARE,
> + QUIRK_ALIENWARE_15,
> + QUIRK_ALIENWARE_17,
> };
>
> static const struct hda_pintbl alienware_pincfgs[] = {
> @@ -778,7 +779,8 @@ static const struct hda_pintbl alienware_pincfgs[] = {
> };
>
> static const struct snd_pci_quirk ca0132_quirks[] = {
> - SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15", QUIRK_ALIENWARE),
> + SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE_15),
> + SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE_17),
> {}
> };
>
> @@ -4631,8 +4633,8 @@ static void ca0132_config(struct hda_codec *codec)
> spec->multiout.num_dacs = 3;
> spec->multiout.max_channels = 2;
>
> - if (spec->quirk == QUIRK_ALIENWARE) {
> - codec_dbg(codec, "ca0132_config: QUIRK_ALIENWARE applied.\n");
> + if (spec->quirk == QUIRK_ALIENWARE_15 || spec->quirk == QUIRK_ALIENWARE_17) {
If it's the very same quirk, you don't have to invent a new name, but
just add a line:
SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE),
So it'd be a oneliner. Could you respin and resubmit the patch?
thanks,
Takashi
> + codec_dbg(codec, "ca0132_config: QUIRK_ALIENWARE_* applied.\n");
> snd_hda_apply_pincfgs(codec, alienware_pincfgs);
>
> spec->num_outputs = 2;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Intel HDA / ca0132: quirk for Alienware 17 2015
2015-12-09 6:00 ` Takashi Iwai
@ 2015-12-09 16:05 ` Gabriele Martino
2015-12-09 16:07 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Gabriele Martino @ 2015-12-09 16:05 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
The Alienware 17 (2015) has the same card and pin configuration of the
Alienware 15, so the same quirks must be applied.
Signed-off-by: Gabriele Martino <g.martino@gmx.com>
[-- Attachment #2: ca0132-quirk-alienware17.patch --]
[-- Type: text/x-patch, Size: 528 bytes --]
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index f8a12ca..4ef2259 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -778,7 +778,8 @@ static const struct hda_pintbl alienware_pincfgs[] = {
};
static const struct snd_pci_quirk ca0132_quirks[] = {
- SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15", QUIRK_ALIENWARE),
+ SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE),
+ SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE),
{}
};
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: Intel HDA / ca0132: quirk for Alienware 17 2015
2015-12-09 16:05 ` Gabriele Martino
@ 2015-12-09 16:07 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2015-12-09 16:07 UTC (permalink / raw)
To: Gabriele Martino; +Cc: alsa-devel
On Wed, 09 Dec 2015 17:05:58 +0100,
Gabriele Martino wrote:
>
> The Alienware 17 (2015) has the same card and pin configuration of the
> Alienware 15, so the same quirks must be applied.
>
> Signed-off-by: Gabriele Martino <g.martino@gmx.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index f8a12ca..4ef2259 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -778,7 +778,8 @@ static const struct hda_pintbl alienware_pincfgs[] = {
> };
>
> static const struct snd_pci_quirk ca0132_quirks[] = {
> - SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15", QUIRK_ALIENWARE),
> + SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE),
> + SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE),
> {}
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-09 16:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-08 16:53 Intel HDA / ca0132: quirk for Alienware 17 2015 Gabriele Martino
2015-12-09 6:00 ` Takashi Iwai
2015-12-09 16:05 ` Gabriele Martino
2015-12-09 16:07 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.