[PATCH] ALSA: usb-audio: Enable .product_name override for Emagic, Unitor 8.

[PATCH] ALSA: usb-audio: Enable .product_name override for Emagic, Unitor 8.

[Stefan Sauer]

>From a41303935608e9a98653d4dff1e10baf1ce07e05 Mon Sep 17 00:00:00 2001
From: Stefan Sauer <ensonic@google.com>
Date: Mon, 10 Jun 2019 11:26:53 +0200
Subject: [PATCH] ALSA: usb-audio: Enable .product_name override for Emagic
 Unitor 8.

The Emagic Unitor 8 does not provide iManufacturer and iProduct fields
in its device descriptor. These fields are used by alsa to make build the
device name. Thus uncomment the .product-name in the quirks-table.

Without this change the device shows up as 'USB Device 0x86a:0x01'.

Output of lsusb and amidi:
https://gist.github.com/ensonic/7820a102e91f31575be355da2b6b33bc

Signed-off-by: Stefan Sauer <ensonic@google.com>
---
 sound/usb/quirks-table.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 9e049f60e80e..e918ce346027 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -2408,7 +2408,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 	USB_DEVICE(0x086a, 0x0001),
 	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
 		.vendor_name = "Emagic",
-		/* .product_name = "Unitor8", */
+		.product_name = "Unitor8",
 		.ifnum = 2,
 		.type = QUIRK_MIDI_EMAGIC,
 		.data = & (const struct snd_usb_midi_endpoint_info) {
-- 
2.21.0

Re: [ALSA patch] [PATCH] ALSA: usb-audio: Enable .product_name override for Emagic, Unitor 8.

[Takashi Iwai]

On Mon, 10 Jun 2019 11:51:46 +0200,
Stefan Sauer wrote:
> 
> >From a41303935608e9a98653d4dff1e10baf1ce07e05 Mon Sep 17 00:00:00 2001
> From: Stefan Sauer <ensonic@google.com>
> Date: Mon, 10 Jun 2019 11:26:53 +0200
> Subject: [PATCH] ALSA: usb-audio: Enable .product_name override for Emagic
>  Unitor 8.
> 
> The Emagic Unitor 8 does not provide iManufacturer and iProduct fields
> in its device descriptor. These fields are used by alsa to make build the
> device name. Thus uncomment the .product-name in the quirks-table.
> 
> Without this change the device shows up as 'USB Device 0x86a:0x01'.
> 
> Output of lsusb and amidi:
> https://gist.github.com/ensonic/7820a102e91f31575be355da2b6b33bc
> 
> Signed-off-by: Stefan Sauer <ensonic@google.com>

Applied now.  Thanks.


Takashi