All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: rmove print for failure of kmalloc
@ 2016-08-21  2:17 Shawn Lin
  2016-08-22  9:41 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Shawn Lin @ 2016-08-21  2:17 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: alsa-devel, Shawn Lin

kmalloc already print similar error once failing to alloc
enough memory, so let's remove this dump here.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 sound/usb/format.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/usb/format.c b/sound/usb/format.c
index 789d19e..2c44386 100644
--- a/sound/usb/format.c
+++ b/sound/usb/format.c
@@ -176,10 +176,8 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
 		int r, idx;
 
 		fp->rate_table = kmalloc(sizeof(int) * nr_rates, GFP_KERNEL);
-		if (fp->rate_table == NULL) {
-			usb_audio_err(chip, "cannot malloc\n");
+		if (fp->rate_table == NULL)
 			return -ENOMEM;
-		}
 
 		fp->nr_rates = 0;
 		fp->rate_min = fp->rate_max = 0;
-- 
2.3.7

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: usb-audio: rmove print for failure of kmalloc
  2016-08-21  2:17 [PATCH] ALSA: usb-audio: rmove print for failure of kmalloc Shawn Lin
@ 2016-08-22  9:41 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-08-22  9:41 UTC (permalink / raw)
  To: Shawn Lin; +Cc: alsa-devel

On Sun, 21 Aug 2016 04:17:36 +0200,
Shawn Lin wrote:
> 
> kmalloc already print similar error once failing to alloc
> enough memory, so let's remove this dump here.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-22  9:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-21  2:17 [PATCH] ALSA: usb-audio: rmove print for failure of kmalloc Shawn Lin
2016-08-22  9:41 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.