All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: snd-usb: use list_for_each_safe for endpoint resources
@ 2012-08-30 21:11 Pavel Roskin
  2012-08-31 16:18 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Roskin @ 2012-08-30 21:11 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel

snd_usb_endpoint_free() frees the structure that contains its argument.

Signed-off-by: Pavel Roskin <proski@gnu.org>
Cc: stable@vger.kernel.org
---

 sound/usb/card.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/usb/card.c b/sound/usb/card.c
index d5b5c33..4a469f0 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -553,7 +553,7 @@ static void snd_usb_audio_disconnect(struct usb_device *dev,
 				     struct snd_usb_audio *chip)
 {
 	struct snd_card *card;
-	struct list_head *p;
+	struct list_head *p, *n;
 
 	if (chip == (void *)-1L)
 		return;
@@ -570,7 +570,7 @@ static void snd_usb_audio_disconnect(struct usb_device *dev,
 			snd_usb_stream_disconnect(p);
 		}
 		/* release the endpoint resources */
-		list_for_each(p, &chip->ep_list) {
+		list_for_each_safe(p, n, &chip->ep_list) {
 			snd_usb_endpoint_free(p);
 		}
 		/* release the midi resources */

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: snd-usb: use list_for_each_safe for endpoint resources
  2012-08-30 21:11 [PATCH] ALSA: snd-usb: use list_for_each_safe for endpoint resources Pavel Roskin
@ 2012-08-31 16:18 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2012-08-31 16:18 UTC (permalink / raw)
  To: Pavel Roskin; +Cc: alsa-devel

At Thu, 30 Aug 2012 17:11:17 -0400,
Pavel Roskin wrote:
> 
> snd_usb_endpoint_free() frees the structure that contains its argument.
> 
> Signed-off-by: Pavel Roskin <proski@gnu.org>
> Cc: stable@vger.kernel.org

Thanks, applied now.


Takashi

> ---
> 
>  sound/usb/card.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index d5b5c33..4a469f0 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -553,7 +553,7 @@ static void snd_usb_audio_disconnect(struct usb_device *dev,
>  				     struct snd_usb_audio *chip)
>  {
>  	struct snd_card *card;
> -	struct list_head *p;
> +	struct list_head *p, *n;
>  
>  	if (chip == (void *)-1L)
>  		return;
> @@ -570,7 +570,7 @@ static void snd_usb_audio_disconnect(struct usb_device *dev,
>  			snd_usb_stream_disconnect(p);
>  		}
>  		/* release the endpoint resources */
> -		list_for_each(p, &chip->ep_list) {
> +		list_for_each_safe(p, n, &chip->ep_list) {
>  			snd_usb_endpoint_free(p);
>  		}
>  		/* release the midi resources */
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-31 16:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-30 21:11 [PATCH] ALSA: snd-usb: use list_for_each_safe for endpoint resources Pavel Roskin
2012-08-31 16:18 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.