All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Patch for enabling LFE on more Dell laptops
@ 2007-02-13 11:01 Mikael Nilsson
  2007-02-13 11:52 ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Mikael Nilsson @ 2007-02-13 11:01 UTC (permalink / raw)
  To: alsa-devel

(please cc: me on replies, I'm not on the list)

Referring to

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092

I'd like to add this patch to the snd-hda-intel driver. The patch is
against 1.0.14rc2.

Summary: Fix LFE controls for Dell Inspiron E1705/9400 and XPS M1710 laptops

Signed-off-by: Mikael Nilsson <mikael@nilsson.name>

--- patch_sigmatel.c.orig       2007-02-13 11:49:53.000000000 +0100
+++ patch_sigmatel.c    2007-02-13 11:51:25.000000000 +0100
@@ -455,6 +455,10 @@
                      "Dell Latitude D620", STAC_REF),
        SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
                      "Dell Latitude 120L", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
+                     "Dell Inspiron E1705/9400", STAC_REF),
+       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
+                     "Dell XPS M1710", STAC_REF),
        {} /* terminator */
 };
 

Thanks,

/Mikael
-- 
<mikael@nilsson.name>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Patch for enabling LFE on more Dell laptops
  2007-02-13 11:01 [PATCH] Patch for enabling LFE on more Dell laptops Mikael Nilsson
@ 2007-02-13 11:52 ` Takashi Iwai
  2007-02-13 12:04   ` Mikael Nilsson
  2007-02-13 19:11   ` Mikael Nilsson
  0 siblings, 2 replies; 5+ messages in thread
From: Takashi Iwai @ 2007-02-13 11:52 UTC (permalink / raw)
  To: Mikael Nilsson; +Cc: alsa-devel

At Tue, 13 Feb 2007 12:01:04 +0100,
Mikael Nilsson wrote:
> 
> (please cc: me on replies, I'm not on the list)
> 
> Referring to
> 
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092
> 
> I'd like to add this patch to the snd-hda-intel driver. The patch is
> against 1.0.14rc2.
> 
> Summary: Fix LFE controls for Dell Inspiron E1705/9400 and XPS M1710 laptops
> 
> Signed-off-by: Mikael Nilsson <mikael@nilsson.name>

The patch couldn't be applied to the latest HG tree (or 2.6.21-git)
but I fixed it manually.  Also, the embedded patch in your mail seems
broken.  Check your MUA.

Anyway, the patch is applied to ALSA HG tree now.  Thanks.


Takashi

> 
> --- patch_sigmatel.c.orig       2007-02-13 11:49:53.000000000 +0100
> +++ patch_sigmatel.c    2007-02-13 11:51:25.000000000 +0100
> @@ -455,6 +455,10 @@
>                       "Dell Latitude D620", STAC_REF),
>         SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
>                       "Dell Latitude 120L", STAC_REF),
> +       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
> +                     "Dell Inspiron E1705/9400", STAC_REF),
> +       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
> +                     "Dell XPS M1710", STAC_REF),
>         {} /* terminator */
>  };
>  
> 
> Thanks,
> 
> /Mikael
> -- 
> <mikael@nilsson.name>
> 
> Plus ça change, plus c'est la même chose
> 
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Patch for enabling LFE on more Dell laptops
  2007-02-13 11:52 ` Takashi Iwai
@ 2007-02-13 12:04   ` Mikael Nilsson
  2007-02-13 19:11   ` Mikael Nilsson
  1 sibling, 0 replies; 5+ messages in thread
From: Mikael Nilsson @ 2007-02-13 12:04 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel

On tis, 2007-02-13 at 12:52 +0100, Takashi Iwai wrote:
> At Tue, 13 Feb 2007 12:01:04 +0100,
> Mikael Nilsson wrote:
> > 
> > (please cc: me on replies, I'm not on the list)
> > 
> > Referring to
> > 
> > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092
> > 
> > I'd like to add this patch to the snd-hda-intel driver. The patch is
> > against 1.0.14rc2.
> > 
> > Summary: Fix LFE controls for Dell Inspiron E1705/9400 and XPS M1710 laptops
> > 
> > Signed-off-by: Mikael Nilsson <mikael@nilsson.name>
> 
> The patch couldn't be applied to the latest HG tree (or 2.6.21-git)
> but I fixed it manually.  Also, the embedded patch in your mail seems
> broken.  Check your MUA.

Duh... thanks in any case. The bugs 

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2092
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2170
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2580

can probably be closed by this patch.

/Mikael

> 
> Anyway, the patch is applied to ALSA HG tree now.  Thanks.
> 
> 
> Takashi
> 
> > 
> > --- patch_sigmatel.c.orig       2007-02-13 11:49:53.000000000 +0100
> > +++ patch_sigmatel.c    2007-02-13 11:51:25.000000000 +0100
> > @@ -455,6 +455,10 @@
> >                       "Dell Latitude D620", STAC_REF),
> >         SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
> >                       "Dell Latitude 120L", STAC_REF),
> > +       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
> > +                     "Dell Inspiron E1705/9400", STAC_REF),
> > +       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
> > +                     "Dell XPS M1710", STAC_REF),
> >         {} /* terminator */
> >  };
> >  
> > 
> > Thanks,
> > 
> > /Mikael
> > -- 
> > <mikael@nilsson.name>
> > 
> > Plus ça change, plus c'est la même chose
> > 
> > 
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job easier.
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/alsa-devel
> 
-- 
<mikael@nilsson.name>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Patch for enabling LFE on more Dell laptops
  2007-02-13 11:52 ` Takashi Iwai
  2007-02-13 12:04   ` Mikael Nilsson
@ 2007-02-13 19:11   ` Mikael Nilsson
  2007-02-14 12:21     ` Takashi Iwai
  1 sibling, 1 reply; 5+ messages in thread
From: Mikael Nilsson @ 2007-02-13 19:11 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel

On tis, 2007-02-13 at 12:52 +0100, Takashi Iwai wrote:

> Anyway, the patch is applied to ALSA HG tree now.  Thanks.

While we're at it, please add the Precision M90 as well:

        SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cf,
                      "Dell Precision M90", STAC_REF), 

/Mikael

> 
> 
> 
> Takashi
> 
> > 
> > --- patch_sigmatel.c.orig       2007-02-13 11:49:53.000000000 +0100
> > +++ patch_sigmatel.c    2007-02-13 11:51:25.000000000 +0100
> > @@ -455,6 +455,10 @@
> >                       "Dell Latitude D620", STAC_REF),
> >         SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cb,
> >                       "Dell Latitude 120L", STAC_REF),
> > +       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cd,
> > +                     "Dell Inspiron E1705/9400", STAC_REF),
> > +       SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01ce,
> > +                     "Dell XPS M1710", STAC_REF),
> >         {} /* terminator */
> >  };
> >  
> > 
> > Thanks,
> > 
> > /Mikael
> > -- 
> > <mikael@nilsson.name>
> > 
> > Plus ça change, plus c'est la même chose
> > 
> > 
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job easier.
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/alsa-devel
> 
-- 
<mikael@nilsson.name>

Plus ça change, plus c'est la même chose


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Patch for enabling LFE on more Dell laptops
  2007-02-13 19:11   ` Mikael Nilsson
@ 2007-02-14 12:21     ` Takashi Iwai
  0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2007-02-14 12:21 UTC (permalink / raw)
  To: Mikael Nilsson; +Cc: alsa-devel

At Tue, 13 Feb 2007 20:11:43 +0100,
Mikael Nilsson wrote:
> 
> On tis, 2007-02-13 at 12:52 +0100, Takashi Iwai wrote:
> 
> > Anyway, the patch is applied to ALSA HG tree now.  Thanks.
> 
> While we're at it, please add the Precision M90 as well:
> 
>         SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x01cf,
>                       "Dell Precision M90", STAC_REF), 

Added to HG tree.  Thanks.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-02-14 12:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-13 11:01 [PATCH] Patch for enabling LFE on more Dell laptops Mikael Nilsson
2007-02-13 11:52 ` Takashi Iwai
2007-02-13 12:04   ` Mikael Nilsson
2007-02-13 19:11   ` Mikael Nilsson
2007-02-14 12:21     ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.