* [PATCH] ALSA: hda/ca0132 - Fix build error without CONFIG_PCI
@ 2019-02-05 17:01 Takashi Iwai
2019-02-06 0:17 ` Kuninori Morimoto
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2019-02-05 17:01 UTC (permalink / raw)
To: alsa-devel; +Cc: Kuninori Morimoto
A call of pci_iounmap() call without CONFIG_PCI leads to a build error
on some architectures. We tried to address this and add a check of
IS_ENABLED(CONFIG_PCI), but this still doesn't seem enough for sh.
Ideally we should fix it globally, it's really a corner case, so let's
paper over it with a simpler ifdef.
Fixes: 1e73359a24fa ("ALSA: hda/ca0132 - make pci_iounmap() call conditional")
Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/hda/patch_ca0132.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index e5bdbc245682..29882bda7632 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -8451,8 +8451,10 @@ static void ca0132_free(struct hda_codec *codec)
ca0132_exit_chip(codec);
snd_hda_power_down(codec);
- if (IS_ENABLED(CONFIG_PCI) && spec->mem_base)
+#ifdef CONFIG_PCI
+ if (spec->mem_base)
pci_iounmap(codec->bus->pci, spec->mem_base);
+#endif
kfree(spec->spec_init_verbs);
kfree(codec->spec);
}
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/ca0132 - Fix build error without CONFIG_PCI
2019-02-05 17:01 [PATCH] ALSA: hda/ca0132 - Fix build error without CONFIG_PCI Takashi Iwai
@ 2019-02-06 0:17 ` Kuninori Morimoto
2019-02-06 6:41 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Kuninori Morimoto @ 2019-02-06 0:17 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
Hi Takashi-san
> A call of pci_iounmap() call without CONFIG_PCI leads to a build error
> on some architectures. We tried to address this and add a check of
> IS_ENABLED(CONFIG_PCI), but this still doesn't seem enough for sh.
> Ideally we should fix it globally, it's really a corner case, so let's
> paper over it with a simpler ifdef.
>
> Fixes: 1e73359a24fa ("ALSA: hda/ca0132 - make pci_iounmap() call conditional")
> Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
Thanks.
It solved my SH compile issue !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/ca0132 - Fix build error without CONFIG_PCI
2019-02-06 0:17 ` Kuninori Morimoto
@ 2019-02-06 6:41 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2019-02-06 6:41 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: alsa-devel
On Wed, 06 Feb 2019 01:17:09 +0100,
Kuninori Morimoto wrote:
>
>
> Hi Takashi-san
>
> > A call of pci_iounmap() call without CONFIG_PCI leads to a build error
> > on some architectures. We tried to address this and add a check of
> > IS_ENABLED(CONFIG_PCI), but this still doesn't seem enough for sh.
> > Ideally we should fix it globally, it's really a corner case, so let's
> > paper over it with a simpler ifdef.
> >
> > Fixes: 1e73359a24fa ("ALSA: hda/ca0132 - make pci_iounmap() call conditional")
> > Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
>
> Thanks.
> It solved my SH compile issue !!
OK, queued to for-linus branch now.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-06 6:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 17:01 [PATCH] ALSA: hda/ca0132 - Fix build error without CONFIG_PCI Takashi Iwai
2019-02-06 0:17 ` Kuninori Morimoto
2019-02-06 6:41 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.