* [PATCH] ALSA: fireworks: add support for Loud Onyx 1200f quirk
@ 2021-11-11 10:30 Takashi Sakamoto
2021-11-11 13:03 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Sakamoto @ 2021-11-11 10:30 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, clemens
Loud Technologies shipped Onyx 1200f 2008 in its Mackie brand and
already discontinued. The model uses component of Fireworks board
module as its communication and DSP function.
The latest firmware (v4.6.0) has a quirk that tx packet includes wrong
value (0x1f) in its dbs field at middle and higher sampling transfer
frequency. It brings ALSA fireworks driver discontinuity of data block
counter.
This commit fixes it by assuming it as a quirk of firmware version
4.6.0.
$ cd linux-firewire-tools/src
$ python crpp < /sys/bus/firewire/devices/fw1/config_rom
ROM header and bus information block
-----------------------------------------------------------------
400 0404b9ef bus_info_length 4, crc_length 4, crc 47599
404 31333934 bus_name "1394"
408 e064a212 irmc 1, cmc 1, isc 1, bmc 0, pmc 0, cyc_clk_acc 100,
max_rec 10 (2048), max_rom 2, gen 1, spd 2 (S400)
40c 000ff209 company_id 000ff2 |
410 62550ce0 device_id 0962550ce0 | EUI-64 000ff20962550ce0
root directory
-----------------------------------------------------------------
414 0008088e directory_length 8, crc 2190
418 03000ff2 vendor
41c 8100000f --> descriptor leaf at 458
420 1701200f model
424 81000018 --> descriptor leaf at 484
428 0c008380 node capabilities
42c 8d000003 --> eui-64 leaf at 438
430 d1000005 --> unit directory at 444
434 08000ff2 (immediate value)
eui-64 leaf at 438
-----------------------------------------------------------------
438 000281ae leaf_length 2, crc 33198
43c 000ff209 company_id 000ff2 |
440 62550ce0 device_id 0962550ce0 | EUI-64 000ff20962550ce0
unit directory at 444
-----------------------------------------------------------------
444 00045d94 directory_length 4, crc 23956
448 1200a02d specifier id: 1394 TA
44c 13010000 version
450 1701200f model
454 8100000c --> descriptor leaf at 484
descriptor leaf at 458
-----------------------------------------------------------------
458 000a199d leaf_length 10, crc 6557
45c 00000000 textual descriptor
460 00000000 minimal ASCII
464 4d61636b "Mack"
468 69650000 "ie"
46c 00000000
470 00000000
474 00000000
478 00000000
47c 00000000
480 00000000
descriptor leaf at 484
-----------------------------------------------------------------
484 000a0964 leaf_length 10, crc 2404
488 00000000 textual descriptor
48c 00000000 minimal ASCII
490 4f6e7978 "Onyx"
494 20313230 " 120"
498 30460000 "0F"
49c 00000000
4a0 00000000
4a4 00000000
4a8 00000000
4ac 00000000
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
sound/firewire/fireworks/fireworks_stream.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/firewire/fireworks/fireworks_stream.c b/sound/firewire/fireworks/fireworks_stream.c
index ac66f08acd6b..53dbd4d4b0d0 100644
--- a/sound/firewire/fireworks/fireworks_stream.c
+++ b/sound/firewire/fireworks/fireworks_stream.c
@@ -50,8 +50,9 @@ static int init_stream(struct snd_efw *efw, struct amdtp_stream *stream)
efw->firmware_version == 0x5070300 ||
efw->firmware_version == 0x5080000))
efw->tx_stream.flags |= CIP_UNALIGHED_DBC;
- // AudioFire9 always reports wrong dbs.
- if (efw->is_af9)
+ // AudioFire9 always reports wrong dbs. Onyx 1200F with the latest firmware (v4.6.0)
+ // also report wrong dbs at 88.2 kHz or greater.
+ if (efw->is_af9 || efw->firmware_version == 0x4060000)
efw->tx_stream.flags |= CIP_WRONG_DBS;
// Firmware version 5.5 reports fixed interval for dbc.
if (efw->firmware_version == 0x5050000)
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: fireworks: add support for Loud Onyx 1200f quirk
2021-11-11 10:30 [PATCH] ALSA: fireworks: add support for Loud Onyx 1200f quirk Takashi Sakamoto
@ 2021-11-11 13:03 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-11-11 13:03 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: alsa-devel, clemens
On Thu, 11 Nov 2021 11:30:15 +0100,
Takashi Sakamoto wrote:
>
> Loud Technologies shipped Onyx 1200f 2008 in its Mackie brand and
> already discontinued. The model uses component of Fireworks board
> module as its communication and DSP function.
>
> The latest firmware (v4.6.0) has a quirk that tx packet includes wrong
> value (0x1f) in its dbs field at middle and higher sampling transfer
> frequency. It brings ALSA fireworks driver discontinuity of data block
> counter.
>
> This commit fixes it by assuming it as a quirk of firmware version
> 4.6.0.
>
> $ cd linux-firewire-tools/src
> $ python crpp < /sys/bus/firewire/devices/fw1/config_rom
> ROM header and bus information block
> -----------------------------------------------------------------
> 400 0404b9ef bus_info_length 4, crc_length 4, crc 47599
> 404 31333934 bus_name "1394"
> 408 e064a212 irmc 1, cmc 1, isc 1, bmc 0, pmc 0, cyc_clk_acc 100,
> max_rec 10 (2048), max_rom 2, gen 1, spd 2 (S400)
> 40c 000ff209 company_id 000ff2 |
> 410 62550ce0 device_id 0962550ce0 | EUI-64 000ff20962550ce0
>
> root directory
> -----------------------------------------------------------------
> 414 0008088e directory_length 8, crc 2190
> 418 03000ff2 vendor
> 41c 8100000f --> descriptor leaf at 458
> 420 1701200f model
> 424 81000018 --> descriptor leaf at 484
> 428 0c008380 node capabilities
> 42c 8d000003 --> eui-64 leaf at 438
> 430 d1000005 --> unit directory at 444
> 434 08000ff2 (immediate value)
>
> eui-64 leaf at 438
> -----------------------------------------------------------------
> 438 000281ae leaf_length 2, crc 33198
> 43c 000ff209 company_id 000ff2 |
> 440 62550ce0 device_id 0962550ce0 | EUI-64 000ff20962550ce0
>
> unit directory at 444
> -----------------------------------------------------------------
> 444 00045d94 directory_length 4, crc 23956
> 448 1200a02d specifier id: 1394 TA
> 44c 13010000 version
> 450 1701200f model
> 454 8100000c --> descriptor leaf at 484
>
> descriptor leaf at 458
> -----------------------------------------------------------------
> 458 000a199d leaf_length 10, crc 6557
> 45c 00000000 textual descriptor
> 460 00000000 minimal ASCII
> 464 4d61636b "Mack"
> 468 69650000 "ie"
> 46c 00000000
> 470 00000000
> 474 00000000
> 478 00000000
> 47c 00000000
> 480 00000000
>
> descriptor leaf at 484
> -----------------------------------------------------------------
> 484 000a0964 leaf_length 10, crc 2404
> 488 00000000 textual descriptor
> 48c 00000000 minimal ASCII
> 490 4f6e7978 "Onyx"
> 494 20313230 " 120"
> 498 30460000 "0F"
> 49c 00000000
> 4a0 00000000
> 4a4 00000000
> 4a8 00000000
> 4ac 00000000
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-11 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 10:30 [PATCH] ALSA: fireworks: add support for Loud Onyx 1200f quirk Takashi Sakamoto
2021-11-11 13:03 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.