[alsa-devel] [PATCH v2] ALSA: usb-audio: add quirks for Line6 Helix devices fw>=2.82

[alsa-devel] [PATCH v2] ALSA: usb-audio: add quirks for Line6 Helix devices fw>=2.82

[Nicola Lunghi]

With firmware 2.82 Line6 changed the usb id of some of the Helix
devices but the quirks is still needed.

Add it to the quirk list for line6 helix family of devices.

Thanks to Jens for pointing out the missing ids.

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
 sound/usb/format.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/usb/format.c b/sound/usb/format.c
index d79db71305f6..53922f73467f 100644
--- a/sound/usb/format.c
+++ b/sound/usb/format.c
@@ -296,6 +296,9 @@ static int line6_parse_audio_format_rates_quirk(struct snd_usb_audio *chip,
 	case USB_ID(0x0E41, 0x4242): /* Line6 Helix Rack */
 	case USB_ID(0x0E41, 0x4244): /* Line6 Helix LT */
 	case USB_ID(0x0E41, 0x4246): /* Line6 HX-Stomp */
+	case USB_ID(0x0E41, 0x4248): /* Line6 Helix >= fw 2.82 */
+	case USB_ID(0x0E41, 0x4249): /* Line6 Helix Rack >= fw 2.82 */
+	case USB_ID(0x0E41, 0x424a): /* Line6 Helix LT >= fw 2.82 */
 		/* supported rates: 48Khz */
 		kfree(fp->rate_table);
 		fp->rate_table = kmalloc(sizeof(int), GFP_KERNEL);
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH v2] ALSA: usb-audio: add quirks for Line6 Helix devices fw>=2.82

[Jens Verwiebe]

Hi Nicola

Thx for headsup.

Hope i did not sound too harsh.

I fear you lost a bit overlook ;-) over the forum posts where also

Shemesg etc. confirmed.

All good so far.

I'am also a bit closer to understand the missing sync problem.

Just have to decide if to force an implicite feedback enpoint and make

that respond properly or rather do the more modern way to ommit and

resample.

Apple has some interesting information about the possible proceedings:

https://developer.apple.com/library/archive/technotes/tn2274/_index.html


Jens

-- 

Jens Verwiebe
Allerskehre 44 - 22309 Hamburg

Tel.: +49 40 68 78 50
mailto: info@jensverwiebe.de
web: https://www.jensverwiebe.de

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH v2] ALSA: usb-audio: add quirks for Line6 Helix devices fw>=2.82

[Takashi Iwai]

On Sat, 25 Jan 2020 16:09:17 +0100,
Nicola Lunghi wrote:
> 
> With firmware 2.82 Line6 changed the usb id of some of the Helix
> devices but the quirks is still needed.
> 
> Add it to the quirk list for line6 helix family of devices.
> 
> Thanks to Jens for pointing out the missing ids.
> 
> Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>

Applied now.  Thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel