Re: [alsa-devel] [PATCH 05/23] ALSA: firewire: Drop superfluous ioctl PCM ops

[Takashi Iwai <tiwai@suse.de>]

On Tue, 10 Dec 2019 16:49:28 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Tue, Dec 10, 2019 at 07:11:27AM +0100, Takashi Iwai wrote:
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  sound/firewire/bebob/bebob_pcm.c         | 2 --
> >  sound/firewire/dice/dice-pcm.c           | 2 --
> >  sound/firewire/digi00x/digi00x-pcm.c     | 2 --
> >  sound/firewire/fireface/ff-pcm.c         | 2 --
> >  sound/firewire/fireworks/fireworks_pcm.c | 2 --
> >  sound/firewire/isight.c                  | 1 -
> >  sound/firewire/motu/motu-pcm.c           | 2 --
> >  sound/firewire/oxfw/oxfw-pcm.c           | 2 --
> >  sound/firewire/tascam/tascam-pcm.c       | 2 --
> >  9 files changed, 17 deletions(-)
> 
> I understand that this patch is based on the below commit:
>  * fc033cbf6fb7("ALSA: pcm: Allow NULL ioctl ops")[1]
> 
> All of the changes are fine to me.
> 
> Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> 
> [1] https://mailman.alsa-project.org/pipermail/alsa-devel/2019-November/158692.html 

Thanks.  It's good idea to put the background information.  I'll add
it to the changelog.

Actually I seem to have forgotten to fill the changelog text in this
commit.  Below is the revised patch to be committed.


Takashi

-- 8< --
Subject: [PATCH] ALSA: firewire: Drop superfluous ioctl PCM ops

All the PCM ioctl ops of ALSA FireWire drivers do nothing but calling
the default handler.

Now PCM core accepts NULL as the default ioctl ops(*), so let's drop
altogether.

(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191210061145.24641-6-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel