Patches for Packard Bell EasyNote laptop support

Patches for Packard Bell EasyNote laptop support

[Matthew Flint]

See https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1134


All,

Bug report 1134 tracks progress in getting ALSA to work with a Packard
Bell laptop, model "EasyNote A8202". There are three simple patches
needed against ALSA v1.0.14rc2.

Can I ask a for a kind ALSA developer to merge these patches into
trunk, for out-of-the-box support in the next release of ALSA drivers?

Thanks in advance,
Matthew

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: Patches for Packard Bell EasyNote laptop support

[Takashi Iwai]

At Wed, 7 Feb 2007 15:24:11 +0000,
Matthew Flint wrote:
> 
> See https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1134
> 
> 
> All,
> 
> Bug report 1134 tracks progress in getting ALSA to work with a Packard
> Bell laptop, model "EasyNote A8202". There are three simple patches
> needed against ALSA v1.0.14rc2.
> 
> Can I ask a for a kind ALSA developer to merge these patches into
> trunk, for out-of-the-box support in the next release of ALSA drivers?

Could you create a patch file and submit to this ML again?
The files there are no patches to be applied easily to the latest
tree.  And, we need a proper changelog and sign-off.

The standard rule for the patch is found in News section of ALSA
BTS.


Thanks.

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: Patches for Packard Bell EasyNote laptop support

[Takashi Iwai]

At Wed, 07 Feb 2007 17:29:32 +0100,
I wrote:
> 
> At Wed, 7 Feb 2007 15:24:11 +0000,
> Matthew Flint wrote:
> > 
> > See https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1134
> > 
> > 
> > All,
> > 
> > Bug report 1134 tracks progress in getting ALSA to work with a Packard
> > Bell laptop, model "EasyNote A8202". There are three simple patches
> > needed against ALSA v1.0.14rc2.
> > 
> > Can I ask a for a kind ALSA developer to merge these patches into
> > trunk, for out-of-the-box support in the next release of ALSA drivers?
> 
> Could you create a patch file and submit to this ML again?
> The files there are no patches to be applied easily to the latest
> tree.  And, we need a proper changelog and sign-off.
> 
> The standard rule for the patch is found in News section of ALSA
> BTS.

OK, I took a look a bit more, and wrote a patch for testing.
Could you check whether the patch below works with the latest ALSA
tree?  You can get the latest tree from
	ftp://ftp.suse.com/pub/projects/alsa/snapshot/driver/

Thanks,

Takashi

---
diff -r fd9f1cc7e78e pci/ac97/ac97_codec.c
--- a/pci/ac97/ac97_codec.c	Wed Feb 07 16:04:25 2007 +0100
+++ b/pci/ac97/ac97_codec.c	Wed Feb 07 17:57:55 2007 +0100
@@ -143,6 +143,7 @@ static const struct ac97_codec_id snd_ac
 { 0x43525970, 0xfffffff8, "CS4202",		NULL,		NULL },
 { 0x43585421, 0xffffffff, "HSD11246",		NULL,		NULL },	// SmartMC II
 { 0x43585428, 0xfffffff8, "Cx20468",		patch_conexant,	NULL }, // SmartAMC fixme: the mask might be different
+{ 0x43585431, 0xffffffff, "Cx20551",		patch_cx20551,	NULL },
 { 0x44543031, 0xfffffff0, "DT0398",		NULL,		NULL },
 { 0x454d4328, 0xffffffff, "EM28028",		NULL,		NULL },  // same as TR28028?
 { 0x45838308, 0xffffffff, "ESS1988",		NULL,		NULL },
diff -r fd9f1cc7e78e pci/ac97/ac97_patch.c
--- a/pci/ac97/ac97_patch.c	Wed Feb 07 16:04:25 2007 +0100
+++ b/pci/ac97/ac97_patch.c	Wed Feb 07 17:52:48 2007 +0100
@@ -1335,6 +1335,12 @@ int patch_conexant(struct snd_ac97 * ac9
 	ac97->flags |= AC97_CX_SPDIF;
         ac97->ext_id |= AC97_EI_SPDIF;	/* force the detection of spdif */
 	ac97->rates[AC97_RATES_SPDIF] = SNDRV_PCM_RATE_48000; /* 48k only */
+	return 0;
+}
+
+int patch_cx20551(struct snd_ac97 *ac97)
+{
+	snd_ac97_update_bits(ac97, 0x5c, 0x01, 0x01);
 	return 0;
 }
 
diff -r fd9f1cc7e78e pci/ac97/ac97_patch.h
--- a/pci/ac97/ac97_patch.h	Wed Feb 07 16:04:25 2007 +0100
+++ b/pci/ac97/ac97_patch.h	Wed Feb 07 17:51:20 2007 +0100
@@ -39,6 +39,7 @@ int patch_cirrus_cs4299(struct snd_ac97 
 int patch_cirrus_cs4299(struct snd_ac97 * ac97);
 int patch_cirrus_spdif(struct snd_ac97 * ac97);
 int patch_conexant(struct snd_ac97 * ac97);
+int patch_cx20551(struct snd_ac97 * ac97);
 int patch_ad1819(struct snd_ac97 * ac97);
 int patch_ad1881(struct snd_ac97 * ac97);
 int patch_ad1885(struct snd_ac97 * ac97);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: Patches for Packard Bell EasyNote laptop support

[Matthew Flint]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

> OK, I took a look a bit more, and wrote a patch for testing.
> Could you check whether the patch below works with the latest ALSA
> tree?  You can get the latest tree from
>         ftp://ftp.suse.com/pub/projects/alsa/snapshot/driver/

Takashi,

Thank-you for your efforts - but I didn't know which snapshot version
your patch was for.

I've created a patch which works OK against snapshot
"alsa-driver-hg20070208.tar.bz2" (see attached file). Files patched
are in directory alsa-kernel/

Matthew

[-- Attachment #2: easynote-a8208-ac97patch --]
[-- Type: application/octet-stream, Size: 1601 bytes --]

diff -Naur a/pci/ac97/ac97_codec.c b/pci/ac97/ac97_codec.c
--- a/pci/ac97/ac97_codec.c	2007-02-01 01:00:17.000000000 +0000
+++ b/pci/ac97/ac97_codec.c	2007-02-08 19:54:41.000000000 +0000
@@ -143,6 +143,7 @@
 { 0x43525970, 0xfffffff8, "CS4202",		NULL,		NULL },
 { 0x43585421, 0xffffffff, "HSD11246",		NULL,		NULL },	// SmartMC II
 { 0x43585428, 0xfffffff8, "Cx20468",		patch_conexant,	NULL }, // SmartAMC fixme: the mask might be different
+{ 0x43585431, 0xffffffff, "Cx20551",           patch_cx20551,  NULL },
 { 0x44543031, 0xfffffff0, "DT0398",		NULL,		NULL },
 { 0x454d4328, 0xffffffff, "EM28028",		NULL,		NULL },  // same as TR28028?
 { 0x45838308, 0xffffffff, "ESS1988",		NULL,		NULL },
diff -Naur a/pci/ac97/ac97_patch.c b/pci/ac97/ac97_patch.c
--- a/pci/ac97/ac97_patch.c	2007-01-30 01:00:24.000000000 +0000
+++ b/pci/ac97/ac97_patch.c	2007-02-08 19:56:03.000000000 +0000
@@ -1338,6 +1338,12 @@
 	return 0;
 }
 
+int patch_cx20551(struct snd_ac97 *ac97)
+{
+	snd_ac97_update_bits(ac97, 0x5c, 0x01, 0x01);
+	return 0;
+}
+
 /*
  * Analog Device AD18xx, AD19xx codecs
  */
diff -Naur a/pci/ac97/ac97_patch.h b/pci/ac97/ac97_patch.h
--- a/pci/ac97/ac97_patch.h	2006-12-23 01:00:20.000000000 +0000
+++ b/pci/ac97/ac97_patch.h	2007-02-08 19:56:28.000000000 +0000
@@ -39,6 +39,7 @@
 int patch_cirrus_cs4299(struct snd_ac97 * ac97);
 int patch_cirrus_spdif(struct snd_ac97 * ac97);
 int patch_conexant(struct snd_ac97 * ac97);
+int patch_cx20551(struct snd_ac97 * ac97);
 int patch_ad1819(struct snd_ac97 * ac97);
 int patch_ad1881(struct snd_ac97 * ac97);
 int patch_ad1885(struct snd_ac97 * ac97);

[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: Patches for Packard Bell EasyNote laptop support

[Andrea Gozzi]

[-- Attachment #1.1: Type: text/plain, Size: 1259 bytes --]

Hi.
What does exactly this patch fix?
Since I bought my EasyNote V7900 I had audio troubles (no sound) and I
was wondering if your work could help me someway.
Thanks,

Andrea

On Wed, 2007-02-07 at 15:24 +0000, Matthew Flint wrote:
> See https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1134
> 
> 
> All,
> 
> Bug report 1134 tracks progress in getting ALSA to work with a Packard
> Bell laptop, model "EasyNote A8202". There are three simple patches
> needed against ALSA v1.0.14rc2.
> 
> Can I ask a for a kind ALSA developer to merge these patches into
> trunk, for out-of-the-box support in the next release of ALSA drivers?
> 
> Thanks in advance,
> Matthew
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: Patches for Packard Bell EasyNote laptop support

[Takashi Iwai]

At Thu, 8 Feb 2007 20:13:16 +0000,
Matthew Flint wrote:
> 
> > OK, I took a look a bit more, and wrote a patch for testing.
> > Could you check whether the patch below works with the latest ALSA
> > tree?  You can get the latest tree from
> >         ftp://ftp.suse.com/pub/projects/alsa/snapshot/driver/
> 
> Takashi,
> 
> Thank-you for your efforts - but I didn't know which snapshot version
> your patch was for.

Doesn't matter - if should work with all recent versions.

> 
> I've created a patch which works OK against snapshot
> "alsa-driver-hg20070208.tar.bz2" (see attached file). Files patched
> are in directory alsa-kernel/

OK, then I'll commit it to HG tree now.

Thanks!


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: Patches for Packard Bell EasyNote laptop support

[Takashi Iwai]

At Thu, 08 Feb 2007 22:15:04 +0100,
Andrea Gozzi wrote:
> 
> Hi.
> What does exactly this patch fix?
> Since I bought my EasyNote V7900 I had audio troubles (no sound) and I
> was wondering if your work could help me someway.

If it's a PB laptop with ac97 codec, you may have a good chance.

If it's a HD-audio codec chip, it's a completely different thing (but
likely with a Conexant HDA codec chip).  It might be fixed by the
recent HG version, though.


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: Patches for Packard Bell EasyNote laptop support

[Andrea Gozzi]

[-- Attachment #1.1: Type: text/plain, Size: 628 bytes --]

Thanks, I'll see what I can get form the HG.

Andrea

On Fri, 2007-02-09 at 12:44 +0100, Takashi Iwai wrote:
> At Thu, 08 Feb 2007 22:15:04 +0100,
> Andrea Gozzi wrote:
> > 
> > Hi.
> > What does exactly this patch fix?
> > Since I bought my EasyNote V7900 I had audio troubles (no sound) and I
> > was wondering if your work could help me someway.
> 
> If it's a PB laptop with ac97 codec, you may have a good chance.
> 
> If it's a HD-audio codec chip, it's a completely different thing (but
> likely with a Conexant HDA codec chip).  It might be fixed by the
> recent HG version, though.
> 
> 
> Takashi

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel