* [PATCH] [ALSA] seq: add error check in snd_seq_system_client_init()
@ 2018-08-28 8:46 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-08-28 8:46 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel, kernel-janitors, Takashi Iwai
Static checkers complain that snd_seq_create_kernel_client() can return
-EBUSY here so we need to have some error handling.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/core/seq/seq_system.c b/sound/core/seq/seq_system.c
index 8ce1d0b40dce..3b89b0adad6a 100644
--- a/sound/core/seq/seq_system.c
+++ b/sound/core/seq/seq_system.c
@@ -134,6 +134,10 @@ int __init snd_seq_system_client_init(void)
/* register client */
sysclient = snd_seq_create_kernel_client(NULL, 0, "System");
+ if (sysclient < 0) {
+ kfree(port);
+ return sysclient;
+ }
/* register timer */
strcpy(port->name, "Timer");
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] [ALSA] seq: add error check in snd_seq_system_client_init()
@ 2018-08-28 8:46 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-08-28 8:46 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel, kernel-janitors, Takashi Iwai
Static checkers complain that snd_seq_create_kernel_client() can return
-EBUSY here so we need to have some error handling.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/core/seq/seq_system.c b/sound/core/seq/seq_system.c
index 8ce1d0b40dce..3b89b0adad6a 100644
--- a/sound/core/seq/seq_system.c
+++ b/sound/core/seq/seq_system.c
@@ -134,6 +134,10 @@ int __init snd_seq_system_client_init(void)
/* register client */
sysclient = snd_seq_create_kernel_client(NULL, 0, "System");
+ if (sysclient < 0) {
+ kfree(port);
+ return sysclient;
+ }
/* register timer */
strcpy(port->name, "Timer");
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [ALSA] seq: add error check in snd_seq_system_client_init()
2018-08-28 8:46 ` Dan Carpenter
@ 2018-08-28 9:09 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-08-28 9:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: alsa-devel, kernel-janitors
On Tue, 28 Aug 2018 10:46:34 +0200,
Dan Carpenter wrote:
>
> Static checkers complain that snd_seq_create_kernel_client() can return
> -EBUSY here so we need to have some error handling.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Also we need to fix the case where an error is returned from
snd_seq_kernel_client_ctl(). Will write up the patch soon later.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [ALSA] seq: add error check in snd_seq_system_client_init()
@ 2018-08-28 9:09 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-08-28 9:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: alsa-devel, kernel-janitors
On Tue, 28 Aug 2018 10:46:34 +0200,
Dan Carpenter wrote:
>
> Static checkers complain that snd_seq_create_kernel_client() can return
> -EBUSY here so we need to have some error handling.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Also we need to fix the case where an error is returned from
snd_seq_kernel_client_ctl(). Will write up the patch soon later.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-28 9:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 8:46 [PATCH] [ALSA] seq: add error check in snd_seq_system_client_init() Dan Carpenter
2018-08-28 8:46 ` Dan Carpenter
2018-08-28 9:09 ` Takashi Iwai
2018-08-28 9:09 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.