From: Takashi Iwai <tiwai@suse.de>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: rauchwolke@gmx.net,
"david.henningsson@canonical.com"
<david.henningsson@canonical.com>,
"ibm-acpi-devel@lists.sourceforge.net"
<ibm-acpi-devel@lists.sourceforge.net>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"ibm-acpi@hmh.eng.br" <ibm-acpi@hmh.eng.br>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume
Date: Thu, 13 Feb 2014 09:35:30 +0100 [thread overview]
Message-ID: <s5h7g8zfm0d.wl%tiwai@suse.de> (raw)
In-Reply-To: <1392237456.1201.2.camel@x230>
At Wed, 12 Feb 2014 20:37:36 +0000,
Matthew Garrett wrote:
>
> On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote:
> > The mute LED states have to be restored after resume.
>
> Oh, never mind, we're not doing this through the LED class, are we?
Good point. It seems that leds_class has pm_ops but it's enabled only
when a flag is set.
I added the original bug reporter to Cc. (Don't know the name,
Bugzilla shows only the email address.)
Could you check the patch below works instead of the previous fix?
Takashi
---
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index defb6afc1409..16edf75d9c00 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -4796,6 +4796,7 @@ static struct tpacpi_led_classdev tpacpi_led_thinklight = {
.name = "tpacpi::thinklight",
.brightness_set = &light_sysfs_set,
.brightness_get = &light_sysfs_get,
+ .flags = LED_CORE_SUSPENDRESUME,
}
};
next prev parent reply other threads:[~2014-02-13 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 15:32 [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume Takashi Iwai
2014-02-12 19:21 ` Henrique de Moraes Holschuh
2014-02-12 20:36 ` Matthew Garrett
2014-02-12 20:36 ` Matthew Garrett
2014-02-12 20:37 ` Matthew Garrett
2014-02-12 20:37 ` Matthew Garrett
2014-02-13 8:35 ` Takashi Iwai [this message]
2014-02-13 8:35 ` Takashi Iwai
2014-02-13 18:02 ` rauchwolke
2014-02-13 18:02 ` rauchwolke
2014-02-14 6:37 ` Takashi Iwai
2014-02-14 6:37 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7g8zfm0d.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=david.henningsson@canonical.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rauchwolke@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.