All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Roman Sommer" <roman.sommer@fau.de>
Cc: alsa-devel@alsa-project.org, "Kees Cook" <keescook@chromium.org>,
	"Daniel Graefe" <daniel.graefe@fau.de>,
	"Bhumika Goyal" <bhumirks@gmail.com>,
	"\"Fabián Inostroza\"" <soulsonceonfire@gmail.com>,
	linux-kernel@i4.cs.fau.de, "Thomas Gleixner" <tglx@linutronix.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Kate Stewart" <kstewart@linuxfoundation.org>,
	"Philippe Ombredanne" <pombredanne@nexb.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	"\"Hans P. Möller Ebner\"" <hmoller@uc.cl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] sound/usb/line6: fix some styling issues
Date: Mon, 18 Jun 2018 12:39:53 +0200	[thread overview]
Message-ID: <s5h8t7cz8cm.wl-tiwai@suse.de> (raw)
In-Reply-To: <1529317779-15908-1-git-send-email-roman.sommer@fau.de>

On Mon, 18 Jun 2018 12:29:36 +0200,
Roman Sommer wrote:
> 
> CC: Jaroslav Kysela <perex@perex.cz>
> CC: Takashi Iwai <tiwai@suse.com>
> CC: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> CC: "Hans P. Möller Ebner" <hmoller@uc.cl>
> CC: Kees Cook <keescook@chromium.org>
> CC: Kate Stewart <kstewart@linuxfoundation.org>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: "Fabián Inostroza" <soulsonceonfire@gmail.com>
> CC: Bhumika Goyal <bhumirks@gmail.com>
> CC: Philippe Ombredanne <pombredanne@nexb.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: alsa-devel@alsa-project.org
> CC: linux-kernel@vger.kernel.org
> 
> 
> This patchseries addresses some styling issues in sound/usb/line6 found by
> checkpatch.

Are you working further on this driver to fix any real bugs (or
implements something new), or it's an action "just because checkpatch
tells"?  I'd take such cleanup patches only for the former case.


thanks,

Takashi


> 
> Roman Sommer (3):
>   sound/line6: checkpatch: fix block comment style
>   sound/line6: unsigned -> unsigned int
>   sound/line6: add newline after declarations
> 
>  sound/usb/line6/capture.c  |  20 ++++-----
>  sound/usb/line6/driver.c   | 110 ++++++++++++++++++++++-----------------------
>  sound/usb/line6/driver.h   |  33 +++++++-------
>  sound/usb/line6/midi.c     |  24 +++++-----
>  sound/usb/line6/midibuf.c  |   6 +--
>  sound/usb/line6/pcm.c      |  26 +++++------
>  sound/usb/line6/pcm.h      |  74 +++++++++++++++---------------
>  sound/usb/line6/playback.c |  36 ++++++++-------
>  sound/usb/line6/pod.c      |  60 ++++++++++++-------------
>  sound/usb/line6/podhd.c    |   8 ++--
>  sound/usb/line6/toneport.c |  30 ++++++-------
>  sound/usb/line6/variax.c   |  40 ++++++++---------
>  12 files changed, 235 insertions(+), 232 deletions(-)
> 
> -- 
> 2.7.4
> 
> 

  parent reply	other threads:[~2018-06-18 10:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 10:29 [PATCH 0/3] sound/usb/line6: fix some styling issues Roman Sommer
2018-06-18 10:29 ` Roman Sommer
2018-06-18 10:29 ` [PATCH 1/3] sound/line6: checkpatch: fix block comment style Roman Sommer
2018-06-18 10:29   ` Roman Sommer
2018-06-18 11:21   ` Greg Kroah-Hartman
2018-06-18 11:21     ` Greg Kroah-Hartman
2018-06-18 11:56     ` Sommer, Roman
2018-06-18 10:29 ` [PATCH 2/3] sound/line6: unsigned -> unsigned int Roman Sommer
2018-06-18 10:29   ` Roman Sommer
2018-06-18 10:29 ` [PATCH 3/3] sound/line6: add newline after declarations Roman Sommer
2018-06-18 10:29   ` Roman Sommer
2018-06-18 10:39 ` Takashi Iwai [this message]
2018-06-18 11:57   ` [PATCH 0/3] sound/usb/line6: fix some styling issues Sommer, Roman
2018-06-18 12:04     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8t7cz8cm.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=bhumirks@gmail.com \
    --cc=daniel.graefe@fau.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hmoller@uc.cl \
    --cc=keescook@chromium.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=pombredanne@nexb.com \
    --cc=roman.sommer@fau.de \
    --cc=soulsonceonfire@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.