All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pcm/kernel: Add DSD formats silence patterns
@ 2014-08-24  8:04 Jurgen Kramer
  2014-08-25  7:23 ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Jurgen Kramer @ 2014-08-24  8:04 UTC (permalink / raw)
  To: alsa-devel; +Cc: Jurgen Kramer

This patch adds the silence patterns for the DSD sample formats, kernel side.

Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
---
 sound/core/pcm_misc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/core/pcm_misc.c b/sound/core/pcm_misc.c
index 4560ca0..2c6fd80 100644
--- a/sound/core/pcm_misc.c
+++ b/sound/core/pcm_misc.c
@@ -142,11 +142,11 @@ static struct pcm_format_data pcm_formats[(INT)SNDRV_PCM_FORMAT_LAST+1] = {
 	},
 	[SNDRV_PCM_FORMAT_DSD_U8] = {
 		.width = 8, .phys = 8, .le = 1, .signd = 0,
-		.silence = {},
+		.silence = { 0x69 },
 	},
 	[SNDRV_PCM_FORMAT_DSD_U16_LE] = {
 		.width = 16, .phys = 16, .le = 1, .signd = 0,
-		.silence = {},
+		.silence = { 0x69, 0x69 },
 	},
 	/* FIXME: the following three formats are not defined properly yet */
 	[SNDRV_PCM_FORMAT_MPEG] = {
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] pcm/kernel: Add DSD formats silence patterns
  2014-08-24  8:04 [PATCH] pcm/kernel: Add DSD formats silence patterns Jurgen Kramer
@ 2014-08-25  7:23 ` Takashi Iwai
  2014-08-25  8:18   ` Jurgen Kramer
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2014-08-25  7:23 UTC (permalink / raw)
  To: Jurgen Kramer; +Cc: alsa-devel

At Sun, 24 Aug 2014 10:04:08 +0200,
Jurgen Kramer wrote:
> 
> This patch adds the silence patterns for the DSD sample formats, kernel side.
> 
> Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>

A similar patch has been already submitted and merged :)


thanks,

Takashi

> ---
>  sound/core/pcm_misc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/pcm_misc.c b/sound/core/pcm_misc.c
> index 4560ca0..2c6fd80 100644
> --- a/sound/core/pcm_misc.c
> +++ b/sound/core/pcm_misc.c
> @@ -142,11 +142,11 @@ static struct pcm_format_data pcm_formats[(INT)SNDRV_PCM_FORMAT_LAST+1] = {
>  	},
>  	[SNDRV_PCM_FORMAT_DSD_U8] = {
>  		.width = 8, .phys = 8, .le = 1, .signd = 0,
> -		.silence = {},
> +		.silence = { 0x69 },
>  	},
>  	[SNDRV_PCM_FORMAT_DSD_U16_LE] = {
>  		.width = 16, .phys = 16, .le = 1, .signd = 0,
> -		.silence = {},
> +		.silence = { 0x69, 0x69 },
>  	},
>  	/* FIXME: the following three formats are not defined properly yet */
>  	[SNDRV_PCM_FORMAT_MPEG] = {
> -- 
> 1.9.3
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] pcm/kernel: Add DSD formats silence patterns
  2014-08-25  7:23 ` Takashi Iwai
@ 2014-08-25  8:18   ` Jurgen Kramer
  2014-08-25  8:20     ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Jurgen Kramer @ 2014-08-25  8:18 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel

On Mon, 2014-08-25 at 09:23 +0200, Takashi Iwai wrote:
> At Sun, 24 Aug 2014 10:04:08 +0200,
> Jurgen Kramer wrote:
> > 
> > This patch adds the silence patterns for the DSD sample formats, kernel side.
> > 
> > Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
> 
> A similar patch has been already submitted and merged :)
> 
OK thanks, must have missed it.

BTW I could not find it in your git repo or current kernel git, where is
is hiding? :-)

Jurgen

> thanks,
> 
> Takashi
> 
> > ---
> >  sound/core/pcm_misc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/sound/core/pcm_misc.c b/sound/core/pcm_misc.c
> > index 4560ca0..2c6fd80 100644
> > --- a/sound/core/pcm_misc.c
> > +++ b/sound/core/pcm_misc.c
> > @@ -142,11 +142,11 @@ static struct pcm_format_data pcm_formats[(INT)SNDRV_PCM_FORMAT_LAST+1] = {
> >  	},
> >  	[SNDRV_PCM_FORMAT_DSD_U8] = {
> >  		.width = 8, .phys = 8, .le = 1, .signd = 0,
> > -		.silence = {},
> > +		.silence = { 0x69 },
> >  	},
> >  	[SNDRV_PCM_FORMAT_DSD_U16_LE] = {
> >  		.width = 16, .phys = 16, .le = 1, .signd = 0,
> > -		.silence = {},
> > +		.silence = { 0x69, 0x69 },
> >  	},
> >  	/* FIXME: the following three formats are not defined properly yet */
> >  	[SNDRV_PCM_FORMAT_MPEG] = {
> > -- 
> > 1.9.3
> > 
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> > 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] pcm/kernel: Add DSD formats silence patterns
  2014-08-25  8:18   ` Jurgen Kramer
@ 2014-08-25  8:20     ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2014-08-25  8:20 UTC (permalink / raw)
  To: Jurgen Kramer; +Cc: alsa-devel

At Mon, 25 Aug 2014 10:18:10 +0200,
Jurgen Kramer wrote:
> 
> On Mon, 2014-08-25 at 09:23 +0200, Takashi Iwai wrote:
> > At Sun, 24 Aug 2014 10:04:08 +0200,
> > Jurgen Kramer wrote:
> > > 
> > > This patch adds the silence patterns for the DSD sample formats, kernel side.
> > > 
> > > Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
> > 
> > A similar patch has been already submitted and merged :)
> > 
> OK thanks, must have missed it.
> 
> BTW I could not find it in your git repo or current kernel git, where is
> is hiding? :-)

The git commit wasn't published until today, as I've watched any
review reaction.  Now it's there.


Takashi

> 
> Jurgen
> 
> > thanks,
> > 
> > Takashi
> > 
> > > ---
> > >  sound/core/pcm_misc.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/sound/core/pcm_misc.c b/sound/core/pcm_misc.c
> > > index 4560ca0..2c6fd80 100644
> > > --- a/sound/core/pcm_misc.c
> > > +++ b/sound/core/pcm_misc.c
> > > @@ -142,11 +142,11 @@ static struct pcm_format_data pcm_formats[(INT)SNDRV_PCM_FORMAT_LAST+1] = {
> > >  	},
> > >  	[SNDRV_PCM_FORMAT_DSD_U8] = {
> > >  		.width = 8, .phys = 8, .le = 1, .signd = 0,
> > > -		.silence = {},
> > > +		.silence = { 0x69 },
> > >  	},
> > >  	[SNDRV_PCM_FORMAT_DSD_U16_LE] = {
> > >  		.width = 16, .phys = 16, .le = 1, .signd = 0,
> > > -		.silence = {},
> > > +		.silence = { 0x69, 0x69 },
> > >  	},
> > >  	/* FIXME: the following three formats are not defined properly yet */
> > >  	[SNDRV_PCM_FORMAT_MPEG] = {
> > > -- 
> > > 1.9.3
> > > 
> > > _______________________________________________
> > > Alsa-devel mailing list
> > > Alsa-devel@alsa-project.org
> > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> > > 
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> > 
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-25  8:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-24  8:04 [PATCH] pcm/kernel: Add DSD formats silence patterns Jurgen Kramer
2014-08-25  7:23 ` Takashi Iwai
2014-08-25  8:18   ` Jurgen Kramer
2014-08-25  8:20     ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.