All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Baole Fang <fbl718@163.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jeremy Szu <jeremy.szu@canonical.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Werner Sembach <wse@tuxedocomputers.com>,
	Hui Wang <hui.wang@canonical.com>,
	Cameron Berkenpas <cam@neo-zeon.de>,
	Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
	Elia Devito <eliadevito@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Legion Y9000X 2020
Date: Wed, 05 Jan 2022 09:26:16 +0100	[thread overview]
Message-ID: <s5ha6gak2qf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220105034103.12484-1-fbl718@163.com>

On Wed, 05 Jan 2022 04:41:01 +0100,
Baole Fang wrote:
> 
> commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream.

I couldn't find this commit.  Is this a bogus information?

> Legion Y9000X 2020 has a speaker, but the speaker doesn't work.
> This can be fixed by applying alc285_fixup_ideapad_s740_coef
>  to fix the speaker's coefficients.
> Besides, to support the transition between the speaker and the headphone,
> alc287_fixup_legion_15imhg05_speakers needs to be run.
> 
> Signed-off-by: Baole Fang <fbl718@163.com>

The code change itself looks fine, so I'd apply it if the line above
can be omitted.


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Baole Fang <fbl718@163.com>
Cc: alsa-devel@alsa-project.org, Kailang Yang <kailang@realtek.com>,
	Jeremy Szu <jeremy.szu@canonical.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Elia Devito <eliadevito@gmail.com>, Takashi Iwai <tiwai@suse.com>,
	Werner Sembach <wse@tuxedocomputers.com>,
	Hui Wang <hui.wang@canonical.com>, Sami Loone <sami@loone.fi>,
	Cameron Berkenpas <cam@neo-zeon.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Legion Y9000X 2020
Date: Wed, 05 Jan 2022 09:26:16 +0100	[thread overview]
Message-ID: <s5ha6gak2qf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220105034103.12484-1-fbl718@163.com>

On Wed, 05 Jan 2022 04:41:01 +0100,
Baole Fang wrote:
> 
> commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream.

I couldn't find this commit.  Is this a bogus information?

> Legion Y9000X 2020 has a speaker, but the speaker doesn't work.
> This can be fixed by applying alc285_fixup_ideapad_s740_coef
>  to fix the speaker's coefficients.
> Besides, to support the transition between the speaker and the headphone,
> alc287_fixup_legion_15imhg05_speakers needs to be run.
> 
> Signed-off-by: Baole Fang <fbl718@163.com>

The code change itself looks fine, so I'd apply it if the line above
can be omitted.


thanks,

Takashi

  reply	other threads:[~2022-01-05  8:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05  3:41 [PATCH] ALSA: hda/realtek: Add quirk for Legion Y9000X 2020 Baole Fang
2022-01-05  8:26 ` Takashi Iwai [this message]
2022-01-05  8:26   ` Takashi Iwai
2022-01-05 10:55   ` Greg Kroah-Hartman
2022-01-05 10:55     ` Greg Kroah-Hartman
2022-01-05 11:39     ` Baole Fang
2022-01-05 11:39       ` Baole Fang
2022-01-05 11:44       ` Greg Kroah-Hartman
2022-01-05 11:44         ` Greg Kroah-Hartman
2022-01-05 12:29         ` Baole Fang
2022-01-05 12:29           ` Baole Fang
2022-01-05 12:33           ` Greg Kroah-Hartman
2022-01-05 12:33             ` Greg Kroah-Hartman
2022-01-05 12:53             ` Baole Fang
2022-01-05 12:53               ` Baole Fang
2022-01-05 14:08 Baole Fang
2022-01-05 15:43 ` Takashi Iwai
2022-01-05 15:43   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha6gak2qf.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=cam@neo-zeon.de \
    --cc=eliadevito@gmail.com \
    --cc=fbl718@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hui.wang@canonical.com \
    --cc=jeremy.szu@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sami@loone.fi \
    --cc=tiwai@suse.com \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.