* [PATCH] ALSA: usb: don't print error when allocating urb fails @ 2016-08-11 20:40 Wolfram Sang [not found] ` <1470948012-22897-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2016-08-11 20:40 UTC (permalink / raw) To: linux-usb-u79uwXL29TY76Z2rM5mHXA Cc: Wolfram Sang, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approach when we talked about it at LCJ in Tokyo a few weeks ago. Wolfram Sang (1): ALSA: usb: caiaq: audio: don't print error when allocating urb fails sound/usb/caiaq/audio.c | 1 - 1 file changed, 1 deletion(-) -- 2.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <1470948012-22897-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>]
* [PATCH] ALSA: usb: caiaq: audio: don't print error when allocating urb fails [not found] ` <1470948012-22897-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> @ 2016-08-11 20:40 ` Wolfram Sang [not found] ` <1470948012-22897-2-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2016-08-11 20:40 UTC (permalink / raw) To: linux-usb-u79uwXL29TY76Z2rM5mHXA Cc: Wolfram Sang, Daniel Mack, Jaroslav Kysela, Takashi Iwai, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> --- sound/usb/caiaq/audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c index 327f8642ca80e6..8f66ba730d69d9 100644 --- a/sound/usb/caiaq/audio.c +++ b/sound/usb/caiaq/audio.c @@ -739,7 +739,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) for (i = 0; i < N_URBS; i++) { urbs[i] = usb_alloc_urb(FRAMES_PER_URB, GFP_KERNEL); if (!urbs[i]) { - dev_err(dev, "unable to usb_alloc_urb(), OOM!?\n"); *ret = -ENOMEM; return urbs; } -- 2.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1470948012-22897-2-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>]
* Re: [PATCH] ALSA: usb: caiaq: audio: don't print error when allocating urb fails [not found] ` <1470948012-22897-2-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> @ 2016-08-11 21:06 ` Takashi Iwai 0 siblings, 0 replies; 3+ messages in thread From: Takashi Iwai @ 2016-08-11 21:06 UTC (permalink / raw) To: Wolfram Sang Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw, Daniel Mack, Jaroslav Kysela On Thu, 11 Aug 2016 22:40:11 +0200, Wolfram Sang wrote: > > kmalloc will print enough information in case of failure. > > Signed-off-by: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> Applied, thanks. Takashi > --- > sound/usb/caiaq/audio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c > index 327f8642ca80e6..8f66ba730d69d9 100644 > --- a/sound/usb/caiaq/audio.c > +++ b/sound/usb/caiaq/audio.c > @@ -739,7 +739,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) > for (i = 0; i < N_URBS; i++) { > urbs[i] = usb_alloc_urb(FRAMES_PER_URB, GFP_KERNEL); > if (!urbs[i]) { > - dev_err(dev, "unable to usb_alloc_urb(), OOM!?\n"); > *ret = -ENOMEM; > return urbs; > } > -- > 2.8.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-11 21:06 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-08-11 20:40 [PATCH] ALSA: usb: don't print error when allocating urb fails Wolfram Sang [not found] ` <1470948012-22897-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> 2016-08-11 20:40 ` [PATCH] ALSA: usb: caiaq: audio: " Wolfram Sang [not found] ` <1470948012-22897-2-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> 2016-08-11 21:06 ` Takashi Iwai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.