All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: "Agrawal, Akshu" <Akshu.Agrawal@amd.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
	MANAGEM..."  <alsa-devel@alsa-project.org>,
	Alexander.Deucher@amd.com, djkurtz@chromium.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-pcm: Use delay set in pointer function
Date: Tue, 31 Jul 2018 15:56:52 +0200	[thread overview]
Message-ID: <s5hd0v3pkyj.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180731135115.GD5719@sirena.org.uk>

On Tue, 31 Jul 2018 15:51:15 +0200,
Mark Brown wrote:
> 
> On Tue, Jul 31, 2018 at 03:29:35PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > > > However since it's not supposed to be providing any DMA a CPU DAI really
> > > > > shouldn't be doing this...
> 
> > > > Well, if so, the CPU dai also cannot get the exact base delay
> > > > corresponding to the reported position, either, no?
> 
> > > It can know how much delay it's adding internally between its input and
> > > output, which feeds into the overall delay experienced by the user.
> 
> > But isn't it merely the additional delay that should be applied on top
> > of the existing runtime->delay?
> 
> Yes.  I'm saying that if the CPU DAI thinks it can figure out the base
> delay something is confused.

Then basically Akshu's patch does the correct thing, I suppose.


Takashi

  reply	other threads:[~2018-07-31 13:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 10:13 [PATCH] ASoC: soc-pcm: Use delay set in pointer function Akshu Agrawal
2018-07-27 10:13 ` Akshu Agrawal
2018-07-27 15:09 ` [alsa-devel] " Pierre-Louis Bossart
2018-07-27 15:09   ` Pierre-Louis Bossart
2018-07-28  4:28   ` Agrawal, Akshu
2018-07-28  4:28     ` Agrawal, Akshu
2018-07-30 15:15     ` [alsa-devel] " Pierre-Louis Bossart
2018-07-30 15:15       ` Pierre-Louis Bossart
2018-07-30 15:32       ` Takashi Iwai
2018-07-30 15:32         ` Takashi Iwai
2018-07-30 15:50         ` Mark Brown
2018-07-30 15:50           ` Mark Brown
2018-07-31  1:25           ` [alsa-devel] " Agrawal, Akshu
2018-07-31  1:25             ` Agrawal, Akshu
2018-07-31  5:30             ` [alsa-devel] " Takashi Iwai
2018-07-31  5:30               ` Takashi Iwai
2018-07-31  9:06               ` Agrawal, Akshu
2018-07-31  9:06                 ` Agrawal, Akshu
2018-07-31  9:25                 ` [alsa-devel] " Takashi Iwai
2018-07-31  9:25                   ` Takashi Iwai
2018-07-31 10:19                   ` Mark Brown
2018-07-31 10:19                     ` Mark Brown
2018-07-31 10:32                     ` [alsa-devel] " Takashi Iwai
2018-07-31 10:32                       ` Takashi Iwai
2018-07-31 13:12                       ` Mark Brown
2018-07-31 13:12                         ` Mark Brown
2018-07-31 13:29                         ` [alsa-devel] " Takashi Iwai
2018-07-31 13:29                           ` Takashi Iwai
2018-07-31 13:51                           ` Mark Brown
2018-07-31 13:51                             ` Mark Brown
2018-07-31 13:56                             ` Takashi Iwai [this message]
2018-07-31 13:56                               ` [alsa-devel] " Takashi Iwai
2018-07-31 14:40                               ` Mark Brown
2018-07-31 14:40                                 ` Mark Brown
2018-08-01  4:01                                 ` [alsa-devel] " Agrawal, Akshu
2018-08-01  4:01                                   ` Agrawal, Akshu
2018-07-31 10:03               ` [alsa-devel] " Mark Brown
2018-07-31 10:03                 ` Mark Brown
2018-07-30 10:54 ` Mark Brown
2018-07-30 10:54   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd0v3pkyj.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Akshu.Agrawal@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.