* Re: ALC298 headset mode support [not found] <6FAB7C47BCF00940BB0999A99BE3547A17A10470@RTITMBSV09.realtek.com.tw> @ 2015-05-11 12:34 ` Takashi Iwai [not found] ` <6FAB7C47BCF00940BB0999A99BE3547A17A105CC@RTITMBSV09.realtek.com.tw> 0 siblings, 1 reply; 2+ messages in thread From: Takashi Iwai @ 2015-05-11 12:34 UTC (permalink / raw) To: Kailang; +Cc: (alsa-devel@alsa-project.org) At Mon, 11 May 2015 08:30:28 +0000, Kailang wrote: > > Hi Takashi, > > I finished the alc298 headset mode supported. > But it only tested via our develop system. .... > @@ -3801,6 +3804,8 @@ static void alc_headset_mode_ctia(struct hda_codec *codec) > case 0x10ec0283: > alc_process_coef_fw(codec, coef0233); > break; > + case 0x10ec0298: > + alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020); > case 0x10ec0286: I suppose you didn't forget break in the above, right? If so, add a comment like /* fallthrough */ to indicate that it's the intentional code. Ditto for other similar lines. thanks, Takashi ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <6FAB7C47BCF00940BB0999A99BE3547A17A105CC@RTITMBSV09.realtek.com.tw>]
* Re: ALC298 headset mode support [not found] ` <6FAB7C47BCF00940BB0999A99BE3547A17A105CC@RTITMBSV09.realtek.com.tw> @ 2015-05-12 11:16 ` Takashi Iwai 0 siblings, 0 replies; 2+ messages in thread From: Takashi Iwai @ 2015-05-12 11:16 UTC (permalink / raw) To: Kailang; +Cc: (alsa-devel@alsa-project.org) At Tue, 12 May 2015 09:19:56 +0000, Kailang wrote: > > Hi Takashi, > > New patch attached. > ALC298 hidden register was very similar to ALC286/ALC288. > Many Thanks. ^^ > > BR, > Kailang OK, applied now. thanks, Takashi > > > -----Original Message----- > > From: Takashi Iwai [mailto:tiwai@suse.de] > > Sent: Monday, May 11, 2015 8:35 PM > > To: Kailang > > Cc: (alsa-devel@alsa-project.org) > > Subject: Re: ALC298 headset mode support > > > > At Mon, 11 May 2015 08:30:28 +0000, > > Kailang wrote: > > > > > > Hi Takashi, > > > > > > I finished the alc298 headset mode supported. > > > But it only tested via our develop system. > > .... > > > @@ -3801,6 +3804,8 @@ static void > > alc_headset_mode_ctia(struct hda_codec *codec) > > > case 0x10ec0283: > > > alc_process_coef_fw(codec, coef0233); > > > break; > > > + case 0x10ec0298: > > > + alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020); > > > case 0x10ec0286: > > > > I suppose you didn't forget break in the above, right? > Yes. > > > If so, add a comment like /* fallthrough */ to indicate that > > it's the intentional code. Ditto for other similar lines. > > > > > > thanks, > > > > Takashi > > > > ------Please consider the environment before printing this e-mail. > > > [2 0001-alc298-headset-mode.patch <application/octet-stream (base64)>] > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-12 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <6FAB7C47BCF00940BB0999A99BE3547A17A10470@RTITMBSV09.realtek.com.tw>
2015-05-11 12:34 ` ALC298 headset mode support Takashi Iwai
[not found] ` <6FAB7C47BCF00940BB0999A99BE3547A17A105CC@RTITMBSV09.realtek.com.tw>
2015-05-12 11:16 ` Takashi Iwai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.