* Linux-Kernel: System freezes after hibernate or suspend on a Mac mini 6, 2
@ 2018-04-23 6:53 Johannes Geiss
2018-04-23 13:42 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Geiss @ 2018-04-23 6:53 UTC (permalink / raw)
To: alsa-devel
Hello ALSA-Development,
I bisected a problem in the Linux kernel 4.14. (This may also concern
newer kernel versions.)
Using a Mac mini 6,2 computer the kernel freezes after a resume from
hibernation or suspend.
The bisection resulted, that the patch
1f7f51a63114bab3a05920f4b1343154e95e2cb6 may be the culprit.
Please have a look at the description and comments of the bug
https://bugzilla.kernel.org/show_bug.cgi?id=198233 and tell me if our
assumption is correct or not.
Thank you very much for your cooperation.
Johannes Geiss
--
------//--------------------------------------------------------------
// Johannes R. Geiss Mac mini server and
\\ // OpenPandora user
--\X/-----------------------------------------------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linux-Kernel: System freezes after hibernate or suspend on a Mac mini 6, 2
2018-04-23 6:53 Linux-Kernel: System freezes after hibernate or suspend on a Mac mini 6, 2 Johannes Geiss
@ 2018-04-23 13:42 ` Takashi Iwai
2018-04-23 18:40 ` Johannes Geiss
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2018-04-23 13:42 UTC (permalink / raw)
To: Johannes Geiss; +Cc: alsa-devel
On Mon, 23 Apr 2018 08:53:41 +0200,
Johannes Geiss wrote:
>
> Hello ALSA-Development,
>
> I bisected a problem in the Linux kernel 4.14. (This may also concern
> newer kernel versions.)
>
> Using a Mac mini 6,2 computer the kernel freezes after a resume from
> hibernation or suspend.
>
> The bisection resulted, that the patch
> 1f7f51a63114bab3a05920f4b1343154e95e2cb6 may be the culprit.
>
> Please have a look at the description and comments of the bug
> https://bugzilla.kernel.org/show_bug.cgi?id=198233 and tell me if our
> assumption is correct or not.
Did you get the error message "Too many HDMI devices" as mentioned in
the changelog?
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linux-Kernel: System freezes after hibernate or suspend on a Mac mini 6, 2
2018-04-23 13:42 ` Takashi Iwai
@ 2018-04-23 18:40 ` Johannes Geiss
2018-04-23 19:26 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Geiss @ 2018-04-23 18:40 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 1572 bytes --]
On Mon, 23 Apr 2018 15:42:33 +0200
Takashi Iwai <tiwai@suse.de> wrote:
> Did you get the error message "Too many HDMI devices" as mentioned in
> the changelog?
Yes:
Mar 14 11:29:48 mizar kernel: snd_hda_intel 0000:00:1b.0: Too many HDMI
devices Mar 14 11:29:48 mizar kernel: snd_hda_intel 0000:00:1b.0:
Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y Mar 14
11:29:48 mizar kernel: input: HDA Intel PCH Line
as /devices/pci0000:00/0000:00:1b.0/sound/card0/input3 Mar 14 11:29:48
mizar kernel: input: HDA Intel PCH Headphone
as /devices/pci0000:00/0000:00:1b.0/sound/card0/input4 Mar 14 11:29:48
mizar kernel: input: HDA Intel PCH SPDIF In
as /devices/pci0000:00/0000:00:1b.0/sound/card0/input5 Mar 14 11:29:48
mizar kernel: input: HDA Intel PCH HDMI/DP,pcm=3
as /devices/pci0000:00/0000:00:1b.0/sound/card0/input7 Mar 14 11:29:48
mizar kernel: input: HDA Intel PCH HDMI/DP,pcm=7
as /devices/pci0000:00/0000:00:1b.0/sound/card0/input8 Mar 14 11:29:48
mizar kernel: input: HDA Intel PCH HDMI/DP
as /devices/pci0000:00/0000:00:1b.0/sound/card0/input9 Mar 14 11:29:48
mizar systemd[1]: Reached target Sound Card.
Does this mean I should try to use CONFIG_SND_DYNAMIC_MINORS=y to solve
the hibernate/suspend problem?
Bye
Johannes
--
------//--------------------------------------------------------------
// Johannes R. Geiss Mac mini server and
\\ // OpenPandora user
--\X/-----------------------------------------------------------------
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linux-Kernel: System freezes after hibernate or suspend on a Mac mini 6, 2
2018-04-23 18:40 ` Johannes Geiss
@ 2018-04-23 19:26 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-04-23 19:26 UTC (permalink / raw)
To: Johannes Geiss; +Cc: alsa-devel
On Mon, 23 Apr 2018 20:40:37 +0200,
Johannes Geiss wrote:
>
> On Mon, 23 Apr 2018 15:42:33 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
>
> > Did you get the error message "Too many HDMI devices" as mentioned in
> > the changelog?
>
> Yes:
>
> Mar 14 11:29:48 mizar kernel: snd_hda_intel 0000:00:1b.0: Too many HDMI
> devices Mar 14 11:29:48 mizar kernel: snd_hda_intel 0000:00:1b.0:
> Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y Mar 14
> 11:29:48 mizar kernel: input: HDA Intel PCH Line
> as /devices/pci0000:00/0000:00:1b.0/sound/card0/input3 Mar 14 11:29:48
> mizar kernel: input: HDA Intel PCH Headphone
> as /devices/pci0000:00/0000:00:1b.0/sound/card0/input4 Mar 14 11:29:48
> mizar kernel: input: HDA Intel PCH SPDIF In
> as /devices/pci0000:00/0000:00:1b.0/sound/card0/input5 Mar 14 11:29:48
> mizar kernel: input: HDA Intel PCH HDMI/DP,pcm=3
> as /devices/pci0000:00/0000:00:1b.0/sound/card0/input7 Mar 14 11:29:48
> mizar kernel: input: HDA Intel PCH HDMI/DP,pcm=7
> as /devices/pci0000:00/0000:00:1b.0/sound/card0/input8 Mar 14 11:29:48
> mizar kernel: input: HDA Intel PCH HDMI/DP
> as /devices/pci0000:00/0000:00:1b.0/sound/card0/input9 Mar 14 11:29:48
> mizar systemd[1]: Reached target Sound Card.
>
> Does this mean I should try to use CONFIG_SND_DYNAMIC_MINORS=y to solve
> the hibernate/suspend problem?
I guess the problem should gone with that kconfig, yes.
But it doesn't mean that we ignore the issue.
What about the patch below? Does it change the behavior?
thanks,
Takashi
-- 8< --
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1383,6 +1383,8 @@ static void hdmi_pcm_setup_pin(struct hdmi_spec *spec,
pcm = get_pcm_rec(spec, per_pin->pcm_idx);
else
return;
+ if (!pcm->pcm)
+ return;
if (!test_bit(per_pin->pcm_idx, &spec->pcm_in_use))
return;
@@ -2151,8 +2153,13 @@ static int generic_hdmi_build_controls(struct hda_codec *codec)
int dev, err;
int pin_idx, pcm_idx;
-
for (pcm_idx = 0; pcm_idx < spec->pcm_used; pcm_idx++) {
+ if (!get_pcm_rec(spec, pcm_idx)->pcm) {
+ /* no PCM; mark this not to be selected */
+ set_bit(idx, &spec->pcm_bitmap);
+ continue;
+ }
+
err = generic_hdmi_build_jack(codec, pcm_idx);
if (err < 0)
return err;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-23 19:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-23 6:53 Linux-Kernel: System freezes after hibernate or suspend on a Mac mini 6, 2 Johannes Geiss
2018-04-23 13:42 ` Takashi Iwai
2018-04-23 18:40 ` Johannes Geiss
2018-04-23 19:26 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.