From: Takashi Iwai <tiwai@suse.de>
To: Greg KH <gregkh@suse.de>
Cc: Roel Kluin <roel.kluin@gmail.com>,
johannes@sipsolutions.net, linuxppc-dev@ozlabs.org,
alsa-devel@alsa-project.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device
Date: Wed, 13 May 2009 07:44:51 +0200 [thread overview]
Message-ID: <s5heiut1rqk.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090512230514.GB11084@suse.de>
At Tue, 12 May 2009 16:05:14 -0700,
Greg KH wrote:
>
> On Tue, May 12, 2009 at 09:23:47AM +0200, Takashi Iwai wrote:
> > At Mon, 11 May 2009 23:57:43 -0700,
> > Greg KH wrote:
> > >
> > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote:
> > > > At Mon, 11 May 2009 21:54:51 +0200,
> > > > Roel Kluin wrote:
> > > > >
> > > > > To avoid direct access to the driver_data pointer in struct device, the
> > > > > functions dev_get_drvdata() and dev_set_drvdata() should be used.
> > > > >
> > > > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > > >
> > > > The same fix has been already in Greg's tree (and thus in linux-next).
> > > >
> > > > Greg, is it OK that I take over your patch to sound git tree?
> > >
> > > Yes, please do, no objection from me at all.
> >
> > OK, will do.
> >
> > BTW, should it be pushed to 2.6.30? If "the near future" you
> > mentioned in the patch means 2.6.31, it'll be better to merge that fix
> > now. Otherwise, I'm going to apply the patch as a 2.6.31 material.
>
> .31 is fine, that is what I was meaning by with "near future" :)
OK, thanks!
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Greg KH <gregkh@suse.de>
Cc: linuxppc-dev@ozlabs.org, johannes@sipsolutions.net,
Roel Kluin <roel.kluin@gmail.com>,
alsa-devel@alsa-project.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] aoa: remove driver_data direct access of struct device
Date: Wed, 13 May 2009 07:44:51 +0200 [thread overview]
Message-ID: <s5heiut1rqk.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090512230514.GB11084@suse.de>
At Tue, 12 May 2009 16:05:14 -0700,
Greg KH wrote:
>
> On Tue, May 12, 2009 at 09:23:47AM +0200, Takashi Iwai wrote:
> > At Mon, 11 May 2009 23:57:43 -0700,
> > Greg KH wrote:
> > >
> > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote:
> > > > At Mon, 11 May 2009 21:54:51 +0200,
> > > > Roel Kluin wrote:
> > > > >
> > > > > To avoid direct access to the driver_data pointer in struct device, the
> > > > > functions dev_get_drvdata() and dev_set_drvdata() should be used.
> > > > >
> > > > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > > >
> > > > The same fix has been already in Greg's tree (and thus in linux-next).
> > > >
> > > > Greg, is it OK that I take over your patch to sound git tree?
> > >
> > > Yes, please do, no objection from me at all.
> >
> > OK, will do.
> >
> > BTW, should it be pushed to 2.6.30? If "the near future" you
> > mentioned in the patch means 2.6.31, it'll be better to merge that fix
> > now. Otherwise, I'm going to apply the patch as a 2.6.31 material.
>
> .31 is fine, that is what I was meaning by with "near future" :)
OK, thanks!
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Greg KH <gregkh@suse.de>
Cc: linuxppc-dev@ozlabs.org, johannes@sipsolutions.net,
Roel Kluin <roel.kluin@gmail.com>,
alsa-devel@alsa-project.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device
Date: Wed, 13 May 2009 07:44:51 +0200 [thread overview]
Message-ID: <s5heiut1rqk.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090512230514.GB11084@suse.de>
At Tue, 12 May 2009 16:05:14 -0700,
Greg KH wrote:
>
> On Tue, May 12, 2009 at 09:23:47AM +0200, Takashi Iwai wrote:
> > At Mon, 11 May 2009 23:57:43 -0700,
> > Greg KH wrote:
> > >
> > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote:
> > > > At Mon, 11 May 2009 21:54:51 +0200,
> > > > Roel Kluin wrote:
> > > > >
> > > > > To avoid direct access to the driver_data pointer in struct device, the
> > > > > functions dev_get_drvdata() and dev_set_drvdata() should be used.
> > > > >
> > > > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > > >
> > > > The same fix has been already in Greg's tree (and thus in linux-next).
> > > >
> > > > Greg, is it OK that I take over your patch to sound git tree?
> > >
> > > Yes, please do, no objection from me at all.
> >
> > OK, will do.
> >
> > BTW, should it be pushed to 2.6.30? If "the near future" you
> > mentioned in the patch means 2.6.31, it'll be better to merge that fix
> > now. Otherwise, I'm going to apply the patch as a 2.6.31 material.
>
> .31 is fine, that is what I was meaning by with "near future" :)
OK, thanks!
Takashi
next prev parent reply other threads:[~2009-05-13 5:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 19:54 [PATCH] aoa: remove driver_data direct access of struct device Roel Kluin
2009-05-12 6:40 ` [alsa-devel] " Takashi Iwai
2009-05-12 6:40 ` Takashi Iwai
2009-05-12 6:40 ` Takashi Iwai
2009-05-12 6:57 ` [alsa-devel] " Greg KH
2009-05-12 6:57 ` Greg KH
2009-05-12 7:23 ` Takashi Iwai
2009-05-12 7:23 ` Takashi Iwai
2009-05-12 7:23 ` Takashi Iwai
2009-05-12 23:05 ` [alsa-devel] " Greg KH
2009-05-12 23:05 ` Greg KH
2009-05-13 5:44 ` Takashi Iwai [this message]
2009-05-13 5:44 ` Takashi Iwai
2009-05-13 5:44 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5heiut1rqk.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@suse.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.