All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: ASoC updates for 3.1
Date: Fri, 12 Aug 2011 18:26:22 +0200	[thread overview]
Message-ID: <s5hfwl67g0h.wl%tiwai@suse.de> (raw)
In-Reply-To: <20110812161142.GA31583@opensource.wolfsonmicro.com>

At Sat, 13 Aug 2011 01:11:44 +0900,
Mark Brown wrote:
> 
> The following changes since commit 8c285645ab3b05942124020b5f0b89d3b539823a:
> 
>   Merge branch 'wm8996-rename' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6 into fix/asoc (2011-08-08 10:45:31 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-3.1
> 
> So more changes ended up cooking in -next for the wm8750 than had been
> anticipated - it should've been a simple SPI driver ID addition but it
> got messed up for the modular x86_64 builds that I have difficultly in
> doing while travelling.

I got a build warning, so applied the patch below in addition.

> The change from Sangbeom is another change percolating through after the
> merge window that I'd forgotten about until Kukjin reminded me.

Hmm, OK.  It's basically too late, but it's no serious stuff, so let's
get in.


Now pushed out.


thanks,

Takashi

---
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ASoC: Fix compile warning in wm8750.c

sound/soc/codecs/wm8750.c:784:2: warning: missing braces around initializer
sound/soc/codecs/wm8750.c:784:2: warning: (near initialization for ‘wm8750_spi_ids[2].name’)

It's because struct spi_device_id.name is a char array, not a pointer,
while the driver initializes explicitly with 0.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/codecs/wm8750.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8750.c b/sound/soc/codecs/wm8750.c
index 82ac5fc..d0003cc 100644
--- a/sound/soc/codecs/wm8750.c
+++ b/sound/soc/codecs/wm8750.c
@@ -781,7 +781,7 @@ static int __devexit wm8750_spi_remove(struct spi_device *spi)
 static const struct spi_device_id wm8750_spi_ids[] = {
 	{ "wm8750", 0 },
 	{ "wm8987", 0 },
-	{ 0, 0 },
+	{ },
 };
 MODULE_DEVICE_TABLE(spi, wm8750_spi_ids);
 
-- 
1.7.6

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2011-08-12 16:26 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 16:11 ASoC updates for 3.1 Mark Brown
2011-08-12 16:26 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-10-04 13:47 Mark Brown
2011-10-04 14:11 ` Takashi Iwai
2011-10-04 14:23   ` Mark Brown
2011-10-04 14:38     ` Takashi Iwai
2011-09-27 12:31 Mark Brown
2011-09-27 12:44 ` Takashi Iwai
2011-09-22 17:17 Mark Brown
2011-09-22 18:02 ` Takashi Iwai
2011-09-26  5:27 ` Scott Jiang
2011-09-26 12:36   ` Mark Brown
2011-09-08 18:22 Mark Brown
2011-08-25 11:07 Mark Brown
2011-08-25 12:08 ` Takashi Iwai
2011-08-21 12:08 Mark Brown
2011-08-21 13:47 ` Takashi Iwai
2011-08-21 16:00   ` Mark Brown
2011-08-21 16:25     ` Takashi Iwai
2011-08-21 16:46       ` Mark Brown
2011-08-04  4:11 Mark Brown
2011-08-04 14:21 ` Takashi Iwai
2011-07-25  7:05 Mark Brown
2011-07-25  7:42 ` Takashi Iwai
2011-07-18 10:43 Mark Brown
2011-07-18 11:12 ` Takashi Iwai
2011-07-13 23:58 Mark Brown
2011-07-09  9:20 Mark Brown
2011-07-05  6:16 Mark Brown
2011-07-05  6:22 ` Takashi Iwai
2011-06-24 10:36 Mark Brown
2011-06-24 10:59 ` Takashi Iwai
2011-06-10 12:03 Mark Brown
2011-06-10 12:04 ` Mark Brown
2011-06-10 12:23   ` Takashi Iwai
2011-05-30  3:20 Mark Brown
2011-06-02 17:54 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfwl67g0h.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.