* [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl
@ 2022-05-08 21:28 Colin Ian King
2022-05-09 8:43 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2022-05-08 21:28 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
Pointer kctl is being assigned a value that is not being read, buf
is being re-assigned later. The assignment is redundant and can be
removed.
Cleans up clang scan build warning:
sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored
to 'kctl' is used in the enclosing expression, the value is never
actually read from 'kctl' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
sound/pci/rme9652/hdsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index 3db641318d3a..dcc43a81ae0e 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -3314,7 +3314,7 @@ static int snd_hdsp_create_controls(struct snd_card *card, struct hdsp *hdsp)
if (hdsp->io_type == RPM) {
/* RPM Bypass, Disconnect and Input switches */
for (idx = 0; idx < ARRAY_SIZE(snd_hdsp_rpm_controls); idx++) {
- err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_rpm_controls[idx], hdsp));
+ err = snd_ctl_add(card, snd_ctl_new1(&snd_hdsp_rpm_controls[idx], hdsp));
if (err < 0)
return err;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl
2022-05-08 21:28 [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl Colin Ian King
@ 2022-05-09 8:43 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2022-05-09 8:43 UTC (permalink / raw)
To: Colin Ian King; +Cc: linux-kernel, alsa-devel, kernel-janitors, Takashi Iwai
On Sun, 08 May 2022 23:28:19 +0200,
Colin Ian King wrote:
>
> Pointer kctl is being assigned a value that is not being read, buf
> is being re-assigned later. The assignment is redundant and can be
> removed.
>
> Cleans up clang scan build warning:
> sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored
> to 'kctl' is used in the enclosing expression, the value is never
> actually read from 'kctl' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl
@ 2022-05-09 8:43 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2022-05-09 8:43 UTC (permalink / raw)
To: Colin Ian King
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors, linux-kernel
On Sun, 08 May 2022 23:28:19 +0200,
Colin Ian King wrote:
>
> Pointer kctl is being assigned a value that is not being read, buf
> is being re-assigned later. The assignment is redundant and can be
> removed.
>
> Cleans up clang scan build warning:
> sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored
> to 'kctl' is used in the enclosing expression, the value is never
> actually read from 'kctl' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-09 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-08 21:28 [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl Colin Ian King
2022-05-09 8:43 ` Takashi Iwai
2022-05-09 8:43 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.