* [PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers
@ 2013-02-06 22:32 H Hartley Sweeten
2013-02-07 11:04 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2013-02-06 22:32 UTC (permalink / raw)
To: linux-kernel
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +--------------
sound/pcmcia/vx/vxpocket.c | 14 +-------------
2 files changed, 2 insertions(+), 27 deletions(-)
diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c
index f9b5229..8f489de 100644
--- a/sound/pcmcia/pdaudiocf/pdaudiocf.c
+++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c
@@ -295,18 +295,5 @@ static struct pcmcia_driver pdacf_cs_driver = {
.suspend = pdacf_suspend,
.resume = pdacf_resume,
#endif
-
};
-
-static int __init init_pdacf(void)
-{
- return pcmcia_register_driver(&pdacf_cs_driver);
-}
-
-static void __exit exit_pdacf(void)
-{
- pcmcia_unregister_driver(&pdacf_cs_driver);
-}
-
-module_init(init_pdacf);
-module_exit(exit_pdacf);
+module_pcmcia_driver(pdacf_cs_driver);
diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c
index 8f93504..d4db7ec 100644
--- a/sound/pcmcia/vx/vxpocket.c
+++ b/sound/pcmcia/vx/vxpocket.c
@@ -367,16 +367,4 @@ static struct pcmcia_driver vxp_cs_driver = {
.resume = vxp_resume,
#endif
};
-
-static int __init init_vxpocket(void)
-{
- return pcmcia_register_driver(&vxp_cs_driver);
-}
-
-static void __exit exit_vxpocket(void)
-{
- pcmcia_unregister_driver(&vxp_cs_driver);
-}
-
-module_init(init_vxpocket);
-module_exit(exit_vxpocket);
+module_pcmcia_driver(vxp_cs_driver);
--
1.8.1.1.293.gfe73786
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers
2013-02-06 22:32 [PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers H Hartley Sweeten
@ 2013-02-07 11:04 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2013-02-07 11:04 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: linux-kernel
At Wed, 6 Feb 2013 15:32:50 -0700,
H Hartley Sweeten wrote:
>
> Use the new module_pcmcia_driver() macro to remove the boilerplate
> module init/exit code in the pcmcia drivers.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
(But please add subsystem maintainers to Cc at the next time...)
Takashi
> ---
> sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +--------------
> sound/pcmcia/vx/vxpocket.c | 14 +-------------
> 2 files changed, 2 insertions(+), 27 deletions(-)
>
> diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c
> index f9b5229..8f489de 100644
> --- a/sound/pcmcia/pdaudiocf/pdaudiocf.c
> +++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c
> @@ -295,18 +295,5 @@ static struct pcmcia_driver pdacf_cs_driver = {
> .suspend = pdacf_suspend,
> .resume = pdacf_resume,
> #endif
> -
> };
> -
> -static int __init init_pdacf(void)
> -{
> - return pcmcia_register_driver(&pdacf_cs_driver);
> -}
> -
> -static void __exit exit_pdacf(void)
> -{
> - pcmcia_unregister_driver(&pdacf_cs_driver);
> -}
> -
> -module_init(init_pdacf);
> -module_exit(exit_pdacf);
> +module_pcmcia_driver(pdacf_cs_driver);
> diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c
> index 8f93504..d4db7ec 100644
> --- a/sound/pcmcia/vx/vxpocket.c
> +++ b/sound/pcmcia/vx/vxpocket.c
> @@ -367,16 +367,4 @@ static struct pcmcia_driver vxp_cs_driver = {
> .resume = vxp_resume,
> #endif
> };
> -
> -static int __init init_vxpocket(void)
> -{
> - return pcmcia_register_driver(&vxp_cs_driver);
> -}
> -
> -static void __exit exit_vxpocket(void)
> -{
> - pcmcia_unregister_driver(&vxp_cs_driver);
> -}
> -
> -module_init(init_vxpocket);
> -module_exit(exit_vxpocket);
> +module_pcmcia_driver(vxp_cs_driver);
> --
> 1.8.1.1.293.gfe73786
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-07 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-06 22:32 [PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers H Hartley Sweeten
2013-02-07 11:04 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.