All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] ALSA: virmidi: Remove duplicated code
@ 2022-01-06 12:38 Stefan Sauer
  2022-01-06 15:09 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Sauer @ 2022-01-06 12:38 UTC (permalink / raw)
  To: alsa-devel; +Cc: Stefan Sauer

seq_virmidi.c: snd_virmidi_new() is already setting seq_mode to
SNDRV_VIRMIDI_SEQ_DISPATCH.

Signed-off-by: Stefan Sauer <st_kost@gmx.de>
---
 sound/drivers/virmidi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/drivers/virmidi.c b/sound/drivers/virmidi.c
index 7f7eed6faaae..58012de90c38 100644
--- a/sound/drivers/virmidi.c
+++ b/sound/drivers/virmidi.c
@@ -90,15 +90,12 @@ static int snd_virmidi_probe(struct platform_device *devptr)
 	}
 	for (idx = 0; idx < midi_devs[dev]; idx++) {
 		struct snd_rawmidi *rmidi;
-		struct snd_virmidi_dev *rdev;

 		err = snd_virmidi_new(card, idx, &rmidi);
 		if (err < 0)
 			return err;
-		rdev = rmidi->private_data;
 		vmidi->midi[idx] = rmidi;
 		strcpy(rmidi->name, "Virtual Raw MIDI");
-		rdev->seq_mode = SNDRV_VIRMIDI_SEQ_DISPATCH;
 	}

 	strcpy(card->driver, "VirMIDI");
--
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] ALSA: virmidi: Remove duplicated code
  2022-01-06 12:38 [PATCH 2/2] ALSA: virmidi: Remove duplicated code Stefan Sauer
@ 2022-01-06 15:09 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-01-06 15:09 UTC (permalink / raw)
  To: Stefan Sauer; +Cc: alsa-devel

On Thu, 06 Jan 2022 13:38:21 +0100,
Stefan Sauer wrote:
> 
> seq_virmidi.c: snd_virmidi_new() is already setting seq_mode to
> SNDRV_VIRMIDI_SEQ_DISPATCH.
> 
> Signed-off-by: Stefan Sauer <st_kost@gmx.de>

Thanks, applied now.

BTW, at the next time, please put maintainers to Cc.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-06 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 12:38 [PATCH 2/2] ALSA: virmidi: Remove duplicated code Stefan Sauer
2022-01-06 15:09 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.