* [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+
@ 2018-05-08 22:13 Federico Cuello
2018-05-13 16:54 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Federico Cuello @ 2018-05-08 22:13 UTC (permalink / raw)
To: alsa-devel; +Cc: Federico Cuello
Currently it's not possible to set volume lower than 26% (it just mutes).
Also fixes this warning:
Warning! Unlikely big volume range (=9472), cval->res is probably wrong.
[13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
, and volume works fine for full range.
Signed-off-by: Federico Cuello <fedux@fedux.com.ar>
---
sound/usb/mixer.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 344d7b069d59..bb5ab7a7dfa5 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -967,6 +967,14 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
}
break;
+ case USB_ID(0x0d8c, 0x0103):
+ if (!strcmp(kctl->id.name, "PCM Playback Volume")) {
+ usb_audio_info(chip,
+ "set volume quirk for CM102-A+/102S+\n");
+ cval->min = -256;
+ }
+ break;
+
case USB_ID(0x0471, 0x0101):
case USB_ID(0x0471, 0x0104):
case USB_ID(0x0471, 0x0105):
--
2.17.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+
2018-05-08 22:13 [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+ Federico Cuello
@ 2018-05-13 16:54 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2018-05-13 16:54 UTC (permalink / raw)
To: Federico Cuello; +Cc: alsa-devel
On Wed, 09 May 2018 00:13:38 +0200,
Federico Cuello wrote:
>
> Currently it's not possible to set volume lower than 26% (it just mutes).
>
> Also fixes this warning:
>
> Warning! Unlikely big volume range (=9472), cval->res is probably wrong.
> [13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
>
> , and volume works fine for full range.
>
> Signed-off-by: Federico Cuello <fedux@fedux.com.ar>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+
2018-05-13 11:13 ` Federico Cuello
@ 2018-05-13 16:57 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2018-05-13 16:57 UTC (permalink / raw)
To: Federico Cuello; +Cc: alsa-devel
On Sun, 13 May 2018 13:13:55 +0200,
Federico Cuello wrote:
>
> El 2018-05-13 12:36, Takashi Iwai escribió:
> > On Sun, 06 May 2018 13:37:18 +0200,
> > Federico Cuello wrote:
> >>
> >> Currently it's not possible to set volume lower than 26% (it just
> >> mutes).
> >>
> >> Also fixes this warning:
> >>
> >> Warning! Unlikely big volume range (=9472), cval->res is probably
> >> wrong.
> >> [13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
> >>
> >> , and volume works fine for full range.
> >
> > Could you give your sign-off? It's a formal process. Otherwise we
> > can't merge anything.
>
>
> Yes, sorry. I didn't know about that before but I already resent the
> signed-off patch on May 8, 2018.
OK, now I saw it and applied it. But at the next time if such a thing
happens, please put some prefix to indicate it's resending,
e.g. [PATCH RESEND] or [PATCH v2].
Also, put maintainers (me) to Cc. In this way, it won't be missed.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+
2018-05-13 10:36 ` Takashi Iwai
@ 2018-05-13 11:13 ` Federico Cuello
2018-05-13 16:57 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Federico Cuello @ 2018-05-13 11:13 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
El 2018-05-13 12:36, Takashi Iwai escribió:
> On Sun, 06 May 2018 13:37:18 +0200,
> Federico Cuello wrote:
>>
>> Currently it's not possible to set volume lower than 26% (it just
>> mutes).
>>
>> Also fixes this warning:
>>
>> Warning! Unlikely big volume range (=9472), cval->res is probably
>> wrong.
>> [13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
>>
>> , and volume works fine for full range.
>
> Could you give your sign-off? It's a formal process. Otherwise we
> can't merge anything.
Yes, sorry. I didn't know about that before but I already resent the
signed-off patch on May 8, 2018.
Thanks a lot!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+
2018-05-06 11:37 Federico Cuello
@ 2018-05-13 10:36 ` Takashi Iwai
2018-05-13 11:13 ` Federico Cuello
0 siblings, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2018-05-13 10:36 UTC (permalink / raw)
To: Federico Cuello; +Cc: alsa-devel
On Sun, 06 May 2018 13:37:18 +0200,
Federico Cuello wrote:
>
> Currently it's not possible to set volume lower than 26% (it just mutes).
>
> Also fixes this warning:
>
> Warning! Unlikely big volume range (=9472), cval->res is probably wrong.
> [13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
>
> , and volume works fine for full range.
Could you give your sign-off? It's a formal process. Otherwise we
can't merge anything.
thanks,
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+
@ 2018-05-07 16:42 Federico Cuello
0 siblings, 0 replies; 7+ messages in thread
From: Federico Cuello @ 2018-05-07 16:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Federico Cuello
Currently it's not possible to set volume lower than 26% (it just
mutes).
Also fixes this warning:
Warning! Unlikely big volume range (=9472), cval->res is probably
wrong.
[13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
, and volume works fine for full range.
---
sound/usb/mixer.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 344d7b069d59..bb5ab7a7dfa5 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -967,6 +967,14 @@ static void volume_control_quirks(struct
usb_mixer_elem_info *cval,
}
break;
+ case USB_ID(0x0d8c, 0x0103):
+ if (!strcmp(kctl->id.name, "PCM Playback Volume")) {
+ usb_audio_info(chip,
+ "set volume quirk for CM102-A+/102S+\n");
+ cval->min = -256;
+ }
+ break;
+
case USB_ID(0x0471, 0x0101):
case USB_ID(0x0471, 0x0104):
case USB_ID(0x0471, 0x0105):
--
2.17.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+
@ 2018-05-06 11:37 Federico Cuello
2018-05-13 10:36 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Federico Cuello @ 2018-05-06 11:37 UTC (permalink / raw)
To: alsa-devel; +Cc: Federico Cuello
Currently it's not possible to set volume lower than 26% (it just mutes).
Also fixes this warning:
Warning! Unlikely big volume range (=9472), cval->res is probably wrong.
[13] FU [PCM Playback Volume] ch = 2, val = -9473/-1/1
, and volume works fine for full range.
---
sound/usb/mixer.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 344d7b069d59..bb5ab7a7dfa5 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -967,6 +967,14 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
}
break;
+ case USB_ID(0x0d8c, 0x0103):
+ if (!strcmp(kctl->id.name, "PCM Playback Volume")) {
+ usb_audio_info(chip,
+ "set volume quirk for CM102-A+/102S+\n");
+ cval->min = -256;
+ }
+ break;
+
case USB_ID(0x0471, 0x0101):
case USB_ID(0x0471, 0x0104):
case USB_ID(0x0471, 0x0105):
--
2.17.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-13 16:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08 22:13 [PATCH] ALSA: usb: mixer: volume quirk for CM102-A+/102S+ Federico Cuello
2018-05-13 16:54 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2018-05-07 16:42 Federico Cuello
2018-05-06 11:37 Federico Cuello
2018-05-13 10:36 ` Takashi Iwai
2018-05-13 11:13 ` Federico Cuello
2018-05-13 16:57 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.