All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Kai-Heng Feng" <kaihengfeng@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <hui.wang@canonical.com>,
	"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda - Fix headphone noise on Dell XPS 13 9360
Date: Fri, 20 May 2016 09:04:28 +0200	[thread overview]
Message-ID: <s5hk2ip43cz.wl-tiwai@suse.de> (raw)
In-Reply-To: <1463721889-12131-1-git-send-email-kai.heng.feng@canonical.com>

On Fri, 20 May 2016 07:24:49 +0200,
Kai-Heng Feng wrote:
> 
> The headphone has noise when playing sound or switching microphone sources.
> It uses the same codec on XPS 13 9350, but with different subsystem ID.
> Applying the fixup can solve the issue.
> Also, changing the model name to better differentiate models.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 002f153..e6af865 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5466,7 +5466,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1028, 0x06de, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
>  	SND_PCI_QUIRK(0x1028, 0x06df, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
>  	SND_PCI_QUIRK(0x1028, 0x06e0, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
> -	SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
> +	SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13 9350", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
> +	SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
>  	SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE),
>  	SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),

The list is ordered (lightly) by device number.  Could you put the new
entry at the right place?


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kaihengfeng@gmail.com>
Cc: alsa-devel@alsa-project.org, hui.wang@canonical.com,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - Fix headphone noise on Dell XPS 13 9360
Date: Fri, 20 May 2016 09:04:28 +0200	[thread overview]
Message-ID: <s5hk2ip43cz.wl-tiwai@suse.de> (raw)
In-Reply-To: <1463721889-12131-1-git-send-email-kai.heng.feng@canonical.com>

On Fri, 20 May 2016 07:24:49 +0200,
Kai-Heng Feng wrote:
> 
> The headphone has noise when playing sound or switching microphone sources.
> It uses the same codec on XPS 13 9350, but with different subsystem ID.
> Applying the fixup can solve the issue.
> Also, changing the model name to better differentiate models.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 002f153..e6af865 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5466,7 +5466,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1028, 0x06de, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
>  	SND_PCI_QUIRK(0x1028, 0x06df, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
>  	SND_PCI_QUIRK(0x1028, 0x06e0, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
> -	SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
> +	SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13 9350", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
> +	SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
>  	SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE),
>  	SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),

The list is ordered (lightly) by device number.  Could you put the new
entry at the right place?


thanks,

Takashi

  reply	other threads:[~2016-05-20  7:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20  5:24 [PATCH] ALSA: hda - Fix headphone noise on Dell XPS 13 9360 Kai-Heng Feng
2016-05-20  5:24 ` Kai-Heng Feng
2016-05-20  7:04 ` Takashi Iwai [this message]
2016-05-20  7:04   ` Takashi Iwai
2016-05-20  7:47 Kai-Heng Feng
2016-05-20  9:05 ` Takashi Iwai
2016-05-20  9:05   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hk2ip43cz.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kaihengfeng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.