All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add quirk for HP EliteBook 840 G7 mute LED
@ 2021-11-10 14:40 ` Kai-Heng Feng
  0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2021-11-10 14:40 UTC (permalink / raw)
  To: tiwai
  Cc: Kai-Heng Feng, Jaroslav Kysela, Jeremy Szu, Kailang Yang,
	Hui Wang, Chris Chiu, Cameron Berkenpas, PeiSen Hou,
	Werner Sembach, Sami Loone, Elia Devito, moderated list:SOUND,
	open list

The mute and micmute LEDs don't work on HP EliteBook 840 G7. The same
quirk for other HP laptops can let LEDs work, so apply it.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a6098c942aeb5..2f1727faec698 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8636,6 +8636,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
 	SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
 	SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8728, "HP EliteBook 840 G7", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ALSA: hda/realtek: Add quirk for HP EliteBook 840 G7 mute LED
@ 2021-11-10 14:40 ` Kai-Heng Feng
  0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2021-11-10 14:40 UTC (permalink / raw)
  To: tiwai
  Cc: Chris Chiu, moderated list:SOUND, Kailang Yang, Jeremy Szu,
	Elia Devito, open list, Werner Sembach, Hui Wang, PeiSen Hou,
	Kai-Heng Feng, Sami Loone, Cameron Berkenpas

The mute and micmute LEDs don't work on HP EliteBook 840 G7. The same
quirk for other HP laptops can let LEDs work, so apply it.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a6098c942aeb5..2f1727faec698 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8636,6 +8636,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
 	SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
 	SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8728, "HP EliteBook 840 G7", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP EliteBook 840 G7 mute LED
  2021-11-10 14:40 ` Kai-Heng Feng
@ 2021-11-10 14:44   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-11-10 14:44 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: tiwai, Jaroslav Kysela, Jeremy Szu, Kailang Yang, Hui Wang,
	Chris Chiu, Cameron Berkenpas, PeiSen Hou, Werner Sembach,
	Sami Loone, Elia Devito, moderated list:SOUND, open list

On Wed, 10 Nov 2021 15:40:32 +0100,
Kai-Heng Feng wrote:
> 
> The mute and micmute LEDs don't work on HP EliteBook 840 G7. The same
> quirk for other HP laptops can let LEDs work, so apply it.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP EliteBook 840 G7 mute LED
@ 2021-11-10 14:44   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-11-10 14:44 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: Chris Chiu, moderated list:SOUND, Kailang Yang, Jeremy Szu,
	open list, Elia Devito, tiwai, Werner Sembach, Hui Wang,
	PeiSen Hou, Sami Loone, Cameron Berkenpas

On Wed, 10 Nov 2021 15:40:32 +0100,
Kai-Heng Feng wrote:
> 
> The mute and micmute LEDs don't work on HP EliteBook 840 G7. The same
> quirk for other HP laptops can let LEDs work, so apply it.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-10 14:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 14:40 [PATCH] ALSA: hda/realtek: Add quirk for HP EliteBook 840 G7 mute LED Kai-Heng Feng
2021-11-10 14:40 ` Kai-Heng Feng
2021-11-10 14:44 ` Takashi Iwai
2021-11-10 14:44   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.