All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: set the interface format after resume on Dell WD19
Date: Wed, 18 Dec 2019 20:06:08 +0100	[thread overview]
Message-ID: <s5hlfr9zc67.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191218132650.6303-1-hui.wang@canonical.com>

On Wed, 18 Dec 2019 14:26:50 +0100,
Hui Wang wrote:
> 
> Recently we found the headset-mic on the Dell Dock WD19 doesn't work
> anymore after s3 (s2i or deep), this problem could be workarounded by
> closeing (pcm_close) the app and then reopening (pcm_open) the app, so
> this bug is not easy to be detected by users.
> 
> When problem happens, retire_capture_urb() could still be called
> periodically, but the size of captured data is always 0, it could be
> a firmware bug on the dock. Anyway I found after resuming, the
> snd_usb_pcm_prepare() will be called, and if we forcibly run
> set_format() to set the interface and its endpoint, the capture
> size will be normal again. This problem and workaound also apply to
> playback.
> 
> To fix it in the kernel, add a quirk to let set_format() run
> forcibly once after resume.
> 
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Thanks, the workaround looks reasonable.
I applied it now with Cc to stable.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-12-18 19:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 13:26 [alsa-devel] [PATCH] ALSA: usb-audio: set the interface format after resume on Dell WD19 Hui Wang
2019-12-18 19:06 ` Takashi Iwai [this message]
2019-12-19  4:55   ` Kai Heng Feng
2019-12-19  6:23     ` Hui Wang
2019-12-19  6:37       ` Kai Heng Feng
2019-12-19  8:35         ` Takashi Iwai
2019-12-19  8:46           ` Kai Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlfr9zc67.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.