gusextreme: set codec_flag

gusextreme: set codec_flag

[Rene Herman]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Good day.

===
The gusextreme driver neglects to set the gus->codec_flag meaning 
snd_gf1_pcm_new() allocates a second "PCM Playback Volume" control, 
which makes the driver fail to load.

Signed-off-by: Rene Herman <rene.herman@gmail.com>
===

On top of isa_bus patch...

With this the driver works "fine" -- the es1688 bit is fine and the gf1 
bit has the same problems as gusclassic; I assume it's going to be the 
same solution as well.

Rene.

[-- Attachment #2: gusextreme-codec_flag.diff --]
[-- Type: text/plain, Size: 384 bytes --]

diff --git a/sound/isa/gus/gusextreme.c b/sound/isa/gus/gusextreme.c
index 74e34e6..0aeaa6c 100644
--- a/sound/isa/gus/gusextreme.c
+++ b/sound/isa/gus/gusextreme.c
@@ -283,6 +283,7 @@ static int __devinit snd_gusextreme_prob
 			"detected at 0x%lx\n", dev->bus_id, gus->gf1.port);
 		goto out;
 	}
+	gus->codec_flag = 1;
 
 	error = snd_es1688_pcm(es1688, 0, NULL);
 	if (error < 0)

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: gusextreme: set codec_flag

[Takashi Iwai]

At Sun, 18 Feb 2007 21:07:21 +0100,
Rene Herman wrote:
> 
> [1  <text/plain; ISO-8859-15 (7bit)>]
> Good day.
> 
> ===
> The gusextreme driver neglects to set the gus->codec_flag meaning 
> snd_gf1_pcm_new() allocates a second "PCM Playback Volume" control, 
> which makes the driver fail to load.
> 
> Signed-off-by: Rene Herman <rene.herman@gmail.com>
> ===
> 
> On top of isa_bus patch...
> 
> With this the driver works "fine" -- the es1688 bit is fine and the gf1 
> bit has the same problems as gusclassic; I assume it's going to be the 
> same solution as well.

Great.  I applied all three patches to ALSA HG tree now.
Thanks!


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV