All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock
@ 2020-06-08  6:26 ` Kai-Heng Feng
  0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2020-06-08  6:26 UTC (permalink / raw)
  To: tiwai
  Cc: Kai-Heng Feng, Jaroslav Kysela, Alexander Tsoy, Stefan Sauer,
	Gregor Pintar, Dmitry Panchenko, Ard van Breemen,
	František Kučera, moderated list:SOUND, open list

The HP Thunderbolt Dock has two separate USB devices, one is for speaker
and one is for headset. Add names for them so userspace can apply UCM
settings.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 sound/usb/quirks-table.h | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 6d6492195bdc..90d65bfa733d 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -40,6 +40,26 @@
 		.ifnum = QUIRK_NO_INTERFACE				\
 	}
 
+/* HP Thunderbolt Dock Audio Headset */
+{
+	USB_DEVICE(0x03f0, 0x0269),
+	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
+		.vendor_name = "HP",
+		.product_name = "Thunderbolt Dock Audio Headset",
+		.profile_name = "HP-Thunderbolt-Dock-Audio-Headset",
+		.ifnum = QUIRK_NO_INTERFACE
+	}
+},
+/* HP Thunderbolt Dock Audio Module */
+{
+	USB_DEVICE(0x03f0, 0x0567),
+	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
+		.vendor_name = "HP",
+		.product_name = "Thunderbolt Dock Audio Module",
+		.profile_name = "HP-Thunderbolt-Dock-Audio-Module",
+		.ifnum = QUIRK_NO_INTERFACE
+	}
+},
 /* FTDI devices */
 {
 	USB_DEVICE(0x0403, 0xb8d8),
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock
@ 2020-06-08  6:26 ` Kai-Heng Feng
  0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2020-06-08  6:26 UTC (permalink / raw)
  To: tiwai
  Cc: moderated list:SOUND, Ard van Breemen, open list, Alexander Tsoy,
	Kai-Heng Feng, František Kučera, Gregor Pintar,
	Dmitry Panchenko, Stefan Sauer

The HP Thunderbolt Dock has two separate USB devices, one is for speaker
and one is for headset. Add names for them so userspace can apply UCM
settings.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 sound/usb/quirks-table.h | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 6d6492195bdc..90d65bfa733d 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -40,6 +40,26 @@
 		.ifnum = QUIRK_NO_INTERFACE				\
 	}
 
+/* HP Thunderbolt Dock Audio Headset */
+{
+	USB_DEVICE(0x03f0, 0x0269),
+	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
+		.vendor_name = "HP",
+		.product_name = "Thunderbolt Dock Audio Headset",
+		.profile_name = "HP-Thunderbolt-Dock-Audio-Headset",
+		.ifnum = QUIRK_NO_INTERFACE
+	}
+},
+/* HP Thunderbolt Dock Audio Module */
+{
+	USB_DEVICE(0x03f0, 0x0567),
+	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
+		.vendor_name = "HP",
+		.product_name = "Thunderbolt Dock Audio Module",
+		.profile_name = "HP-Thunderbolt-Dock-Audio-Module",
+		.ifnum = QUIRK_NO_INTERFACE
+	}
+},
 /* FTDI devices */
 {
 	USB_DEVICE(0x0403, 0xb8d8),
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock
  2020-06-08  6:26 ` Kai-Heng Feng
@ 2020-06-08  7:14   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-06-08  7:14 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: tiwai, Jaroslav Kysela, Alexander Tsoy, Stefan Sauer,
	Gregor Pintar, Dmitry Panchenko, Ard van Breemen,
	František Kučera, moderated list:SOUND, open list

On Mon, 08 Jun 2020 08:26:28 +0200,
Kai-Heng Feng wrote:
> 
> The HP Thunderbolt Dock has two separate USB devices, one is for speaker
> and one is for headset. Add names for them so userspace can apply UCM
> settings.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Applied now with Cc to stable.

I'm going to apply another patch to replace those with the new
QUIRK_DEVICE_PROFILE() macro, too.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock
@ 2020-06-08  7:14   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-06-08  7:14 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: moderated list:SOUND, open list, Ard van Breemen, tiwai,
	Alexander Tsoy, František Kučera, Gregor Pintar,
	Dmitry Panchenko, Stefan Sauer

On Mon, 08 Jun 2020 08:26:28 +0200,
Kai-Heng Feng wrote:
> 
> The HP Thunderbolt Dock has two separate USB devices, one is for speaker
> and one is for headset. Add names for them so userspace can apply UCM
> settings.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Applied now with Cc to stable.

I'm going to apply another patch to replace those with the new
QUIRK_DEVICE_PROFILE() macro, too.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-08  7:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08  6:26 [PATCH] ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock Kai-Heng Feng
2020-06-08  6:26 ` Kai-Heng Feng
2020-06-08  7:14 ` Takashi Iwai
2020-06-08  7:14   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.