All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek - Fix pincfg for Dell quirk
@ 2017-08-14  9:35 Shih-Yuan Lee (FourDollars)
  2017-08-14  9:47 ` Takashi Iwai
  2017-08-14 10:00 ` [PATCH v2] ALSA: hda/realtek - Fix pincfg for Dell XPS 13 9370 Shih-Yuan Lee (FourDollars)
  0 siblings, 2 replies; 4+ messages in thread
From: Shih-Yuan Lee (FourDollars) @ 2017-08-14  9:35 UTC (permalink / raw)
  To: alsa-devel; +Cc: Kailang Yang, Takashi Iwai

The initial pin configs for Dell headset mode of ALC3271 has changed.

Fixes: b4576de87243 ("ALSA: hda/realtek - Fix typo of pincfg for Dell
quirk")

Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a91a9ef..217bb58 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6647,7 +6647,6 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 	SND_HDA_PIN_QUIRK(0x10ec0299, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
 		ALC225_STANDARD_PINS,
 		{0x12, 0xb7a60130},
-		{0x13, 0xb8a61140},
 		{0x17, 0x90170110}),
 	{}
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - Fix pincfg for Dell quirk
  2017-08-14  9:35 [PATCH] ALSA: hda/realtek - Fix pincfg for Dell quirk Shih-Yuan Lee (FourDollars)
@ 2017-08-14  9:47 ` Takashi Iwai
  2017-08-14 10:00 ` [PATCH v2] ALSA: hda/realtek - Fix pincfg for Dell XPS 13 9370 Shih-Yuan Lee (FourDollars)
  1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2017-08-14  9:47 UTC (permalink / raw)
  To:  Shih-Yuan Lee (FourDollars) ; +Cc: alsa-devel, Kailang Yang

On Mon, 14 Aug 2017 11:35:59 +0200,
 Shih-Yuan Lee (FourDollars)  wrote:
> 
> The initial pin configs for Dell headset mode of ALC3271 has changed.

Which model did it hit?  It's better to mention a bit more about your
change.


thanks,

Takashi

> 
> Fixes: b4576de87243 ("ALSA: hda/realtek - Fix typo of pincfg for Dell
> quirk")
> 
> Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index a91a9ef..217bb58 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6647,7 +6647,6 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  	SND_HDA_PIN_QUIRK(0x10ec0299, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
>  		ALC225_STANDARD_PINS,
>  		{0x12, 0xb7a60130},
> -		{0x13, 0xb8a61140},
>  		{0x17, 0x90170110}),
>  	{}
>  };
> -- 
> 2.7.4
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] ALSA: hda/realtek - Fix pincfg for Dell XPS 13 9370
  2017-08-14  9:35 [PATCH] ALSA: hda/realtek - Fix pincfg for Dell quirk Shih-Yuan Lee (FourDollars)
  2017-08-14  9:47 ` Takashi Iwai
@ 2017-08-14 10:00 ` Shih-Yuan Lee (FourDollars)
  2017-08-14 10:12   ` Takashi Iwai
  1 sibling, 1 reply; 4+ messages in thread
From: Shih-Yuan Lee (FourDollars) @ 2017-08-14 10:00 UTC (permalink / raw)
  To: alsa-devel; +Cc: Kailang Yang, Takashi Iwai

The initial pin configs for Dell headset mode of ALC3271 has changed.

/sys/class/sound/hwC0D0/init_pin_configs: (BIOS 0.1.4)
0x12 0xb7a60130
0x13 0xb8a61140
0x14 0x40000000
0x16 0x411111f0
0x17 0x90170110
0x18 0x411111f0
0x19 0x411111f0
0x1a 0x411111f0
0x1b 0x411111f0
0x1d 0x4087992d
0x1e 0x411111f0
0x21 0x04211020

has changed to ...

/sys/class/sound/hwC0D0/init_pin_configs: (BIOS 0.2.0)
0x12 0xb7a60130
0x13 0x40000000
0x14 0x411111f0
0x16 0x411111f0
0x17 0x90170110
0x18 0x411111f0
0x19 0x411111f0
0x1a 0x411111f0
0x1b 0x411111f0
0x1d 0x4067992d
0x1e 0x411111f0
0x21 0x04211020

Fixes: b4576de87243 ("ALSA: hda/realtek - Fix typo of pincfg for Dell
quirk")

Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a91a9ef..217bb58 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6647,7 +6647,6 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 	SND_HDA_PIN_QUIRK(0x10ec0299, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
 		ALC225_STANDARD_PINS,
 		{0x12, 0xb7a60130},
-		{0x13, 0xb8a61140},
 		{0x17, 0x90170110}),
 	{}
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ALSA: hda/realtek - Fix pincfg for Dell XPS 13 9370
  2017-08-14 10:00 ` [PATCH v2] ALSA: hda/realtek - Fix pincfg for Dell XPS 13 9370 Shih-Yuan Lee (FourDollars)
@ 2017-08-14 10:12   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2017-08-14 10:12 UTC (permalink / raw)
  To:  Shih-Yuan Lee (FourDollars) ; +Cc: alsa-devel, Kailang Yang

On Mon, 14 Aug 2017 12:00:47 +0200,
 Shih-Yuan Lee (FourDollars)  wrote:
> 
> The initial pin configs for Dell headset mode of ALC3271 has changed.
> 
> /sys/class/sound/hwC0D0/init_pin_configs: (BIOS 0.1.4)
> 0x12 0xb7a60130
> 0x13 0xb8a61140
> 0x14 0x40000000
> 0x16 0x411111f0
> 0x17 0x90170110
> 0x18 0x411111f0
> 0x19 0x411111f0
> 0x1a 0x411111f0
> 0x1b 0x411111f0
> 0x1d 0x4087992d
> 0x1e 0x411111f0
> 0x21 0x04211020
> 
> has changed to ...
> 
> /sys/class/sound/hwC0D0/init_pin_configs: (BIOS 0.2.0)
> 0x12 0xb7a60130
> 0x13 0x40000000
> 0x14 0x411111f0
> 0x16 0x411111f0
> 0x17 0x90170110
> 0x18 0x411111f0
> 0x19 0x411111f0
> 0x1a 0x411111f0
> 0x1b 0x411111f0
> 0x1d 0x4067992d
> 0x1e 0x411111f0
> 0x21 0x04211020
> 
> Fixes: b4576de87243 ("ALSA: hda/realtek - Fix typo of pincfg for Dell
> quirk")
> 
> Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-08-14 10:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-14  9:35 [PATCH] ALSA: hda/realtek - Fix pincfg for Dell quirk Shih-Yuan Lee (FourDollars)
2017-08-14  9:47 ` Takashi Iwai
2017-08-14 10:00 ` [PATCH v2] ALSA: hda/realtek - Fix pincfg for Dell XPS 13 9370 Shih-Yuan Lee (FourDollars)
2017-08-14 10:12   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.