* [PATCH] ALSA: hda - Add enable_msi=0 workaround for four HP machines
@ 2013-12-12 8:52 David Henningsson
2013-12-12 16:46 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: David Henningsson @ 2013-12-12 8:52 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: 1260225, David Henningsson, stable
While enabling these machines, we found we would sometimes lose an
interrupt if we change hardware volume during playback, and that
disabling msi fixed this issue. (Losing the interrupt caused underruns
and crackling audio, as the one second timeout is usually bigger than
the period size.)
The machines were all machines from HP, running AMD Hudson controller,
and Realtek ALC282 codec.
Cc: stable@vger.kernel.org
BugLink: https://bugs.launchpad.net/bugs/1260225
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
sound/pci/hda/hda_intel.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index af86c71..440c355 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -3446,6 +3446,10 @@ static void check_probe_mask(struct azx *chip, int dev)
* white/black-list for enable_msi
*/
static struct snd_pci_quirk msi_black_list[] = {
+ SND_PCI_QUIRK(0x103c, 0x2191, "HP", 0), /* AMD Hudson */
+ SND_PCI_QUIRK(0x103c, 0x2192, "HP", 0), /* AMD Hudson */
+ SND_PCI_QUIRK(0x103c, 0x21f7, "HP", 0), /* AMD Hudson */
+ SND_PCI_QUIRK(0x103c, 0x21fa, "HP", 0), /* AMD Hudson */
SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + nvidia */
SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
SND_PCI_QUIRK(0x1043, 0x822d, "ASUS", 0), /* Athlon64 X2 + nvidia MCP55 */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda - Add enable_msi=0 workaround for four HP machines
2013-12-12 8:52 [PATCH] ALSA: hda - Add enable_msi=0 workaround for four HP machines David Henningsson
@ 2013-12-12 16:46 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2013-12-12 16:46 UTC (permalink / raw)
To: David Henningsson; +Cc: alsa-devel, 1260225, stable
At Thu, 12 Dec 2013 09:52:03 +0100,
David Henningsson wrote:
>
> While enabling these machines, we found we would sometimes lose an
> interrupt if we change hardware volume during playback, and that
> disabling msi fixed this issue. (Losing the interrupt caused underruns
> and crackling audio, as the one second timeout is usually bigger than
> the period size.)
>
> The machines were all machines from HP, running AMD Hudson controller,
> and Realtek ALC282 codec.
>
> Cc: stable@vger.kernel.org
> BugLink: https://bugs.launchpad.net/bugs/1260225
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/pci/hda/hda_intel.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index af86c71..440c355 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -3446,6 +3446,10 @@ static void check_probe_mask(struct azx *chip, int dev)
> * white/black-list for enable_msi
> */
> static struct snd_pci_quirk msi_black_list[] = {
> + SND_PCI_QUIRK(0x103c, 0x2191, "HP", 0), /* AMD Hudson */
> + SND_PCI_QUIRK(0x103c, 0x2192, "HP", 0), /* AMD Hudson */
> + SND_PCI_QUIRK(0x103c, 0x21f7, "HP", 0), /* AMD Hudson */
> + SND_PCI_QUIRK(0x103c, 0x21fa, "HP", 0), /* AMD Hudson */
> SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + nvidia */
> SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
> SND_PCI_QUIRK(0x1043, 0x822d, "ASUS", 0), /* Athlon64 X2 + nvidia MCP55 */
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-12 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-12 8:52 [PATCH] ALSA: hda - Add enable_msi=0 workaround for four HP machines David Henningsson
2013-12-12 16:46 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.