[PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC Gamer Xplorer N57001 laptop

[PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC Gamer Xplorer N57001 laptop

[Daniel Chen]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

Hi,

Attached is a patch against current sound-2.6 master HEAD that
resolves the original reporter's inaudible internal speakers by using
the model=asus quirk. Please apply.

Cheers,
-Dan

[-- Attachment #2: 0001-ALSA-hda-Fix-inaudible-internal-speakers-on-Cyberpow.patch --]
[-- Type: text/x-diff, Size: 1253 bytes --]

From cd9ec2351d479856d81666f9d611ed692c8fced9 Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Wed, 8 Jun 2011 17:15:52 -0400
Subject: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC
 Gamer Xplorer N57001 laptop

BugLink: https://launchpad.net/bugs/761171

The original reporter needs the model=asus quirk for his internal
speakers to be audible, so add an entry in the quirk table for his PCI
SSID.

Reported-and-tested-by: tomdeering7
Cc: <stable@kernel.org> [2.6.38+]
Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
 sound/pci/hda/patch_conexant.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 217ca9e..6297e23 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3103,6 +3103,7 @@ static const struct snd_pci_quirk cxt5066_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS),
 	SND_PCI_QUIRK(0x17aa, 0x3938, "Lenovo G565", CXT5066_AUTO),
 	SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo", CXT5066_IDEAPAD), /* Fallback for Lenovos without dock mic */
+	SND_PCI_QUIRK(0x1b0a, 0x2092, "CyberpowerPC Gamer Xplorer N57001", CXT5066_ASUS),
 	{}
 };
 
-- 
1.7.5.3


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC Gamer Xplorer N57001 laptop

[Takashi Iwai]

At Wed, 8 Jun 2011 17:25:05 -0400,
Daniel Chen wrote:
> 
> Hi,
> 
> Attached is a patch against current sound-2.6 master HEAD that
> resolves the original reporter's inaudible internal speakers by using
> the model=asus quirk. Please apply.

Any chance to test model=auto with the very latest snapshot driver (or
3.0-rc2 kernel)?  The auto-parser works better than the static quirk
nowaday, but needs a bit more testing before switching to it as
default.


thanks,

Takashi


> 
> Cheers,
> -Dan
> [2 0001-ALSA-hda-Fix-inaudible-internal-speakers-on-Cyberpow.patch <text/x-diff; US-ASCII (base64)>]
> From cd9ec2351d479856d81666f9d611ed692c8fced9 Mon Sep 17 00:00:00 2001
> From: Daniel T Chen <crimsun@ubuntu.com>
> Date: Wed, 8 Jun 2011 17:15:52 -0400
> Subject: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC
>  Gamer Xplorer N57001 laptop
> 
> BugLink: https://launchpad.net/bugs/761171
> 
> The original reporter needs the model=asus quirk for his internal
> speakers to be audible, so add an entry in the quirk table for his PCI
> SSID.
> 
> Reported-and-tested-by: tomdeering7
> Cc: <stable@kernel.org> [2.6.38+]
> Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
> ---
>  sound/pci/hda/patch_conexant.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 217ca9e..6297e23 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -3103,6 +3103,7 @@ static const struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS),
>  	SND_PCI_QUIRK(0x17aa, 0x3938, "Lenovo G565", CXT5066_AUTO),
>  	SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo", CXT5066_IDEAPAD), /* Fallback for Lenovos without dock mic */
> +	SND_PCI_QUIRK(0x1b0a, 0x2092, "CyberpowerPC Gamer Xplorer N57001", CXT5066_ASUS),
>  	{}
>  };
>  
> -- 
> 1.7.5.3
> 

Re: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC Gamer Xplorer N57001 laptop

[Daniel Chen]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

Hi Takashi,

On Thu, Jun 9, 2011 at 2:18 AM, Takashi Iwai <tiwai@suse.de> wrote:
> Any chance to test model=auto with the very latest snapshot driver (or
> 3.0-rc2 kernel)?  The auto-parser works better than the static quirk
> nowaday, but needs a bit more testing before switching to it as
> default.

The original reporter has verified that the autoparser in the latest
snapshot driver works well. Thus, this patch is only necessary for
2.6.38 and 2.6.39, which I've clarified in the commit message in the
newly attached patch.

Cheers,
-Dan

[-- Attachment #2: 0001-ALSA-hda-Fix-inaudible-internal-speakers-on-Cyberpow.patch --]
[-- Type: text/x-diff, Size: 1454 bytes --]

From 8ac45699337eaeea1d746142b7ae5cd8e59054fa Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Fri, 10 Jun 2011 09:30:53 -0400
Subject: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC
 Gamer Xplorer N57001 laptop

BugLink: https://launchpad.net/bugs/761171

The original reporter needs the model=asus quirk for his internal
speakers to be audible, so add an entry in the quirk table for his PCI
SSID.

This patch is only necessary for 2.6.38 and 2.6.39 kernels. The auto-
parser in 3.0 works much better, and the original reporter has tested
it successfully in the latest alsa-driver daily snapshot.

Reported-and-tested-by: tomdeering7
Cc: <stable@kernel.org> [2.6.38, 2.6.39]
Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
 sound/pci/hda/patch_conexant.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 9fbfd3b..acb3c30 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3135,6 +3135,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo U350", CXT5066_ASUS),
 	SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS),
 	SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo", CXT5066_IDEAPAD), /* Fallback for Lenovos without dock mic */
+	SND_PCI_QUIRK(0x1b0a, 0x2092, "CyberpowerPC Gamer Xplorer N57001", CXT5066_ASUS),
 	{}
 };
 
-- 
1.7.5.3


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC Gamer Xplorer N57001 laptop

[Takashi Iwai]

At Fri, 10 Jun 2011 09:39:16 -0400,
Daniel Chen wrote:
> 
> Hi Takashi,
> 
> On Thu, Jun 9, 2011 at 2:18 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > Any chance to test model=auto with the very latest snapshot driver (or
> > 3.0-rc2 kernel)?  The auto-parser works better than the static quirk
> > nowaday, but needs a bit more testing before switching to it as
> > default.
> 
> The original reporter has verified that the autoparser in the latest
> snapshot driver works well. Thus, this patch is only necessary for
> 2.6.38 and 2.6.39, which I've clarified in the commit message in the
> newly attached patch.

Does 3.0-rc2 (or snapshot) work _as is_, or by passing model=auto?
In the latter case, we'd need a corresponding entry, at least for 3.0.
For 3.1, I'm going to apply model=auto as default.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC Gamer Xplorer N57001 laptop

[Daniel Chen]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi Takashi,

On Fri, Jun 10, 2011 at 10:00 AM, Takashi Iwai <tiwai@suse.de> wrote:
> Does 3.0-rc2 (or snapshot) work _as is_, or by passing model=auto?
> In the latter case, we'd need a corresponding entry, at least for 3.0.
> For 3.1, I'm going to apply model=auto as default.

Apologies for being unclear. The reporter needs to explicitly pass
model=auto using the snapshot. Attached is a patch _specifically for
sound-2.6 master HEAD and 3.0-rc2_ with an explanation for the
difference between the application of model quirks.

Cheers,
-Dan

[-- Attachment #2: 0001-ALSA-hda-Fix-inaudible-internal-speakers-on-Cyberpow.patch --]
[-- Type: text/x-diff, Size: 1470 bytes --]

From e62f8ba673609c7ea42eab2bffd7ab910cf70827 Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Fri, 10 Jun 2011 10:14:01 -0400
Subject: [PATCH v2] ALSA: hda: Fix inaudible internal speakers on
 CyberpowerPC Gamer Xplorer N57001 laptop

BugLink: https://launchpad.net/bugs/761171

The original reporter needs the model=auto quirk for his internal
speakers to be audible in the latest daily snapshot, so add an entry in
the quirk table for his PCI SSID.

A trivially different version of this patch using the model=asus quirk
should be applied to the 2.6.38 and 2.6.39 stable kernels. We don't use
the asus quirk in 3.0-rc2, because 3.0-rc2's autoparser is much
improved.

Reported-and-tested-by: tomdeering7
Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
 sound/pci/hda/patch_conexant.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 217ca9e..6e86427 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3103,6 +3103,7 @@ static const struct snd_pci_quirk cxt5066_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS),
 	SND_PCI_QUIRK(0x17aa, 0x3938, "Lenovo G565", CXT5066_AUTO),
 	SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo", CXT5066_IDEAPAD), /* Fallback for Lenovos without dock mic */
+	SND_PCI_QUIRK(0x1b0a, 0x2092, "CyberpowerPC Gamer Xplorer N57001", CXT5066_AUTO),
 	{}
 };
 
-- 
1.7.5.3


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ALSA: hda: Fix inaudible internal speakers on CyberpowerPC Gamer Xplorer N57001 laptop

[Takashi Iwai]

At Fri, 10 Jun 2011 10:23:59 -0400,
Daniel Chen wrote:
> 
> Hi Takashi,
> 
> On Fri, Jun 10, 2011 at 10:00 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > Does 3.0-rc2 (or snapshot) work _as is_, or by passing model=auto?
> > In the latter case, we'd need a corresponding entry, at least for 3.0.
> > For 3.1, I'm going to apply model=auto as default.
> 
> Apologies for being unclear. The reporter needs to explicitly pass
> model=auto using the snapshot. Attached is a patch _specifically for
> sound-2.6 master HEAD and 3.0-rc2_ with an explanation for the
> difference between the application of model quirks.

OK, then I apply this one for 3.0.  Meanwhile for older kernels,
please submit to stable tree individually with the modified quirk
entry but keeping the upstream commit id once when the patch is merged
to the upstream (maybe in 3.0-rc3).


thanks,

Takashi

> 
> Cheers,
> -Dan
> [2 0001-ALSA-hda-Fix-inaudible-internal-speakers-on-Cyberpow.patch <text/x-diff; US-ASCII (base64)>]
> From e62f8ba673609c7ea42eab2bffd7ab910cf70827 Mon Sep 17 00:00:00 2001
> From: Daniel T Chen <crimsun@ubuntu.com>
> Date: Fri, 10 Jun 2011 10:14:01 -0400
> Subject: [PATCH v2] ALSA: hda: Fix inaudible internal speakers on
>  CyberpowerPC Gamer Xplorer N57001 laptop
> 
> BugLink: https://launchpad.net/bugs/761171
> 
> The original reporter needs the model=auto quirk for his internal
> speakers to be audible in the latest daily snapshot, so add an entry in
> the quirk table for his PCI SSID.
> 
> A trivially different version of this patch using the model=asus quirk
> should be applied to the 2.6.38 and 2.6.39 stable kernels. We don't use
> the asus quirk in 3.0-rc2, because 3.0-rc2's autoparser is much
> improved.
> 
> Reported-and-tested-by: tomdeering7
> Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
> ---
>  sound/pci/hda/patch_conexant.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 217ca9e..6e86427 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -3103,6 +3103,7 @@ static const struct snd_pci_quirk cxt5066_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS),
>  	SND_PCI_QUIRK(0x17aa, 0x3938, "Lenovo G565", CXT5066_AUTO),
>  	SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo", CXT5066_IDEAPAD), /* Fallback for Lenovos without dock mic */
> +	SND_PCI_QUIRK(0x1b0a, 0x2092, "CyberpowerPC Gamer Xplorer N57001", CXT5066_AUTO),
>  	{}
>  };
>  
> -- 
> 1.7.5.3
>