All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: add quirk for Lenovo Thinkpad X12 speakers
@ 2022-04-09 22:44 ` Tao Jin
  0 siblings, 0 replies; 4+ messages in thread
From: Tao Jin @ 2022-04-09 22:44 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Tao Jin, Jaroslav Kysela, alsa-devel, linux-kernel, stable

For this specific device on Lenovo Thinkpad X12 tablet, the verbs were 
dumped by qemu running a guest OS that init this codec properly. 
After studying the dump, it turns out that 
the same quirk used by the other Lenovo devices can be reused. 

The patch was tested working against the mainline kernel. 

Cc: <stable@vger.kernel.org>
Signed-off-by: Tao Jin <tao-j@outlook.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 75ff7e8..a5d6f8a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9207,6 +9207,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x505d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x505f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x5062, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
+	SND_PCI_QUIRK(0x17aa, 0x508b, "Thinkpad X12 Gen 1", ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ALSA: hda/realtek: add quirk for Lenovo Thinkpad X12 speakers
@ 2022-04-09 22:44 ` Tao Jin
  0 siblings, 0 replies; 4+ messages in thread
From: Tao Jin @ 2022-04-09 22:44 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, Tao Jin, linux-kernel, stable

For this specific device on Lenovo Thinkpad X12 tablet, the verbs were 
dumped by qemu running a guest OS that init this codec properly. 
After studying the dump, it turns out that 
the same quirk used by the other Lenovo devices can be reused. 

The patch was tested working against the mainline kernel. 

Cc: <stable@vger.kernel.org>
Signed-off-by: Tao Jin <tao-j@outlook.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 75ff7e8..a5d6f8a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9207,6 +9207,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x505d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x505f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x5062, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
+	SND_PCI_QUIRK(0x17aa, 0x508b, "Thinkpad X12 Gen 1", ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x17aa, 0x511e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: add quirk for Lenovo Thinkpad X12 speakers
  2022-04-09 22:44 ` Tao Jin
@ 2022-04-11  7:31   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-04-11  7:31 UTC (permalink / raw)
  To: Tao Jin; +Cc: Takashi Iwai, Jaroslav Kysela, alsa-devel, linux-kernel, stable

On Sun, 10 Apr 2022 00:44:24 +0200,
Tao Jin wrote:
> 
> For this specific device on Lenovo Thinkpad X12 tablet, the verbs were 
> dumped by qemu running a guest OS that init this codec properly. 
> After studying the dump, it turns out that 
> the same quirk used by the other Lenovo devices can be reused. 
> 
> The patch was tested working against the mainline kernel. 
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Tao Jin <tao-j@outlook.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: add quirk for Lenovo Thinkpad X12 speakers
@ 2022-04-11  7:31   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-04-11  7:31 UTC (permalink / raw)
  To: Tao Jin; +Cc: linux-kernel, alsa-devel, Takashi Iwai, stable

On Sun, 10 Apr 2022 00:44:24 +0200,
Tao Jin wrote:
> 
> For this specific device on Lenovo Thinkpad X12 tablet, the verbs were 
> dumped by qemu running a guest OS that init this codec properly. 
> After studying the dump, it turns out that 
> the same quirk used by the other Lenovo devices can be reused. 
> 
> The patch was tested working against the mainline kernel. 
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Tao Jin <tao-j@outlook.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-12  9:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09 22:44 [PATCH] ALSA: hda/realtek: add quirk for Lenovo Thinkpad X12 speakers Tao Jin
2022-04-09 22:44 ` Tao Jin
2022-04-11  7:31 ` Takashi Iwai
2022-04-11  7:31   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.