All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Paul Menzel" <pmenzel+alsa-devel@molgen.mpg.de>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: Request driver probe from an async task
Date: Mon, 23 Apr 2018 14:21:44 +0200	[thread overview]
Message-ID: <s5hpo2qru3r.wl-tiwai@suse.de> (raw)
In-Reply-To: <ac50d966-5443-a833-7fcd-d4480a531097@molgen.mpg.de>

On Mon, 23 Apr 2018 14:05:52 +0200,
Paul Menzel wrote:
> 
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Date: Sat, 24 Mar 2018 09:28:43 +0100
> 
> On an ASRock E350M1, with Linux 4.17-rc1 according to `initcall_debug`
> calling `azx_driver_init` takes sometimes more than a few milliseconds,
> and up to 200 ms.
> 
> ```
> [    2.892598] calling  azx_driver_init+0x0/0xfe4 [snd_hda_intel] @ 218
> [    2.943002] initcall azx_driver_init+0x0/0xfe4 [snd_hda_intel]
> returned 0 after 49195 usecs
> ```
> 
> Trying to execute the Linux kernel in less than 500 ms, this is quite a
> hold-up, and therefore request the probe from an async task.
> 
> With this change, the test shows, that the function returns earlier.
> 
> ```
> [    3.254800] calling  azx_driver_init+0x0/0xfe4 [snd_hda_intel] @ 227
> [    3.254887] initcall azx_driver_init+0x0/0xfe4 [snd_hda_intel]
> returned 0 after 66 usecs
> ```
> 
> The same behavior is visible on a Dell OptiPlex 7010. The longer times
> seem to happen, when the module *e1000e* is probed during the same time.
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

What actually took so long?  Could you analyze further instead of
blindly putting the flag?


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Paul Menzel <pmenzel+alsa-devel@molgen.mpg.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Request driver probe from an async task
Date: Mon, 23 Apr 2018 14:21:44 +0200	[thread overview]
Message-ID: <s5hpo2qru3r.wl-tiwai@suse.de> (raw)
In-Reply-To: <ac50d966-5443-a833-7fcd-d4480a531097@molgen.mpg.de>

On Mon, 23 Apr 2018 14:05:52 +0200,
Paul Menzel wrote:
> 
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Date: Sat, 24 Mar 2018 09:28:43 +0100
> 
> On an ASRock E350M1, with Linux 4.17-rc1 according to `initcall_debug`
> calling `azx_driver_init` takes sometimes more than a few milliseconds,
> and up to 200 ms.
> 
> ```
> [    2.892598] calling  azx_driver_init+0x0/0xfe4 [snd_hda_intel] @ 218
> [    2.943002] initcall azx_driver_init+0x0/0xfe4 [snd_hda_intel]
> returned 0 after 49195 usecs
> ```
> 
> Trying to execute the Linux kernel in less than 500 ms, this is quite a
> hold-up, and therefore request the probe from an async task.
> 
> With this change, the test shows, that the function returns earlier.
> 
> ```
> [    3.254800] calling  azx_driver_init+0x0/0xfe4 [snd_hda_intel] @ 227
> [    3.254887] initcall azx_driver_init+0x0/0xfe4 [snd_hda_intel]
> returned 0 after 66 usecs
> ```
> 
> The same behavior is visible on a Dell OptiPlex 7010. The longer times
> seem to happen, when the module *e1000e* is probed during the same time.
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

What actually took so long?  Could you analyze further instead of
blindly putting the flag?


thanks,

Takashi

  reply	other threads:[~2018-04-23 12:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 12:05 [PATCH] ALSA: hda: Request driver probe from an async task Paul Menzel
2018-04-23 12:21 ` Takashi Iwai [this message]
2018-04-23 12:21   ` Takashi Iwai
2018-04-23 12:30   ` Paul Menzel
2018-04-23 12:33     ` Takashi Iwai
2018-04-24 11:59       ` Paul Menzel
2018-04-24 11:59         ` Paul Menzel
2018-04-24 12:15         ` Takashi Iwai
2018-04-24 12:15           ` Takashi Iwai
2018-04-24 14:03           ` Paul Menzel
2018-04-24 14:03             ` Paul Menzel
2018-04-24 14:10             ` Takashi Iwai
2018-04-24 14:10               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpo2qru3r.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pmenzel+alsa-devel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.