Re: [1/2]ALSA: hda: add Zhaoxin HDAC non-snoop support

Re: [1/2]ALSA: hda: add Zhaoxin HDAC non-snoop support

[Takashi Iwai]

On Wed, 14 Apr 2021 14:00:19 +0200,
Hans Hu(SH-RD) wrote:
> 
> Hi Takashi,
> 
> Recently, our(AZX_DRIVER_ZHAOXIN) HDAC controller has added the feature of non-snoop mode, we have written a draft patch for it and hope to be accepted.

The code change looks good.  Please go ahead with the proper
submission.


thanks,

Takashi

> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index b59b0f3..420b728 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1702,6 +1702,14 @@ static void azx_check_snoop_available(struct azx *chip)
>  snoop = false;
>  }
> 
> +if (azx_get_snoop_type(chip) == AZX_SNOOP_TYPE_NONE &&
> +    chip->driver_type == AZX_DRIVER_ZHAOXIN) {
> +u8 val;
> +pci_read_config_byte(chip->pci, 0x42, &val);
> +if (!(val & 0x80))
> +snoop = false;
> +}
> +
>  if (chip->driver_caps & AZX_DCAPS_SNOOP_OFF)
>  snoop = false;
> 
> 
> Thanks,
> 　Hans Hu :)
> 
> 
> 保密声明：
> 本邮件含有保密或专有信息，仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。
> CONFIDENTIAL NOTE:
> This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited.