* [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
@ 2021-03-16 6:54 ` Jeremy Szu
0 siblings, 0 replies; 4+ messages in thread
From: Jeremy Szu @ 2021-03-16 6:54 UTC (permalink / raw)
To: tiwai
Cc: Jeremy Szu, Jaroslav Kysela, Kailang Yang, Jian-Hong Pan,
Kai-Heng Feng, Hui Wang, Huacai Chen, Thomas Hebb,
moderated list:SOUND, open list
* The HP EliteBook 840 G8 Notebook PC is using ALC285 codec which is
using 0x04 to control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b47504fa8dfd..e568bf460bae 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8048,6 +8048,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
+ SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
--
2.30.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
@ 2021-03-16 6:54 ` Jeremy Szu
0 siblings, 0 replies; 4+ messages in thread
From: Jeremy Szu @ 2021-03-16 6:54 UTC (permalink / raw)
To: tiwai
Cc: moderated list:SOUND, Kailang Yang, Thomas Hebb, Jeremy Szu,
open list, Huacai Chen, Jian-Hong Pan, Hui Wang, Kai-Heng Feng
* The HP EliteBook 840 G8 Notebook PC is using ALC285 codec which is
using 0x04 to control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b47504fa8dfd..e568bf460bae 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8048,6 +8048,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
+ SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
--
2.30.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
2021-03-16 6:54 ` Jeremy Szu
@ 2021-03-16 7:14 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-03-16 7:14 UTC (permalink / raw)
To: Jeremy Szu
Cc: tiwai, Jaroslav Kysela, Kailang Yang, Jian-Hong Pan,
Kai-Heng Feng, Hui Wang, Huacai Chen, Thomas Hebb,
moderated list:SOUND, open list
On Tue, 16 Mar 2021 07:54:50 +0100,
Jeremy Szu wrote:
>
> * The HP EliteBook 840 G8 Notebook PC is using ALC285 codec which is
> using 0x04 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
@ 2021-03-16 7:14 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-03-16 7:14 UTC (permalink / raw)
To: Jeremy Szu
Cc: moderated list:SOUND, Kailang Yang, Thomas Hebb, open list,
Huacai Chen, Jian-Hong Pan, tiwai, Hui Wang, Kai-Heng Feng
On Tue, 16 Mar 2021 07:54:50 +0100,
Jeremy Szu wrote:
>
> * The HP EliteBook 840 G8 Notebook PC is using ALC285 codec which is
> using 0x04 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-16 7:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 6:54 [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8 Jeremy Szu
2021-03-16 6:54 ` Jeremy Szu
2021-03-16 7:14 ` Takashi Iwai
2021-03-16 7:14 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.