* [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed
@ 2021-01-15 15:41 Colin King
2021-01-15 15:52 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2021-01-15 15:41 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Alexander Tsoy, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable param_period_time_if_needed is being initialized with a value
that is never read, the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/usb/pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index f71965bf815f..ed654338f6b7 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
{
const struct audioformat *fp;
unsigned int pt, ptmin;
- int param_period_time_if_needed = -1;
+ int param_period_time_if_needed;
int err;
runtime->hw.formats = subs->formats;
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed
2021-01-15 15:41 [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed Colin King
2021-01-15 15:52 ` Takashi Iwai
@ 2021-01-15 15:52 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-01-15 15:52 UTC (permalink / raw)
To: Colin King
Cc: Jaroslav Kysela, Takashi Iwai, Alexander Tsoy, alsa-devel,
kernel-janitors, linux-kernel
On Fri, 15 Jan 2021 16:41:51 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable param_period_time_if_needed is being initialized with a value
> that is never read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This doesn't look applicable to the latest tree.
Could you check again?
thanks,
Takashi
> ---
> sound/usb/pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index f71965bf815f..ed654338f6b7 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
> {
> const struct audioformat *fp;
> unsigned int pt, ptmin;
> - int param_period_time_if_needed = -1;
> + int param_period_time_if_needed;
> int err;
>
> runtime->hw.formats = subs->formats;
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed
@ 2021-01-15 15:52 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-01-15 15:52 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, kernel-janitors, linux-kernel, Takashi Iwai, Alexander Tsoy
On Fri, 15 Jan 2021 16:41:51 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable param_period_time_if_needed is being initialized with a value
> that is never read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This doesn't look applicable to the latest tree.
Could you check again?
thanks,
Takashi
> ---
> sound/usb/pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index f71965bf815f..ed654338f6b7 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
> {
> const struct audioformat *fp;
> unsigned int pt, ptmin;
> - int param_period_time_if_needed = -1;
> + int param_period_time_if_needed;
> int err;
>
> runtime->hw.formats = subs->formats;
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed
@ 2021-01-15 15:52 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-01-15 15:52 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, kernel-janitors, linux-kernel, Takashi Iwai, Alexander Tsoy
On Fri, 15 Jan 2021 16:41:51 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable param_period_time_if_needed is being initialized with a value
> that is never read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This doesn't look applicable to the latest tree.
Could you check again?
thanks,
Takashi
> ---
> sound/usb/pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index f71965bf815f..ed654338f6b7 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
> {
> const struct audioformat *fp;
> unsigned int pt, ptmin;
> - int param_period_time_if_needed = -1;
> + int param_period_time_if_needed;
> int err;
>
> runtime->hw.formats = subs->formats;
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-15 15:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 15:41 [PATCH][next] ALSA: usb-audio: remove initialization of param_period_time_if_needed Colin King
2021-01-15 15:52 ` Takashi Iwai
2021-01-15 15:52 ` Takashi Iwai
2021-01-15 15:52 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.