Re: [PATCH] Fixed no headphone sound bug on laptop Samsung Notebook Pen S, by using exsisting patch Linus' tree as commit 14425f1f521f (ALSA: hda/realtek: Add quirk for Samsung Notebook). This laptop uses same ALC298 but different subsystem id 0x144dc812. So I add SND_PCI_QUIRK at sound/pci/hda/patch_realtek.c

Re: [PATCH] Fixed no headphone sound bug on laptop Samsung Notebook Pen S, by using exsisting patch Linus' tree as commit 14425f1f521f (ALSA: hda/realtek: Add quirk for Samsung Notebook). This laptop uses same ALC298 but different subsystem id 0x144dc812. So I add SND_PCI_QUIRK at sound/pci/hda/patch_realtek.c

[Takashi Iwai]

On Thu, 02 Jul 2020 10:17:09 +0200,
Joonho Wohn wrote:
> 
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 737ef82a75fd..ebedc6093642 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7528,6 +7528,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
>  	SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
>  	SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8),
> +	SND_PCI_QUIRK(0x144d, 0xc812, "Samsung Notebook Pen S (NT950SBE-X58)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
>  	SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),

Thanks for the patch.

The code change itself looks OK, but the patch has to be provided in a
formal way described in Documentation/process/submitting-patches.rst.

That is,
- Move the description about your change into the mail body, not in
  the mail subject; keep the mail subject concise
- Don't forget to give your Signed-off-by line, which is a legal
  requirement

Once after fixing those, please resubmit the patch.


thanks,

Takashi

Re: [PATCH] Fixed no headphone sound bug on laptop Samsung Notebook Pen S, by using exsisting patch Linus' tree as commit 14425f1f521f (ALSA: hda/realtek: Add quirk for Samsung Notebook). This laptop uses same ALC298 but different subsystem id 0x144dc812. So I add SND_PCI_QUIRK at sound/pci/hda/patch_realtek.c

[Junar Wohn]

Thanks for your feedback.
It's really helpful to me.
I'll revise email and send you again soon.

2020년 7월 7일 (화) 오후 8:01, Takashi Iwai <tiwai@suse.de>님이 작성:

> On Thu, 02 Jul 2020 10:17:09 +0200,
> Joonho Wohn wrote:
> >
> > ---
> >  sound/pci/hda/patch_realtek.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c
> b/sound/pci/hda/patch_realtek.c
> > index 737ef82a75fd..ebedc6093642 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -7528,6 +7528,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {
> >       SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen
> (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
> >       SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro
> (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
> >       SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)",
> ALC269_FIXUP_ATIV_BOOK_8),
> > +     SND_PCI_QUIRK(0x144d, 0xc812, "Samsung Notebook Pen S
> (NT950SBE-X58)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
> >       SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807",
> ALC283_FIXUP_HEADSET_MIC),
> >       SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120",
> ALC283_FIXUP_HEADSET_MIC),
> >       SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)",
> ALC283_FIXUP_HEADSET_MIC),
>
> Thanks for the patch.
>
> The code change itself looks OK, but the patch has to be provided in a
> formal way described in Documentation/process/submitting-patches.rst.
>
> That is,
> - Move the description about your change into the mail body, not in
>   the mail subject; keep the mail subject concise
> - Don't forget to give your Signed-off-by line, which is a legal
>   requirement
>
> Once after fixing those, please resubmit the patch.
>
>
> thanks,
>
> Takashi
>