All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	alsa-devel@alsa-project.org, Hersen Wu <hersenxs.wu@amd.com>,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] sound/pci/hda: add sienna_cichlid audio asic id for sienna_cichlid up
Date: Wed, 03 Jun 2020 11:39:28 +0200	[thread overview]
Message-ID: <s5hsgfcebe7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200603013137.1849404-1-alexander.deucher@amd.com>

On Wed, 03 Jun 2020 03:31:37 +0200,
Alex Deucher wrote:
> 
> From: Hersen Wu <hersenxs.wu@amd.com>
> 
> dp/hdmi ati hda is not shown in audio settings
> 
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Applied now with a slight rearrangement with the sorted order and Cc
to stable.

But also wondering whether do we have a device with 1002:ab30?
It's missing between this one and the next one.


thanks,

Takashi

> ---
>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 92a042e34d3e..4188bc4bd4e2 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2643,6 +2643,9 @@ static const struct pci_device_id azx_ids[] = {
>  	{ PCI_DEVICE(0x1002, 0xab38),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
>  	  AZX_DCAPS_PM_RUNTIME },
> +	{ PCI_DEVICE(0x1002, 0xab28),
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	/* VIA VT8251/VT8237A */
>  	{ PCI_DEVICE(0x1106, 0x3288), .driver_data = AZX_DRIVER_VIA },
>  	/* VIA GFX VT7122/VX900 */
> -- 
> 2.25.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	alsa-devel@alsa-project.org, Hersen Wu <hersenxs.wu@amd.com>,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] sound/pci/hda: add sienna_cichlid audio asic id for sienna_cichlid up
Date: Wed, 03 Jun 2020 11:39:28 +0200	[thread overview]
Message-ID: <s5hsgfcebe7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200603013137.1849404-1-alexander.deucher@amd.com>

On Wed, 03 Jun 2020 03:31:37 +0200,
Alex Deucher wrote:
> 
> From: Hersen Wu <hersenxs.wu@amd.com>
> 
> dp/hdmi ati hda is not shown in audio settings
> 
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Applied now with a slight rearrangement with the sorted order and Cc
to stable.

But also wondering whether do we have a device with 1002:ab30?
It's missing between this one and the next one.


thanks,

Takashi

> ---
>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 92a042e34d3e..4188bc4bd4e2 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2643,6 +2643,9 @@ static const struct pci_device_id azx_ids[] = {
>  	{ PCI_DEVICE(0x1002, 0xab38),
>  	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
>  	  AZX_DCAPS_PM_RUNTIME },
> +	{ PCI_DEVICE(0x1002, 0xab28),
> +	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +	  AZX_DCAPS_PM_RUNTIME },
>  	/* VIA VT8251/VT8237A */
>  	{ PCI_DEVICE(0x1106, 0x3288), .driver_data = AZX_DRIVER_VIA },
>  	/* VIA GFX VT7122/VX900 */
> -- 
> 2.25.4
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-06-03  9:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  1:31 [PATCH] sound/pci/hda: add sienna_cichlid audio asic id for sienna_cichlid up Alex Deucher
2020-06-03  1:31 ` Alex Deucher
2020-06-03  9:39 ` Takashi Iwai [this message]
2020-06-03  9:39   ` Takashi Iwai
2020-06-04 16:20   ` Alex Deucher
2020-06-04 16:20     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsgfcebe7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=hersenxs.wu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.