* [PATCH] [v2] ALSA: line6: fix check on snd_card_register
@ 2019-01-06 17:01 Aditya Pakki
2019-01-07 10:58 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Aditya Pakki @ 2019-01-06 17:01 UTC (permalink / raw)
To: pakki001; +Cc: kjlu, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
The fix checks if snd_card_register() fails, and if so logs the error
via dev_err() consistent with other patches.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
sound/usb/line6/pod.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/usb/line6/pod.c b/sound/usb/line6/pod.c
index 020c81818951..ce45b6dab651 100644
--- a/sound/usb/line6/pod.c
+++ b/sound/usb/line6/pod.c
@@ -320,7 +320,8 @@ static void pod_startup4(struct work_struct *work)
line6_read_serial_number(&pod->line6, &pod->serial_number);
/* ALSA audio interface: */
- snd_card_register(line6->card);
+ if (snd_card_register(line6->card))
+ dev_err(line6->ifcdev, "Failed to register POD card.\n");
}
/* POD special files: */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] ALSA: line6: fix check on snd_card_register
2019-01-06 17:01 [PATCH] [v2] ALSA: line6: fix check on snd_card_register Aditya Pakki
@ 2019-01-07 10:58 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2019-01-07 10:58 UTC (permalink / raw)
To: Aditya Pakki; +Cc: alsa-devel, Jaroslav Kysela, kjlu, linux-kernel
On Sun, 06 Jan 2019 18:01:47 +0100,
Aditya Pakki wrote:
>
> The fix checks if snd_card_register() fails, and if so logs the error
> via dev_err() consistent with other patches.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] ALSA: line6: fix check on snd_card_register
@ 2019-01-07 10:58 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2019-01-07 10:58 UTC (permalink / raw)
To: Aditya Pakki; +Cc: alsa-devel, Jaroslav Kysela, kjlu, linux-kernel
On Sun, 06 Jan 2019 18:01:47 +0100,
Aditya Pakki wrote:
>
> The fix checks if snd_card_register() fails, and if so logs the error
> via dev_err() consistent with other patches.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-07 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-06 17:01 [PATCH] [v2] ALSA: line6: fix check on snd_card_register Aditya Pakki
2019-01-07 10:58 ` Takashi Iwai
2019-01-07 10:58 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.