shouldnt the #define for reg 0x5c be called AC97_VENDOR_RESERVED?

shouldnt the #define for reg 0x5c be called AC97_VENDOR_RESERVED?

[John Utz]

[-- Attachment #1.1: Type: text/plain, Size: 645 bytes --]

Just a thought!

When I grepped for 5c I found some non-obvious things that make sense
with respect to the people that implemented the drivers:

[jutz@localhost mntgto]$ find . -name \*.h -exec grep -Hn AC97 {} \; |
grep -i 5C

./alsa/alsa-driver-1.0.14rc2/sound/include/ac97_codec.h:283:#define
AC97_AD_TEST2               0x5c    /* undocumented test register 2 */
./alsa/alsa-driver-1.0.14rc2/sound/include/ac97_codec.h:299:#define
AC97_CXR_AUDIO_MISC 0x5c

 but as near as I can tell it's called 'vendor reserved'
(AC '97 Component Specification p62 - 'Vendor Reserved Registers 5A=5Fh,
70h - 7Ah)


John L. Utz III




[-- Attachment #1.2: Type: text/html, Size: 4681 bytes --]

[-- Attachment #2: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: shouldnt the #define for reg 0x5c be called AC97_VENDOR_RESERVED?

[Takashi Iwai]

At Wed, 7 Feb 2007 14:14:50 -0800,
John Utz wrote:
> 
> Just a thought!
> 
> When I grepped for 5c I found some non-obvious things that make sense with respect to
> the people that implemented the drivers:
> 
> [jutz@localhost mntgto]$ find . -name \*.h -exec grep -Hn AC97 {} \; | grep -i 5C
> 
> ./alsa/alsa-driver-1.0.14rc2/sound/include/ac97_codec.h:283:#define
> AC97_AD_TEST2               0x5c    /* undocumented test register 2 */
> 
> ./alsa/alsa-driver-1.0.14rc2/sound/include/ac97_codec.h:299:#define
> AC97_CXR_AUDIO_MISC 0x5c
> 
>  but as near as I can tell it’s called ‘vendor reserved’
> 
> (AC ’97 Component Specification p62 – ‘Vendor Reserved Registers 5A=5Fh, 70h – 7Ah)

You can define 0x5c as AC97_VENDOR_RESERVED in addition, of course.
But you don't have to replace already existing definitions.  Their
meanings are clearer than VENDOR_RESERVED.


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel