[PATCH] ASoC: pcm5102a: Provide a menu selection text

[PATCH] ASoC: pcm5102a: Provide a menu selection text

[Jörg Krause]

Provide a menu selection text so that users can enable, disable or
mark it as module in menuconfig.

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 084c2aa..9ee9591 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -624,7 +624,7 @@ config SND_SOC_PCM3168A_SPI
 	select REGMAP_SPI
 
 config SND_SOC_PCM5102A
-	tristate
+	tristate "Texas Instruments PCM5102A CODEC"
 
 config SND_SOC_PCM512x
 	tristate
-- 
2.10.2

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: pcm5102a: Provide a menu selection text

[Takashi Iwai]

On Tue, 20 Dec 2016 17:26:59 +0100,
Jörg Krause wrote:
> 
> Provide a menu selection text so that users can enable, disable or
> mark it as module in menuconfig.

What's the reason to enable it at all?  The codec entries are usually
not user-selectable but enabled by the machine driver.


Takashi

> 
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> ---
>  sound/soc/codecs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 084c2aa..9ee9591 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -624,7 +624,7 @@ config SND_SOC_PCM3168A_SPI
>  	select REGMAP_SPI
>  
>  config SND_SOC_PCM5102A
> -	tristate
> +	tristate "Texas Instruments PCM5102A CODEC"
>  
>  config SND_SOC_PCM512x
>  	tristate
> -- 
> 2.10.2
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: pcm5102a: Provide a menu selection text

[Jörg Krause]

On Wed, 2016-12-28 at 16:09 +0100, Takashi Iwai wrote:
> On Tue, 20 Dec 2016 17:26:59 +0100,
> Jörg Krause wrote:
> > 
> > Provide a menu selection text so that users can enable, disable or
> > mark it as module in menuconfig.
> 
> What's the reason to enable it at all?  The codec entries are usually
> not user-selectable but enabled by the machine driver.

To allow using it with the simple-card driver.

> 
> > 
> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> > ---
> >  sound/soc/codecs/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> > index 084c2aa..9ee9591 100644
> > --- a/sound/soc/codecs/Kconfig
> > +++ b/sound/soc/codecs/Kconfig
> > @@ -624,7 +624,7 @@ config SND_SOC_PCM3168A_SPI
> >  	select REGMAP_SPI
> >  
> >  config SND_SOC_PCM5102A
> > -	tristate
> > +	tristate "Texas Instruments PCM5102A CODEC"
> >  
> >  config SND_SOC_PCM512x
> >  	tristate
> > -- 
> > 2.10.2
> > 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: pcm5102a: Provide a menu selection text

[Takashi Iwai]

On Thu, 29 Dec 2016 16:59:43 +0100,
Jörg Krause wrote:
> 
> On Wed, 2016-12-28 at 16:09 +0100, Takashi Iwai wrote:
> > On Tue, 20 Dec 2016 17:26:59 +0100,
> > Jörg Krause wrote:
> > > 
> > > Provide a menu selection text so that users can enable, disable or
> > > mark it as module in menuconfig.
> > 
> > What's the reason to enable it at all?  The codec entries are usually
> > not user-selectable but enabled by the machine driver.
> 
> To allow using it with the simple-card driver.

See, now you know what's missing in your patch :)


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: pcm5102a: Provide a menu selection text

[Jörg Krause]

On Thu, 2016-12-29 at 20:04 +0100, Takashi Iwai wrote:
> On Thu, 29 Dec 2016 16:59:43 +0100,
> Jörg Krause wrote:
> > 
> > On Wed, 2016-12-28 at 16:09 +0100, Takashi Iwai wrote:
> > > On Tue, 20 Dec 2016 17:26:59 +0100,
> > > Jörg Krause wrote:
> > > > 
> > > > Provide a menu selection text so that users can enable, disable
> > > > or
> > > > mark it as module in menuconfig.
> > > 
> > > What's the reason to enable it at all?  The codec entries are
> > > usually
> > > not user-selectable but enabled by the machine driver.
> > 
> > To allow using it with the simple-card driver.
> 
> See, now you know what's missing in your patch :)

Unforunately not. I adopted commit 465011fc5671 which does not has any
dependency. Please enlighten me :)

Jörg
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: pcm5102a: Provide a menu selection text

[Takashi Iwai]

On Thu, 05 Jan 2017 21:17:19 +0100,
Jörg Krause wrote:
> 
> On Thu, 2016-12-29 at 20:04 +0100, Takashi Iwai wrote:
> > On Thu, 29 Dec 2016 16:59:43 +0100,
> > Jörg Krause wrote:
> > > 
> > > On Wed, 2016-12-28 at 16:09 +0100, Takashi Iwai wrote:
> > > > On Tue, 20 Dec 2016 17:26:59 +0100,
> > > > Jörg Krause wrote:
> > > > > 
> > > > > Provide a menu selection text so that users can enable, disable
> > > > > or
> > > > > mark it as module in menuconfig.
> > > > 
> > > > What's the reason to enable it at all?  The codec entries are
> > > > usually
> > > > not user-selectable but enabled by the machine driver.
> > > 
> > > To allow using it with the simple-card driver.
> > 
> > See, now you know what's missing in your patch :)
> 
> Unforunately not. I adopted commit 465011fc5671 which does not has any
> dependency. Please enlighten me :)

The missing piece is one of the most important things in writing a
patch -- the proper information explaining "why" this change is
needed, preferably in a form of changelog text.  Instead, you wrote
merely what you changed, which is pretty obvious and doesn't help
understanding.

The commit you referred to is no good example in this manner at all,
unfortunately.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: pcm5102a: Provide a menu selection text

[Jörg Krause]

Hi Takashi,

On Thu, 2017-01-05 at 21:29 +0100, Takashi Iwai wrote:
> On Thu, 05 Jan 2017 21:17:19 +0100,
> Jörg Krause wrote:
> > 
> > On Thu, 2016-12-29 at 20:04 +0100, Takashi Iwai wrote:
> > > On Thu, 29 Dec 2016 16:59:43 +0100,
> > > Jörg Krause wrote:
> > > > 
> > > > On Wed, 2016-12-28 at 16:09 +0100, Takashi Iwai wrote:
> > > > > On Tue, 20 Dec 2016 17:26:59 +0100,
> > > > > Jörg Krause wrote:
> > > > > > 
> > > > > > Provide a menu selection text so that users can enable,
> > > > > > disable
> > > > > > or
> > > > > > mark it as module in menuconfig.
> > > > > 
> > > > > What's the reason to enable it at all?  The codec entries are
> > > > > usually
> > > > > not user-selectable but enabled by the machine driver.
> > > > 
> > > > To allow using it with the simple-card driver.
> > > 
> > > See, now you know what's missing in your patch :)
> > 
> > Unforunately not. I adopted commit 465011fc5671 which does not has
> > any
> > dependency. Please enlighten me :)
> 
> The missing piece is one of the most important things in writing a
> patch -- the proper information explaining "why" this change is
> needed, preferably in a form of changelog text.  Instead, you wrote
> merely what you changed, which is pretty obvious and doesn't help
> understanding.
> 
> The commit you referred to is no good example in this manner at all,
> unfortunately.

I see and I fully agree! I will send an updated version with a better
commit log.

Jörg
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel